From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: scratch/x_emacs d2df826 5/5: fixup! Revert x_frame_parameter -> frame_parameter_pos change Date: Wed, 17 Apr 2019 10:24:47 +0200 Message-ID: References: <20190416165204.7024.23185@vcs0.savannah.gnu.org> <20190416165207.442F52068F@vcs0.savannah.gnu.org> <87zhopc1ia.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255092"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 17 10:25:03 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGfsN-0014G8-Aw for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 10:25:03 +0200 Original-Received: from localhost ([127.0.0.1]:48869 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGfsL-00054k-Kb for ged-emacs-devel@m.gmane.org; Wed, 17 Apr 2019 04:25:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGfsD-00054U-Gz for emacs-devel@gnu.org; Wed, 17 Apr 2019 04:24:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGfsC-0005n6-Gk for emacs-devel@gnu.org; Wed, 17 Apr 2019 04:24:53 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:50623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGfsC-0005m0-8P for emacs-devel@gnu.org; Wed, 17 Apr 2019 04:24:52 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id z11so2296014wmi.0 for ; Wed, 17 Apr 2019 01:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=rEJJDo1RBcEokAMqncLAHK1AtFOilifPjI6x2Ays3lY=; b=UaR471FxpFE43UPFETv5+0nNhtVc+0HlbgyQ9PVWFQ+figueRV/iXym9m0YZUa0kms fDjWVHzjEh90Ka8MLKHiX/0xnqy6Wgrsa4QYm9UE0PDM2M77Tom8rHG6b714XvmEMjiL t8YKoNZ6eRwITGCQbBaXPQIjDgh3TfoDh4b5drUqSnBI3siUGbGmYPCzB8Owt7tcsJjP mBZXFzWyeDsuCFEIxxP+O3sW5kY6VzZBzm3HenN24TEnDExdN2R4ymTw4a8hBzu+Tt6g uCxbZ/gOJI44HPtTMhKBDSUrow7PtA3E7WBjdAmJb1XviB6QS13olRhw9ojMWJXIrrBZ Kmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version; bh=rEJJDo1RBcEokAMqncLAHK1AtFOilifPjI6x2Ays3lY=; b=iVstd64AfAc/R+SV9Cb1kZ8zwZd0hEHC9ZO2Nlprz3q8rS9vax+8K5qQePYBEKvwZs y1aN5sN/C3p1GkvtGqTYh+n1QUuYW9doeFn3xBfl+nPVPm3GEu7Sc9Gw6o6pAtjpjc/2 CofvaWLw1UlvmXMPC33lSJE1PnJhJb7SBCIQjoc93cBPGa+RW4YyIArlAiwz/8EphgCh vFA2K+6IcOKz6Ey2MLxXEbWYm6/yIwaOouF/92yQfOi0OgBgy+uDThTNykB9ENy+DNcB tlmC6voTKp+2r0eBz1sCZxUGMNah1zwQC1dsWTR9L287XpzsJxTjInv/sg6aqwPa5jtF HAqA== X-Gm-Message-State: APjAAAUi4eJ3iDIx4qSPR7E+nZz9ryqsQjzb9BngIUmC0ScTiNmP6JdF KAqezthEDDpvtDSnwx/5Ha5M6A61 X-Google-Smtp-Source: APXvYqzSPk/gRn7/0MPz/G/OxtPxWTQ+45SNmihBJSsJ4DM9buQ9JFHME8aG0IgtwL5sX6x48jetLw== X-Received: by 2002:a05:600c:28d:: with SMTP id 13mr28031168wmk.82.1555489490553; Wed, 17 Apr 2019 01:24:50 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id q17sm44559481wrw.70.2019.04.17.01.24.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 17 Apr 2019 01:24:48 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87zhopc1ia.fsf@gmail.com> (Alex Gramiak's message of "Tue, 16 Apr 2019 11:18:21 -0600") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235567 Archived-At: >>>>> On Tue, 16 Apr 2019 11:18:21 -0600, Alex Gramiak said: Alex> Robert Pluim writes: >> CC xdisp.o xdisp.c:29300:37: error: no member named >> 'x_highlight_frame' in 'struct ns_display_info'; did you mean >> 'ns_highlight_frame'? || f != FRAME_DISPLAY_INFO >> (f)->x_highlight_frame) ^~~~~~~~~~~~~~~~~ ns_highlight_frame >> ./nsterm.h:884:17: note: 'ns_highlight_frame' declared here >> struct frame *ns_highlight_frame; ^ 1 error generated. >> >> (on macOS) Alex> Ah, I originally renamed the x_highlight_frame on W32/NS to Alex> {w32,ns}_*, but decided against it since xdisp.c used the Alex> attribute directly (a hook or union interface could be added Alex> later). Perhaps it should be renamed native_highlight_frame Alex> until then, though. Alex> I pushed the fix, do you get any other errors/warnings on Alex> macOS? nsterm.m:2400:1: error: conflicting types for 'ns_query_color' ns_query_color(void *col, XColor *color_def, bool setPixel) ^ ./nsterm.h:1146:1: note: previous declaration is here ns_query_color (void *col, XColor *color_def, int setPixel); ^ CC nsfns.o nsfns.m:1389:4: warning: implicit declaration of function 'x_make_frame_visible' is invalid in C99 [-Wimplicit-function-declaration] x_make_frame_visible (f); CC nsimage.o nsimage.m:196:11: warning: implicit declaration of function 'x_find_image_file' is invalid in C99 [-Wimplicit-function-declaration] found = x_find_image_file (file); ^ nsimage.m:196:9: warning: incompatible integer to pointer conversion assigning to 'Lisp_Object' (aka 'union Lisp_X *') from 'int' [-Wint-conversion] found = x_find_image_file (file); Robert