From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Mon, 14 Sep 2020 16:47:13 +0200 Message-ID: References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200910110832.ko66gqnqo4l664d6@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <83a6xsbexi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39425"; mail-complaints-to="usenet@ciao.gmane.io" Cc: spacibba@aol.com, casouri@gmail.com, emacs-devel@gnu.org, rekado@elephly.net, ams@gnu.org, Stefan Monnier , ghe@sdf.org, tecosaur@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 14 18:26:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHrJH-000AAA-3O for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 18:26:31 +0200 Original-Received: from localhost ([::1]:59274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHrJF-0005Ox-Ua for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Sep 2020 12:26:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHplH-0001yY-RQ for emacs-devel@gnu.org; Mon, 14 Sep 2020 10:47:19 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:36371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHplG-0004go-5d; Mon, 14 Sep 2020 10:47:19 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id z9so347976wmk.1; Mon, 14 Sep 2020 07:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=8r841aifegdxBkFo3J19JGBSXKV0qKj9w7msdwvQGMI=; b=FZY3IJfZRLZgFy7b4kEYyewwnE/2BaVqxbAjG+EV9tkReUY4Kr2mo0BpNdeMbRzIxc lb4ngjT/6QnQLLdIvs33V00y6GHGkwOJsx+vC4PwfuBgUroq7Dng5X9NC2BmlIxF7+TH nk8jDzJCbxjhHp2TzlYAnkGfNACU6sTAjfX0H9fDhB2EEuyoRiiYZT/aT+KZl+6OOuig eo8onU5Z+p/tZQvyUQ1s7KfQDpaMZUkTgmyO3hsdANxNqoD2Jf7wQ9hxTX8v8+zv3kPR EuPwntP5qJ1HSt+rjj2ZOtLWVWL0YprLxwhaUk/I+sL+VSlCP0odQ7RiIOa5DvavooZK fnPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=8r841aifegdxBkFo3J19JGBSXKV0qKj9w7msdwvQGMI=; b=jXPKIHHWpb4vmsEc1nbqTap4lozu4+CZNGSJBGofnmQbxjaJncPv0cj80QoZVqcaQL IZY1I/6y+dUPiDI3dnGGXHNE75iDPF14ggqx9AYBwZZPOZYM/UrcovD+j+eDWWopxhya bjhwPhOFxM3MX3T8tJAbPNW2RX+wqht2th6BAPRFpAGf7eDWDkh/Lt4ShPtai47qWO6N P6I1G7cBfLvdJl2Z2RGcGJHS8bT4Q0uVsReuzXgVNFycMx2g5gVEsu3e3SCnSkBr7i5x Xc1K3ptUEvEhVaDlcxud98VubpzDJwVANqnlYHYdJsDx0nuwnz2KRDusufu6J9c4bWxb bJvA== X-Gm-Message-State: AOAM533vATiGQtMcLnFh14CuvRIc8/SkM1qaIjR2M+EK1JQ1HErfyZTs Te423NgGmtEqzcFJKlOCBrH4vTxfAb5cRg== X-Google-Smtp-Source: ABdhPJwvdjZD7iWrqSi4MkPWUK0VzfNetD3e2eXlvRsFzNFpBVBeDPdicftzx6qZaInVjy9+p9yQZQ== X-Received: by 2002:a1c:66c4:: with SMTP id a187mr15097995wmc.148.1600094835213; Mon, 14 Sep 2020 07:47:15 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:5055:7f7f:92a2:59ec]) by smtp.gmail.com with ESMTPSA id 197sm20433322wme.10.2020.09.14.07.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 07:47:14 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <83a6xsbexi.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2020 17:39:37 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=rpluim@gmail.com; helo=mail-wm1-x333.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255660 Archived-At: >>>>> On Mon, 14 Sep 2020 17:39:37 +0300, Eli Zaretskii said: >> From: Stefan Monnier >> Cc: Eli Zaretskii , spacibba@aol.com, casouri@gmail.= com, >> emacs-devel@gnu.org, ams@gnu.org, ghe@sdf.org, tecosaur@gmail.com >> Date: Sun, 13 Sep 2020 16:16:17 -0400 >>=20 >> > I suppose that=E2=80=99s exactly what gtk_selection_bg_color and >> > gtk_selection_fg_color are supposed to do: take the colours from t= he GTK >> > theme. >> > >> > On Guix we build Emacs with the GTK toolkit. >>=20 >> So the bug is that we obey the "external" settings for the region but >> apparently not for the `default` face. Eli> Are we sure this is the case? Where's the code which uses the col= ors Eli> for the region? faces.el: (defface region '((((class color) (min-colors 88) (background dark)) :background "blue3" :extend t) (((class color) (min-colors 88) (background light) (type gtk)) :distant-foreground "gtk_selection_fg_color" :background "gtk_selection_bg_color" :extend t) 'region' is the only face this is done for. It=CA=BCs then used here: gtkutil.c: bool xg_check_special_colors (struct frame *f, const char *color_name, Emacs_Color *color) { bool success_p =3D 0; bool get_bg =3D strcmp ("gtk_selection_bg_color", color_name) =3D=3D 0; bool get_fg =3D !get_bg && strcmp ("gtk_selection_fg_color", color_name) = =3D=3D 0;