From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Darren Hoo Newsgroups: gmane.emacs.devel Subject: Re: emacs-24 r117050: Consult libpng-config more consistently. Date: Tue, 06 May 2014 13:04:31 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399413807 25949 80.91.229.3 (6 May 2014 22:03:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 May 2014 22:03:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 07 00:03:20 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WhnR2-0002FQ-Hz for ged-emacs-devel@m.gmane.org; Wed, 07 May 2014 00:02:00 +0200 Original-Received: from localhost ([::1]:32882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhXYx-0002P8-NJ for ged-emacs-devel@m.gmane.org; Tue, 06 May 2014 01:05:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhXYm-0002EY-5F for emacs-devel@gnu.org; Tue, 06 May 2014 01:05:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhXYb-0007ei-C2 for emacs-devel@gnu.org; Tue, 06 May 2014 01:04:56 -0400 Original-Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:49663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhXYb-0007e9-43 for emacs-devel@gnu.org; Tue, 06 May 2014 01:04:45 -0400 Original-Received: by mail-pa0-f47.google.com with SMTP id fa1so10735318pad.20 for ; Mon, 05 May 2014 22:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=BarWhMhA4FqpfLs2YFL6VLsPAC4dRXBozB1wve8W/MU=; b=qgwjFCK99esF0n0X9jRNK1x6Nl+gMApNESe/5fV71JA/Io72T7UuCegBeE0w17GyMq gQoApgmCpwPdYnB1fW8NiM8XYf1GIHjofSIYM1dxMvAo7v3nlF6XpFwP2wBzknqHwa6b aP6UQiJghw/OlQ4gCXs2ak8YduavdJTN5usaDwgzn80u3145tWQzta1V9LEXWfMAspIv Yg4m79Su9cgY/ooWm3zrqu3eMfHSr30Yji3oK1QOwkcH8EZPPQRk1ynFhqr2AMeEqcHN vmLUEYSLMd7YkJEYrr480Vk9Rq2PdFUaAOC2rWYx3vrE2KJur5FuSo7WxaNkULpTHvU2 S+Iw== X-Received: by 10.66.192.225 with SMTP id hj1mr2210476pac.142.1399352683552; Mon, 05 May 2014 22:04:43 -0700 (PDT) Original-Received: from Darren-rMBP.local (li679-91.members.linode.com. [23.239.1.91]) by mx.google.com with ESMTPSA id xz7sm87831956pac.3.2014.05.05.22.04.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 May 2014 22:04:42 -0700 (PDT) In-Reply-To: (Paul Eggert's message of "Fri, 02 May 2014 19:34:08 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (darwin) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171705 Archived-At: I would like to remind osx users that this change might cause build to fail if HomeBrew (with libpng) or XQuartz is installed, unset PATH before running ./configure so that libpng-config won't interfere. A question about code around line 5919 of image.c, Shouldn't this if conditional wrap the last line in? /* We use the current frame background, ignoring any default background color set by the image. */ #if defined (HAVE_X_WINDOWS) || defined (HAVE_NTGUI) XColor color; png_color_16 frame_background; color.pixel = FRAME_BACKGROUND_PIXEL (f); x_query_color (f, &color); memset (&frame_background, 0, sizeof frame_background); frame_background.red = color.red >> shift; frame_background.green = color.green >> shift; frame_background.blue = color.blue >> shift; #endif /* HAVE_X_WINDOWS */ fn_png_set_background (png_ptr, &frame_background, PNG_BACKGROUND_GAMMA_SCREEN, 0, 1.0);