unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master e6aab30 1/2: Handle encrypting mime parts
       [not found] ` <20201014231145.D146120B2C@vcs0.savannah.gnu.org>
@ 2020-10-15  7:38   ` Robert Pluim
  2020-10-16  4:11     ` Richard Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2020-10-15  7:38 UTC (permalink / raw)
  To: emacs-devel; +Cc: Richard M Stallman

>>>>> On Wed, 14 Oct 2020 19:11:45 -0400 (EDT), rms@gnu.org (Richard M. Stallman) said:


    Richard> diff --git a/lisp/epa-mail.el b/lisp/epa-mail.el
    Richard> index 3ad4da1..dd171ab 100644
    Richard> --- a/lisp/epa-mail.el
    Richard> +++ b/lisp/epa-mail.el
    Richard> @@ -243,6 +243,11 @@ If no one is selected, symmetric encryption will be performed.  "
    Richard>        (setq epa-last-coding-system-specified
    Richard>  	    (or coding-system-for-write
    Richard>  		(select-safe-coding-system (point) (point-max)))))
    Richard> + 
Ick           ^
    Richard> +    ;; Insert contents of requested attachments, if any.
    Richard> +    (when (and (eq major-mode 'mail-mode) mail-encode-mml)
    Richard> +      (mml-to-mime)
    Richard> +      (setq mail-encode-mml nil))
 
Why only in mail-mode? Is this not necessary in message-mode?

Robert
-- 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master e6aab30 1/2: Handle encrypting mime parts
  2020-10-15  7:38   ` master e6aab30 1/2: Handle encrypting mime parts Robert Pluim
@ 2020-10-16  4:11     ` Richard Stallman
  2020-10-16  7:39       ` Robert Pluim
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2020-10-16  4:11 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

I never used Message mode, and I never read its code.
So I can't try to maintain it.  I don't know whether it has
a command comparable to rmail-retry-failure.

Would you like to study its code and see whether it could use a
similar change?

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master e6aab30 1/2: Handle encrypting mime parts
  2020-10-16  4:11     ` Richard Stallman
@ 2020-10-16  7:39       ` Robert Pluim
  2020-10-17  4:22         ` Richard Stallman
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Pluim @ 2020-10-16  7:39 UTC (permalink / raw)
  To: Richard Stallman; +Cc: emacs-devel

>>>>> On Fri, 16 Oct 2020 00:11:57 -0400, Richard Stallman <rms@gnu.org> said:

    Richard> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
    Richard> [[[ whether defending the US Constitution against all enemies,     ]]]
    Richard> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    Richard> I never used Message mode, and I never read its code.
    Richard> So I can't try to maintain it.  I don't know whether it has
    Richard> a command comparable to rmail-retry-failure.

Iʼm missing context here: what's the relation to rmail-retry-failure?
The change you made is in epa-mail-encrypt.

    Richard> Would you like to study its code and see whether it could use a
    Richard> similar change?

I can, if I understand why the change was made in the first place
(although reading through 'rmail-forward' it appears that message.el
already does the mml->MIME conversion).

Robert
-- 



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master e6aab30 1/2: Handle encrypting mime parts
  2020-10-16  7:39       ` Robert Pluim
@ 2020-10-17  4:22         ` Richard Stallman
  2020-10-19 10:49           ` Robert Pluim
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2020-10-17  4:22 UTC (permalink / raw)
  To: Robert Pluim; +Cc: emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Iʼm missing context here: what's the relation to rmail-retry-failure?
  > The change you made is in epa-mail-encrypt.

Sorry, I made two changes and confused which one this was about.

With the burdensome amount of mail being sent now to emacs-devel
I have to rush through everything, no time to think twice.

But it is still the case that I know nothing about Mail mode
and can't maintain it.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master e6aab30 1/2: Handle encrypting mime parts
  2020-10-17  4:22         ` Richard Stallman
@ 2020-10-19 10:49           ` Robert Pluim
  0 siblings, 0 replies; 5+ messages in thread
From: Robert Pluim @ 2020-10-19 10:49 UTC (permalink / raw)
  To: Richard Stallman; +Cc: emacs-devel

>>>>> On Sat, 17 Oct 2020 00:22:39 -0400, Richard Stallman <rms@gnu.org> said:

    Richard> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
    Richard> [[[ whether defending the US Constitution against all enemies,     ]]]
    Richard> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    >> Iʼm missing context here: what's the relation to rmail-retry-failure?
    >> The change you made is in epa-mail-encrypt.

    Richard> Sorry, I made two changes and confused which one this was about.

    Richard> With the burdensome amount of mail being sent now to emacs-devel
    Richard> I have to rush through everything, no time to think twice.

    Richard> But it is still the case that I know nothing about Mail mode
    Richard> and can't maintain it.

OK. We'll just have to see if this causes issues for anyone using
message-mode, and fix it when that happens.

Robert
-- 



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-19 10:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20201014231143.24755.40979@vcs0.savannah.gnu.org>
     [not found] ` <20201014231145.D146120B2C@vcs0.savannah.gnu.org>
2020-10-15  7:38   ` master e6aab30 1/2: Handle encrypting mime parts Robert Pluim
2020-10-16  4:11     ` Richard Stallman
2020-10-16  7:39       ` Robert Pluim
2020-10-17  4:22         ` Richard Stallman
2020-10-19 10:49           ` Robert Pluim

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).