From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS symbols Date: Fri, 28 Jun 2024 14:13:45 +0200 Message-ID: References: <87r0chwnzx.fsf@gmail.com> <87ikxtwljl.fsf@gmail.com> <87cyo1wadz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="988"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 28 14:14:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNAUw-00005D-ML for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jun 2024 14:14:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNAUB-0005Lp-Ba; Fri, 28 Jun 2024 08:13:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNAUA-0005K4-01 for emacs-devel@gnu.org; Fri, 28 Jun 2024 08:13:50 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNAU8-0006EP-GZ for emacs-devel@gnu.org; Fri, 28 Jun 2024 08:13:49 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-366df217347so387046f8f.0 for ; Fri, 28 Jun 2024 05:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719576827; x=1720181627; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nu7XvQOOLP3tCA7QZsvb16tuHverJRBr9y07LmG/LO4=; b=G6EKU6ZjXOiojXRndFqkMamG+bmjj+v1Lvpcg9cvsNEiqyziaHEyv/H5DS68IgITBO Oo847gEROIzr9+LgTcBoo/eNv+45bq4hFj7VBDlTaDSLIlAtlGxgHR2ACneSAweGVYZM vKS9FQdosFH2tbYD7BeDoysKNzfGrM0S0mDB1P12t1tjjAO/Q17iQyzOWmiVq8uj2O3E zizIQfJKJYepOzxLF4te7TPQHe5saQGawOXuRRfnsWb5CX5NtIHQIRomhL3LtJJNvxos rNw43K2uwsl5r7/zyTLSxfr2kdoPlFmaf2RCRp4dTuoD4l9EM5F3UoQo2PlJfMOStqOV PQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719576827; x=1720181627; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Nu7XvQOOLP3tCA7QZsvb16tuHverJRBr9y07LmG/LO4=; b=l6kv4i97ggWkzQVs+cfDXDR1GKTUtl4V0y59CYy+Wrzswp1iwY2SPp3pCJMQA89r/U YOObCadeIrnnJlSjvg0tdAa5YMgZucY7X5rSGK3OTzq2khskcO67D+0PoyvCJKZuJfqU DbSzjwcbaMOQMwGOCD70Vq5ZDoHqeZmHCQObExYoZ9pBhOluhto5yORYZQtr3EBiRGA3 c0x+5vWU+BUPXlmEsJF6lJqNeWhgaVq04d8DvO+2CmDCJAXPtP5RHolYLJevcvHOTaHe LnPI/MrQZUgIwjbzh4UwjNpIv3gnT/72PXzXeUK8L/v9Z78PaPBYoPXH4VeJZ+AvHbeF ss/A== X-Gm-Message-State: AOJu0YzU9RXrWH8mFsaCjZlonbzrDq/mVRBduZAlodnFJWT1b1r9Dc2s VdAEGY+AyjNBBvY7CQB9XpM7KqFWub5drKDBb6TEWSWOnTgssiJorQKmZw== X-Google-Smtp-Source: AGHT+IF0uicS8RvesGdiGwRFi6qoHFqtq0+Oo2zaZFGMCHVponxpPgq26cZCawvb+vtl4noMqi5mUA== X-Received: by 2002:adf:f092:0:b0:365:f52f:cd44 with SMTP id ffacd0b85a97d-366e9629fa7mr10266349f8f.57.1719576826567; Fri, 28 Jun 2024 05:13:46 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e360da.dip0.t-ipconnect.de. [217.227.96.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a103d0dsm2150426f8f.104.2024.06.28.05.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 05:13:46 -0700 (PDT) In-Reply-To: <87cyo1wadz.fsf@gmail.com> (Helmut Eller's message of "Fri, 28 Jun 2024 13:54:16 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=gerd.moellmann@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320813 Archived-At: Helmut Eller writes: > On Fri, Jun 28 2024, Gerd M=C3=B6llmann wrote: > >> Gerd M=C3=B6llmann writes: >> >>> Forgot something. While looking at the scanner, I wondered if we could >>> remove the is_mps check from fix_lisp_obj now that we have the dump >>> in MPS... >> >> Let's find out, pushed. Works for me :-) > > I think this uncovered a bug. Now this > > emacs -Q -eval '(progn (view-hello-file) (forward-line 7) (dotimes (_ 5) > (redisplay) (igc--collect) (forward-line)))' -f kill-emacs > > causes a SIGSEGV in fix_font, > > case FONT_OBJECT_MAX: > { > struct font *f =3D (struct font *)v; > const Lisp_Object *type =3D &f->driver->type; > IGC_FIX12_OBJ (ss, igc_const_cast (Lisp_Object *, type)); > } > > It turns out that f->driver is the variable xfont_driver and it is > actually const and the type field is a builtin symbol. So it looks like > we can remove fix_font completely. Hm, okay. Can you see why is segfaults? I'm wondering because I'd have thought that we'd crash all over the place if we couldn't handle built-in symbols...