From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Wed, 03 Jul 2024 13:17:37 +0200 Message-ID: References: <1VNw6cPSIpKfxNRqQBpVleX2BDbQuUqwLQzo-C8N-_PRvNNLG3BnhbcWpUJkiJYnOogBvqRTcLApebjqdZel7CgXVx9T0CnPn6_go_AugDA=@protonmail.com> <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33606"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Helmut Eller , Eli Zaretskii , Emacs Devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 13:18:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOy0W-0008XX-Qr for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 13:18:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOxzk-0002Ns-Fs; Wed, 03 Jul 2024 07:17:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOxzh-0002NW-7k for emacs-devel@gnu.org; Wed, 03 Jul 2024 07:17:49 -0400 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sOxzf-0007Y4-4a; Wed, 03 Jul 2024 07:17:48 -0400 Original-Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a725041ad74so206473066b.3; Wed, 03 Jul 2024 04:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720005463; x=1720610263; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qbjA2ZFc1p/g6gU4nwXNVTNP878LUz6NrzAdLq6cx2Q=; b=gf8bglHeHwEMeuox8ol9DyiKqzoVYmhZspFnllK8aZdLkUs8nUbG9vLvsc/KLxLn8S XaQ5Dj0fkF49DzPV/Jn+yrQO/ozDWX9Kf4ovAyLtcB7onthCHi8eH9hA7ULUy05CknXN 0hJMYjO5ShO5oW2x3Kml8lussfKufqklPJpqtOm9/e9p6du8iVK4DT3z7QQVHLUAROk8 GVorS5oQztdrrUXxdOm45aISGTyR87mNhlw76YS/154X2ZXD08QO20A7+0NH0fzEQqT+ i9mP75n78m6adSHZ64fdpuep0gn/0jhdIlb3bloVhpZxlMPX0fA6A9Uj6HmqJVxGbRTJ PWkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720005463; x=1720610263; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qbjA2ZFc1p/g6gU4nwXNVTNP878LUz6NrzAdLq6cx2Q=; b=imi5ijnaUvZ5n9i0dSw+rr3qENYoRkfbx6XcTwKcfDQlDeGxBjdThl3yHRLn+8JN86 QjplnVsp0f4uJxCd4MlTdyt9jCqXRlB/y8USz+qMLXXjIxF9NSrR03WfG2TfUyURcydv DzN5UWfl+CzGHUENLx+u7X50Vk+ZqyzfFZUaiH3oeLlx9TJ6M99LAwqiPO9J8EuF8qT1 Ff/eNhOGGMv716563rVUAWhQ4WLqeLgXY3SQ1u9LC2nzKG9LnQh8a4uImyYH10w5fs6J TCm39tPPBqeqAEBuQ6lIOL931B/VJ/IB5Q5PN3uF8aYQ11D28FBRZhIZtt7e/oXgFN4g AaTQ== X-Forwarded-Encrypted: i=1; AJvYcCUdC1dmfGMfDwssHiSi9kQ7Xar3mmxyoAE5945K0diuW9y9ruqArPP699uag3E2erqZZOYIlNmkUaXmcRrRWZkQHB4Fi3svKiDxV5w74qHCaQA= X-Gm-Message-State: AOJu0Yw2/NsrNCjFAeJG/76MbMYcWkbkCHLLl0SFDdgWAEGGycLOq/Lf hlR6aBaqhkFnITO59K14gohrq9ptmi1Tl+6BQHfC1/a0CDFIGpC2WnL2rw== X-Google-Smtp-Source: AGHT+IFMg3XiuFVwgz3pLhNOOcRmgWMflAWm0slqI04TGiFMSEzdyDR9QYDG0wjdnx77mCThKr0iag== X-Received: by 2002:a05:6402:d05:b0:57c:5874:4f5c with SMTP id 4fb4d7f45d1cf-587a0822c5bmr10293171a12.32.1720005462898; Wed, 03 Jul 2024 04:17:42 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e362dd.dip0.t-ipconnect.de. [217.227.98.221]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf1bb6bsm500186866b.30.2024.07.03.04.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 04:17:40 -0700 (PDT) In-Reply-To: (Pip Cet's message of "Wed, 03 Jul 2024 10:41:46 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321245 Archived-At: Pip Cet writes: >> > And of course the same needs to be done for the marker vector, right? >> >> >> Yep :-(. > > What's somewhat irritating is how hard it is to actually make it > produce an error. Only single-byte offset-mov is emulated, not mov > without an offset, but that's what gcc -O0 produces... > > On existing mps, we could just force AWLSegSALimit to 0 and > AWLHaveSegSALimit to true, which would avoid the issue :-/ > > We can always go back to my weak-hash-table-for-BUF_MARKERS idea, that > would reduce code duplication a little. Let me know if you'd prefer > that. I don't think that would make much sense to get rid of the vector. At the moment, with O(1) add/remove it's pretty optimal, even better than unchain_marker which is O(N). And the marker stuff is used really often. But I'm only speaking for myself. If it's easier to support IA32 that way, please feel free. I'm fine with it, really, not the least because I'm using some other Emacs :-).