* INLINE is disabled
@ 2010-11-20 8:44 Dan Nicolaescu
2010-11-20 9:37 ` Andreas Schwab
2010-11-20 10:38 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Dan Nicolaescu @ 2010-11-20 8:44 UTC (permalink / raw)
To: emacs-devel
From configure.in:
/* If using GNU, then support inline function declarations. */
/* Don't try to switch on inline handling as detected by AC_C_INLINE
generally, because even if non-gcc compilers accept `inline', they
may reject `extern inline'. */
#if defined (__GNUC__) && defined (OPTIMIZE)
#define INLINE __inline__
#else
#define INLINE
#endif
OPTIMIZE is never defined, so we always use #else...
Should we just remove "&& defined (OPTIMIZE)"?
On the 23 branch too?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: INLINE is disabled
2010-11-20 8:44 INLINE is disabled Dan Nicolaescu
@ 2010-11-20 9:37 ` Andreas Schwab
2010-11-20 10:38 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2010-11-20 9:37 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
Dan Nicolaescu <dann@gnu.org> writes:
> From configure.in:
>
> /* If using GNU, then support inline function declarations. */
> /* Don't try to switch on inline handling as detected by AC_C_INLINE
> generally, because even if non-gcc compilers accept `inline', they
> may reject `extern inline'. */
> #if defined (__GNUC__) && defined (OPTIMIZE)
> #define INLINE __inline__
> #else
> #define INLINE
> #endif
>
> OPTIMIZE is never defined, so we always use #else...
Most uses are on static functions, which are eligible for inlining
anyway.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: INLINE is disabled
2010-11-20 8:44 INLINE is disabled Dan Nicolaescu
2010-11-20 9:37 ` Andreas Schwab
@ 2010-11-20 10:38 ` Eli Zaretskii
2010-11-20 12:39 ` Andreas Schwab
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2010-11-20 10:38 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Sat, 20 Nov 2010 03:44:52 -0500
>
>
> From configure.in:
You meant config.in, right?
> /* If using GNU, then support inline function declarations. */
> /* Don't try to switch on inline handling as detected by AC_C_INLINE
> generally, because even if non-gcc compilers accept `inline', they
> may reject `extern inline'. */
> #if defined (__GNUC__) && defined (OPTIMIZE)
> #define INLINE __inline__
> #else
> #define INLINE
> #endif
>
> OPTIMIZE is never defined, so we always use #else...
>
> Should we just remove "&& defined (OPTIMIZE)"?
Yes, I think so. FWIW, nt/config.nt uses the above without OPTIMIZE
for quite some time.
> On the 23 branch too?
Not sure about that one, as we are in pretest.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: INLINE is disabled
2010-11-20 10:38 ` Eli Zaretskii
@ 2010-11-20 12:39 ` Andreas Schwab
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2010-11-20 12:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Dan Nicolaescu, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From configure.in:
>
> You meant config.in, right?
config.in is generated.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-20 12:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-20 8:44 INLINE is disabled Dan Nicolaescu
2010-11-20 9:37 ` Andreas Schwab
2010-11-20 10:38 ` Eli Zaretskii
2010-11-20 12:39 ` Andreas Schwab
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).