From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Tue, 19 Mar 2024 08:11:16 +0100 Message-ID: References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <87il1jdhzd.fsf@posteo.net> <87le6f9m8b.fsf@jeremybryant.net> <87o7basp70.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36342"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jeremy Bryant , Jeremy Bryant via "Emacs development discussions." , Eli Zaretskii , monnier@iro.umontreal.ca, j.j.oddie@gmail.com, stefankangas@gmail.com, jonas@bernoul.li To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 08:12:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmTds-0009G4-75 for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 08:12:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmTdE-00063A-ML; Tue, 19 Mar 2024 03:11:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmTd4-0005x7-Ob for emacs-devel@gnu.org; Tue, 19 Mar 2024 03:11:25 -0400 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmTd2-00057p-R9; Tue, 19 Mar 2024 03:11:22 -0400 Original-Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-563bb51c36eso5952353a12.2; Tue, 19 Mar 2024 00:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710832278; x=1711437078; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HwZQBR1Ch6tLVmj9dT2SSpSw7e2F8DFumVluXNo5W3s=; b=aYVedyeZgT6ICnYuzGm4/iO+L3ibQsM08OoNiwB4h/q2DOtG8WFxCMuLWvRjRLkuOT tZ5I9EOTiIn5fw8UNpFwpBhFyejyUMMo7wWlhcp8Yglz0yqdyRfgTvwqQkO2CsIHnSC4 3zpAPhP+pjWc/TVJsERZ/fc3sV8BMSOb715Q3UMj96/SnarA2rNLatdoDqxpvV/Zd6nd MNunDyTKv1klSRocK9z53JXVSSm3xelXeGsPaBS0jy78F1BYep6lLo8Jp1NkHAnlaKzb fg+JY6ufwDgl49ZOfKQsC6iOokE4nfL6kU4m51rZdh4kPmEbzIrIpholu2/0YkJPk/XJ hxRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710832278; x=1711437078; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HwZQBR1Ch6tLVmj9dT2SSpSw7e2F8DFumVluXNo5W3s=; b=lnzMmPHhZguuWIsIDmgQkdnq2TY11eLUKoFkY9lCMWtm4HLhEhN5vCYIysEeiqTiT9 K4ltvQcEiZ8YUzs/CJAnFUAfQ768BrcMk3KHg+1T7ITy4zaqHB0sPOeiiwSeyD+i6WI1 mhhmH4A93JmE3Ku6T4c+zVb0bH/vfNY9pTgL8e6XLcCcRln+TuKE2zVmhoOwC/XDFdHM 64crvBCVhjq+W7UX4up4ryftLTpg8Pe99WB5GKSFpDHpuNfqPnH4dkrLltGbHlALegk3 Kh1z7odsLskeaNbAp9/zSWBynIvCMIppTHsqsqYmmrdXKZhfTHGtPiVPXNzv812KByOE QeRQ== X-Forwarded-Encrypted: i=1; AJvYcCV/yVLSMzgLGxtn1GsY0P2KUHb2YVNg4qSGfhKGU5sFqj0XQ/zWdzVpfWzZALF7P69aWMlcOC+MXANKCg+0aK6XoXIaQM9Uv3rVg8nWAMKoNC0= X-Gm-Message-State: AOJu0YxmhpJL8PcKZB/6Mmy6kpP25LCn0Qll4vX73nRNHkrl9zB3ULPj bfKjzjS/RONERKiZ0xh0Q1WBRTmVh7ByLAtd0Nx383qkyt37hUhT X-Google-Smtp-Source: AGHT+IEKv3oDBPgft62n3/Q/E5gvwuTsMx2xf0RsbJ5dKLtnHFHorz4QB+NT6Ot/w54Rb1XxwTOs1w== X-Received: by 2002:a17:906:6c91:b0:a46:8c0a:4dbe with SMTP id s17-20020a1709066c9100b00a468c0a4dbemr1143651ejr.9.1710832277988; Tue, 19 Mar 2024 00:11:17 -0700 (PDT) Original-Received: from Pro.fritz.box (p4fe3a1bc.dip0.t-ipconnect.de. [79.227.161.188]) by smtp.gmail.com with ESMTPSA id j1-20020a1709062a0100b00a46af0fbf5dsm2907391eje.103.2024.03.19.00.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 00:11:17 -0700 (PDT) In-Reply-To: <87o7basp70.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 19 Mar 2024 06:36:35 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317181 Archived-At: Philip Kaludercic writes: >> (add-hook 'c-mode-hook #'macrostep-c-mode-hook) > > This part is suspicious. First of all, it looks like one is adding a > hook to a hook, but this would unconditionally modify > c-mode-hook, which I don't think is reliable. Can we find some other > way to update the variables, depending on the major mode? E.g. in > macrostep.el one could try to intern (format "macrostep-%s-init" > major-mode) and check if the symbol is fboundp? Also, it would be nice to support C++ and Objc, which we have in Emacs (c-mode-common-hook).