mac - crash when scrolling wheely mouse when all frames are minimized

mac - crash when scrolling wheely mouse when all frames are minimized

[John Paul Wallington]

On Mac OS X.1.5, minimizing all frames (but ensuring that Emacs has the
focus; the global menubar is Emacs') then scrolling the mouse wheel
causes a crash:

Program received signal EXC_BAD_ACCESS, Could not access memory.
0x0013d2dc in XTread_socket (sd=0, bufp=0xbffd11c8, numchars=2407900, expected=-1073934024) at macterm.c:12660
12660                   XSETFRAME (bufp->frame_or_window, mwp->mFP);

-- 
John Paul Wallington

Re: mac - crash when scrolling wheely mouse when all frames are minimized

[Andrew Choi]

jpw@shootybangbang.com (John Paul Wallington) writes:

> On Mac OS X.1.5, minimizing all frames (but ensuring that Emacs has the
> focus; the global menubar is Emacs') then scrolling the mouse wheel
> causes a crash:
> 
> Program received signal EXC_BAD_ACCESS, Could not access memory.
> 0x0013d2dc in XTread_socket (sd=0, bufp=0xbffd11c8, numchars=2407900, expected=-1073934024) at macterm.c:12660
> 12660                   XSETFRAME (bufp->frame_or_window, mwp->mFP);

I don't use a wheel mouse so I can't test this.  But please try adding
the following lines:

	  if (!IsValidWindowPtr (window_ptr))
	    {
	      SysBeep (1);
	      UNBLOCK_INPUT;
	      return 0;
	    }

in macterm.c (XTread_socket):

  	  case kEventClassMouse:
	    if (GetEventKind (eventRef) == kEventMouseWheelMoved) 
	      {
		SInt32 delta;
		Point point;
		WindowPtr window_ptr = FrontNonFloatingWindow ();
		struct mac_output *mwp = (mac_output *) GetWRefCon (window_ptr);
                <=== add the code here

		GetEventParameter(eventRef, kEventParamMouseWheelDelta,
				  typeSInt32, NULL, sizeof (SInt32),
				  NULL, &delta);

Re: mac - crash when scrolling wheely mouse when all frames are minimized

[John Paul Wallington]

Andrew Choi wrote:

> > Program received signal EXC_BAD_ACCESS, Could not access memory.
> > 0x0013d2dc in XTread_socket (sd=0, bufp=0xbffd11c8,
> > numchars=2407900, expected=-1073934024) at macterm.c:12660 12660
> > XSETFRAME (bufp->frame_or_window, mwp->mFP);
>  
>  I don't use a wheel mouse so I can't test this.  But please try
>  adding the following lines:
>  
>  	  if (!IsValidWindowPtr (window_ptr))
>  	    {
>  	      SysBeep (1);
>  	      UNBLOCK_INPUT;
>  	      return 0;
>  	    }
>  
>  in macterm.c (XTread_socket):
>  
>    	  case kEventClassMouse: if (GetEventKind (eventRef) ==
>  	    kEventMouseWheelMoved) { SInt32 delta; Point point;
>  	    WindowPtr window_ptr = FrontNonFloatingWindow ();
>  	    struct mac_output *mwp = (mac_output *) GetWRefCon
>  	    (window_ptr); <=== add the code here

Your fix works.  Thanks!

-- 
John Paul Wallington

Re: mac - crash when scrolling wheely mouse when all frames are minimized

[Steven Tamm]

Fixed & checked in.   Andrew's changes worked for me (on 10.2.3).

Thanks,
-Steven

On Monday, January 20, 2003, at 07:34  AM, John Paul Wallington wrote:

> On Mac OS X.1.5, minimizing all frames (but ensuring that Emacs has the
> focus; the global menubar is Emacs') then scrolling the mouse wheel
> causes a crash:
>
> Program received signal EXC_BAD_ACCESS, Could not access memory.
> 0x0013d2dc in XTread_socket (sd=0, bufp=0xbffd11c8, numchars=2407900, 
> expected=-1073934024) at macterm.c:12660
> 12660                   XSETFRAME (bufp->frame_or_window, mwp->mFP);
>
> -- 
> John Paul Wallington
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel