unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Choi <akochoi_nospam_@shaw.ca>
Subject: Fix for Mac OS X Garbage Collection Crashes
Date: Sun, 12 Oct 2003 17:57:50 -0600	[thread overview]
Message-ID: <m2pth2uhz5.fsf@owlbear.local> (raw)

If you've updated and built Emacs from CVS on OS X within the past few
weeks, you may have experienced crashes while Emacs is doing garbage
collection. The following patch, just checked into CVS, solves the
problem. I highly recommend updating to include it.

Index: darwin.h
===================================================================
RCS file: /cvs/emacs/src/s/darwin.h,v
retrieving revision 1.12
diff -r1.12 darwin.h
319a320,323
> /* Use the GC_MAKE_GCPROS_NOOPS (see lisp.h) method for marking the
>    stack.  */
> #define GC_MARK_STACK   GC_MAKE_GCPROS_NOOPS
> 

The problem is caused by a change to src/alloc.c about a month ago that
causes garbage collection to crash under certain circumstances (when
LISP_INT values are on the gcprolist) if GC_MARK_STACK is set to
GC_USE_GCPROS_AS_BEFORE. The best way to fix the problem is probably to
fix the bug introduced. I don't want to work on that. Instead I have now
set GC_MARK_STACK to GC_MAKE_GCPROS_NOOPS. This option for GC has been
chosen on nearly all other platforms. So by following suit on OS X, we
may actually be using better-maintained code in the future. This is
probably a better solution.

             reply	other threads:[~2003-10-12 23:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-12 23:57 Andrew Choi [this message]
2003-10-14 21:31 ` Fix for Mac OS X Garbage Collection Crashes Stefan Monnier
2003-10-14 22:33   ` Andrew Choi
2003-10-15 15:08     ` Stefan Monnier
2003-10-15 15:45       ` Andrew Choi
2003-10-15 17:05         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2pth2uhz5.fsf@owlbear.local \
    --to=akochoi_nospam_@shaw.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).