* Could anyone tackle Emacs bug#23794 in sort-lines before Emacs 26 is released?
@ 2017-09-22 0:07 Robert Weiner
2017-09-22 5:59 ` John Wiegley
0 siblings, 1 reply; 3+ messages in thread
From: Robert Weiner @ 2017-09-22 0:07 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
This is the bug that sort-lines since Emacs 25 has not handled collapsed
(invisible) lines properly (keeping them with their parents) when sorting.
Prior to Emacs 25, sort-lines handled outline sorting properly.
It should be a fairly straightforward thing (relative to the complexity of
other Emacs issues) since it is well understood and a potential patch has
been offered. Eli suggested that any change be limited to outlining modes
to limit its effects.
I cannot work on it myself right now and that is why I am asking someone
else to pick it up.
I think this is a bug that should be eliminated before Emacs 26 goes live
so it does not impact people with large outlines who might sort them and
get the wrong results but not notice until their data has been corrupted
for a while and they can't get back to the original proper hierarchical
associations.
At the very least the present behavior makes no sense for outline modes
that use invisibility for collapsing.
Bob
[-- Attachment #2: Type: text/html, Size: 1994 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Could anyone tackle Emacs bug#23794 in sort-lines before Emacs 26 is released?
2017-09-22 0:07 Could anyone tackle Emacs bug#23794 in sort-lines before Emacs 26 is released? Robert Weiner
@ 2017-09-22 5:59 ` John Wiegley
2017-09-22 8:38 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: John Wiegley @ 2017-09-22 5:59 UTC (permalink / raw)
To: Robert Weiner; +Cc: rswgnu, emacs-devel
>>>>> "RW" == Robert Weiner <rsw@gnu.org> writes:
RW> I think this is a bug that should be eliminated before Emacs 26 goes live
RW> so it does not impact people with large outlines who might sort them and
RW> get the wrong results but not notice until their data has been corrupted
RW> for a while and they can't get back to the original proper hierarchical
RW> associations.
This does seem like something worth fixing in 26. Do you have a sense of how
large a change this might be? Is anyone else willing to take up the task?
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Could anyone tackle Emacs bug#23794 in sort-lines before Emacs 26 is released?
2017-09-22 5:59 ` John Wiegley
@ 2017-09-22 8:38 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2017-09-22 8:38 UTC (permalink / raw)
To: John Wiegley; +Cc: rswgnu, emacs-devel, rsw
> From: John Wiegley <jwiegley@gmail.com>
> Date: Thu, 21 Sep 2017 22:59:54 -0700
> Cc: rswgnu@gmail.com, emacs-devel <emacs-devel@gnu.org>
>
> >>>>> "RW" == Robert Weiner <rsw@gnu.org> writes:
>
> RW> I think this is a bug that should be eliminated before Emacs 26 goes live
> RW> so it does not impact people with large outlines who might sort them and
> RW> get the wrong results but not notice until their data has been corrupted
> RW> for a while and they can't get back to the original proper hierarchical
> RW> associations.
>
> This does seem like something worth fixing in 26. Do you have a sense of how
> large a change this might be?
You can see it here:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23794#20
It lacks documentation bits. And I'd be glad to see someone else
commenting on the problem and the solution.
Btw: the problem was not introduced in Emacs 25, as Robert says, it
was introduced much earlier, in Emacs 22.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-22 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-22 0:07 Could anyone tackle Emacs bug#23794 in sort-lines before Emacs 26 is released? Robert Weiner
2017-09-22 5:59 ` John Wiegley
2017-09-22 8:38 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).