From: Robert Pluim <rpluim@gmail.com>
To: Daniel Pittman <slippycheeze@google.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: macOS NS GUI crash due to invalid font pointer in frame struct while marking
Date: Thu, 23 Jan 2020 20:10:11 +0100 [thread overview]
Message-ID: <m2pnfaat0s.fsf@gmail.com> (raw)
In-Reply-To: <CAC45yQtYtgGZsfp0R4wSmnomHRgzczH5t9kS46zr_ukYPbdmNA@mail.gmail.com> (Daniel Pittman's message of "Thu, 23 Jan 2020 11:16:39 -0500")
>>>>> On Thu, 23 Jan 2020 11:16:39 -0500, Daniel Pittman <slippycheeze@google.com> said:
Daniel> G'day. I've come across a crash during GC on macOS 10.15.2, GNU Emacs
Daniel> built from source, git d97a77c481ec913d8c3c24f2eecdc41a28243678.
Daniel> The crash is located at:
...-> mark_window->mark_vectorlike->mark_frame
Daniel> In this the bad pointer is in (struct frame).output_data.ns.font, where the
Daniel> pointer is wildly out of the memory map, and so crashes trying to determine
Daniel> if that was marked.
Daniel> I haven't yet tracked this down to a root cause, but before I invest
Daniel> significant time in that I'd like to know if anyone else is investigating
Daniel> this, or something similar to this?
Daniel> Reproduction is, painfully, just a matter of waiting for a crash. It seems
Daniel> to be vaguely correlated to external process interactions, but can't find a
Daniel> clear root cause.
Daniel> I'll work to get a fix, of course, but wanted to avoid duplicating work if
Daniel> someone else already has this in hand, or knows more.
git sh 2eb834ead401fa83270cad585a4310e2e05b8baa
commit 2eb834ead401fa83270cad585a4310e2e05b8baa
Author: Pip Cet <pipcet@gmail.com>
AuthorDate: Mon Jan 20 17:27:43 2020 +0100
Commit: Robert Pluim <rpluim@gmail.com>
CommitDate: Mon Jan 20 17:27:43 2020 +0100
Clear output data pointer on NS
* src/nsterm.m (ns_free_frame_resources): Clear the output data
pointer to prevent attempting to reuse freed resources (Bug#38748).
diff --git a/src/nsterm.m b/src/nsterm.m
index 03754e5ae5..c1d1d41117 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -1644,6 +1644,7 @@ Hide the window (X11 semantics)
[view release];
xfree (f->output_data.ns);
+ f->output_data.ns = NULL;
unblock_input ();
}
next prev parent reply other threads:[~2020-01-23 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:16 macOS NS GUI crash due to invalid font pointer in frame struct while marking Daniel Pittman
2020-01-23 19:10 ` Robert Pluim [this message]
2020-01-24 15:04 ` Daniel Pittman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pnfaat0s.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=slippycheeze@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).