From: Robert Pluim <rpluim@gmail.com>
To: Caio Henrique <caiohcs0@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] remove save and undo text on tool-bar for gtk version
Date: Wed, 30 Sep 2020 18:58:40 +0200 [thread overview]
Message-ID: <m2pn632ocf.fsf@gmail.com> (raw)
In-Reply-To: <87blhntdl6.fsf@gmail.com> (Caio Henrique's message of "Wed, 30 Sep 2020 13:48:53 -0300")
>>>>> On Wed, 30 Sep 2020 13:48:53 -0300, Caio Henrique <caiohcs0@gmail.com> said:
Caio> Hi, these suggestions to improve the tool-bar consistency and also save
Caio> horizontal space got lost in the "Changes for emacs 28" discussion, so
Caio> I'm changing the subject. This only affects the gtk version, AFAIK windows
Caio> only shows the icons.
Caio> There were two proposals:
Caio> 1 - remove :vertonly from all tool-bar items and change the default
Caio> value of tool-bar-style to image
Caio> 2 - simply add :vertonly to save and undo
Caio> IMO option 1 is better, since option 2 makes the value text-image-horiz
Caio> useless.
Caio> This variable only affects the GTK+ toolkit version of Emacs. */);
Caio> - Vtool_bar_style = Qnil;
Caio> + Vtool_bar_style = Qimage;
Caio> DEFVAR_INT ("tool-bar-max-label-size", tool_bar_max_label_size,
Caio> doc: /* Maximum number of characters a label can have to be shown.
Caio> ____________
If you do this you'll need to update the version tag for
tool-bar-style in lisp/cus-start.el to "28.1" as well.
FWIW option 1 sounds good to me (although I donʼt use the toolbar at
all).
Robert
--
next prev parent reply other threads:[~2020-09-30 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:48 [PATCH] remove save and undo text on tool-bar for gtk version Caio Henrique
2020-09-30 16:58 ` Robert Pluim [this message]
2020-09-30 17:32 ` Caio Henrique
2020-09-30 17:00 ` Eli Zaretskii
2020-09-30 17:30 ` Caio Henrique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pn632ocf.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=caiohcs0@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).