From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Eli Zaretskii <eliz@gnu.org>
Cc: winkler@gnu.org, emacs-devel@gnu.org
Subject: Re: process-file instead of call-process in proced.el?
Date: Fri, 25 Mar 2022 13:24:10 +0300 [thread overview]
Message-ID: <m2pmmacotx.fsf@fastmail.fm> (raw)
In-Reply-To: <835yo2cyj9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 25 Mar 2022 09:54:34 +0300")
On 25/03/2022 09:54 +0300, Eli Zaretskii wrote:
>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Fri, 25 Mar 2022 03:09:12 +0300
>> Cc: winkler@gnu.org
>>
>> There's this TODO in proced.el:
>>
>> --8<---------------cut here---------------start------------->8---
>> ;; - Allow "sudo kill PID", "sudo renice PID"
>> --8<---------------cut here---------------end--------------->8---
>>
>> WDYT, can we just use process-file instead of call-process? Then, if
>> proced is opened from a /sudo:: (or su) buffer, and (setq
>> proced-signal-function "kill") is set, proced-send-signal "just works"
>> for processes owned by different user, with no special code in proced.
>>
>> The simple patch is below.
>
> Thanks, but this should be at least conditioned on systems that have
> these commands available. MS-Windows, for example, has neither 'kill'
> nor 'renice', and the equivalents of 'kill' that I know about don't
> accept a signal ID as a command-line argument.
The patch only changes call-process to process-file, to support file
handlers. Setting "kill" into proced-signal-function is a user
customization.
Thanks.
next prev parent reply other threads:[~2022-03-25 10:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 0:09 process-file instead of call-process in proced.el? Filipp Gunbin
2022-03-25 6:54 ` Eli Zaretskii
2022-03-25 10:24 ` Filipp Gunbin [this message]
2022-03-25 10:31 ` Eli Zaretskii
2022-03-25 11:46 ` Michael Albinus
2022-03-25 12:12 ` Eli Zaretskii
2022-03-25 12:29 ` Filipp Gunbin
2022-03-25 13:34 ` Roland Winkler
2022-03-25 13:58 ` Michael Albinus
2022-03-25 14:26 ` Filipp Gunbin
2022-03-25 14:29 ` Michael Albinus
2022-03-25 15:40 ` Filipp Gunbin
2022-03-25 15:43 ` Michael Albinus
2022-03-26 16:49 ` Michael Albinus
2022-03-26 17:37 ` Roland Winkler
2022-03-26 18:31 ` Michael Albinus
2022-03-26 18:49 ` Roland Winkler
2022-03-27 7:28 ` Michael Albinus
2022-03-27 14:08 ` Michael Albinus
2022-03-28 2:57 ` Roland Winkler
2022-03-28 7:41 ` Michael Albinus
2022-03-28 14:34 ` Roland Winkler
2022-03-28 14:53 ` Filipp Gunbin
2022-03-28 15:40 ` Michael Albinus
2022-03-28 16:11 ` Filipp Gunbin
2022-03-28 16:39 ` Michael Albinus
2022-03-28 19:42 ` Filipp Gunbin
2022-03-30 11:20 ` Michael Albinus
2022-03-30 15:34 ` Filipp Gunbin
2022-03-28 17:08 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pmmacotx.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).