From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Removing redisplay-dont-pause Date: Sun, 17 Nov 2024 06:43:06 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 17 06:43:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tCY4l-0005nk-6Y for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Nov 2024 06:43:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCY42-0006oO-FO; Sun, 17 Nov 2024 00:43:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCY41-0006oF-EN for emacs-devel@gnu.org; Sun, 17 Nov 2024 00:43:13 -0500 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCY3z-00005H-Sq for emacs-devel@gnu.org; Sun, 17 Nov 2024 00:43:13 -0500 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4315abed18aso8170375e9.2 for ; Sat, 16 Nov 2024 21:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731822189; x=1732426989; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=VINkn5WKJ1HRL3w0Dz0b1u7kFSvbOZLReOfR9EqZ47U=; b=gKVjGSfJQFmsuEvETosJ90WRSo2L90unWQAJenQOvgTXN7b1K1hPPxm0HvNbx9hYDH QWf6+bw4QFlN8/pOpNYf1ExYUKgTVArcFJVPFBrxEXyk7TTmmCdGjckxggVqCFvpywcg DOrmcA3vvMMGS/K6uAq8mbrC2DLYWpkB3q5Z4Yeksf+0w/Q+vSa4xIH9WYH3jbmjnj3P ZOYoHLMKAXzx4qx3ESVN7q659xCML7tHZA/o4VAggFokywkDC/nUbWq/Q/l8rd8mm33z 4fI/MICZ8H85uZI8jYT4pkYEi7huvUyRAhd04V/Y/WzcWVe64KeA+XBo9sib8u0qN1h0 kKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731822189; x=1732426989; h=content-transfer-encoding:mime-version:user-agent:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VINkn5WKJ1HRL3w0Dz0b1u7kFSvbOZLReOfR9EqZ47U=; b=jgTdv4wiMsJGwoNfNNLRw/LneO1IiwVpRyFvB3qd2d9d+Y5U0YY6AWYeWNXwOEuYOJ ulnbJ+BXwstxmtYqE21Dnbn0PiQWfL9EH0RCX6YgdQghcWqQLDjHrb3g+ZxP2gNaXBkl AADUR7khcGrk3V8sKANl4LRrvSXJNkAJOfe9p1Peg/NcIcEURr3P1es0zrv2azXqIm6a eH43tKL6dNDGVixJd+WSCmFQkfW2adGYK3Cqm/oGdzb8LUPemOzpW6JESsE4jvQWmaEq LLphqZxvjhL3cKa6HG2c/sMS7PlAFMGfQqDXxsPA10P/7qjZAHlpC+pZ6TjZ7guKjtyy EsJQ== X-Gm-Message-State: AOJu0YzGJ/YFOnXFWPZmzioL1Rp8cK6ampplfOGSWIfHHDiU5BVf1wtE rXXkewxrYm1Jg6RE/g9gWyjmY5a33Kh+jMWXA0I0yX9rwnERH9znPlzprg== X-Google-Smtp-Source: AGHT+IFFgBcBFkf8qnidmYkI0hHHUAtsNl/uyuitm7FR8nyLpgVot64N4T27SkCP5OpmresWYLKkKQ== X-Received: by 2002:a05:600c:8705:b0:431:612f:189b with SMTP id 5b1f17b1804b1-432df72a841mr72399285e9.12.1731822188645; Sat, 16 Nov 2024 21:43:08 -0800 (PST) Original-Received: from pro2 (pd9e36919.dip0.t-ipconnect.de. [217.227.105.25]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da29978dsm111334735e9.41.2024.11.16.21.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 21:43:07 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325485 Archived-At: Eli Zaretskii writes: >> branch: scratch/tty-child-frames >> commit f62d70f52f4f6b7ed158d618bf790df21f171172 >> Author: Gerd M=C3=B6llmann >> Commit: Gerd M=C3=B6llmann >> >> Don't pause display for pending input >> >> * src/dispnew.c: Remove display_completed, redisplay_dont_pause, >> redisplay-dont-pause was declared obsolete in Emacs 24. Remove anyt= hing >> checking pending input, change function signatures accordingly, and = so >> on. >> >> * src/keyboard.c (read_char): Don't use redisplay_dont_pause. >> * src/minibuf.c (read_minibuf): Use new function signatures. >> * src/xdisp.c: Don't check display_completed. Use new API. >> >> * lisp/subr.el (redisplay-dont-pause): Remove declaration. > > I don't think this kind of change is appropriate. Feature branches > should not add/remove features not directly related to the feature > being developed on the branch. If we want to remove > redisplay-dont-pause from Emacs (and I'm not yet sure we do), it > should be discussed on emacs-devel or in a dedicated bug report, not > silently installed on the branch. I guess not many know what this is about, so what is this about? One feature of the old redisplay was that it stopped updating the display when it detected that input was pending, so that it could process that input ASAP. I kept that feature in my redisplay. As a debugging aid, I added redisplay-dont-pause with which I could turn this feature on and off, because pausing the display lead to a lot subtle and difficult to debug bugs. ISTR that setting redisplay-dont-pause to t became sort of a secret semi-popular hack. Hyrum's Law in action, I guess. And 13 years ago or so, the default of redisplay-dont-pause was changed to t by Eli. 10 years ago, Stefan Monnier explained the why + /* Contrary to expectations, a value of "false" can be detrimental to + responsiveness since aborting a redisplay throws away some of the + work already performed. It's usually more efficient (and gives + more prompt feedback to the user) to let the redisplay terminate, + and just completely skip the next command's redisplay (which is + done regardless of this setting if there's pending input at the + beginning of the next redisplay). */ + redisplay_dont_pause =3D true; And finally, Stefan also (make-obsolete-variable 'redisplay-dont-pause nil "24.5") and removed it from the docs. I've removed that pausing feature in my fork and thought I'd bring that to master via scratch/tty-child-frames, but apparently that's controversial for some reason I don't understand, and I reverted that. And so, here we are.