From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Wed, 18 Dec 2024 15:03:19 +0100 Message-ID: References: <86seqmm9dq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , stefankangas@gmail.com, emacs-devel@gnu.org, pipcet@protonmail.com, monnier@iro.umontreal.ca To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 15:04:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNuey-0000WU-4G for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 15:04:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNue9-0005gV-5Z; Wed, 18 Dec 2024 09:03:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNue7-0005gJ-Hk for emacs-devel@gnu.org; Wed, 18 Dec 2024 09:03:27 -0500 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNue5-0003om-Oz; Wed, 18 Dec 2024 09:03:27 -0500 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-aa543c4db92so30434966b.0; Wed, 18 Dec 2024 06:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734530603; x=1735135403; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TeOqGUkJcxSmh5AWRuv3aKNHXTo9wkgfG014bF1v4wU=; b=Dm1OvS1FJvOxmTh7TVmrd2th0JOQYOzQy+zqxykTlOE+43c5b6KeKNbcqOnnBcdt/b TbuKl/8GDwIJtqwM+P2saWuB6O4U22L/qtcOp3bTqOv8Fsz+nZ2sEajJe4ROTYesFVno PuEhxli0mIjZOW3IohjRT67oPQ0rCOMtP2dtDkwDeqOuhv+5+WSiPCOsqtO3eeu6JXBk MoAIwSOlpbuxUlPjffgdYMAq/zuu6fdeDVuaZaE/+rSTVa65L43dx/ZAbTnO7wCDNUes aDPcUqHyYuOY3FSH8hfLUntBthz5ww10VkYfSggeYPFoUAthPnYTa/xwxbOf/yf3knTn B7mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734530603; x=1735135403; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TeOqGUkJcxSmh5AWRuv3aKNHXTo9wkgfG014bF1v4wU=; b=bELjlH/9ek3aa55RP8HzQ962LGItRbPmPduoj4N2REV0wGbaCWKnesbwx7CHfmtI3G LIDOqR3P9ZAmhraoA2Nt37w9W0r/3dAY8Azetxjx0KiWKSRe88XYXzc6FJ04dIxY3EvZ UiSLWfifn6YLVTm/AlSdEVToe2jodn2WF3D9KIwQVwIYxe1QVDpA848aySdB0q3afgio QKTvi/0aueoXzHQgAnzc+3nsDUb62nr/Y7vZr8WgW9Jm1+KYahedcMDbz1FjdzaoWO6E k5gqmz1qtbOQ4p3R7LnTaVQF+4AVMPhSxQaPIdofRiZweG0yP/Tgsif8d8ytm2gHXzgv 9Rdg== X-Forwarded-Encrypted: i=1; AJvYcCXvfvPcf0GMqlV9YCwfkDpJUFvWry2NXrM08ydHoGAhu6q0SR/9ziIA9AmsFChWNEh2KsmZt1dN0XjbYQ==@gnu.org X-Gm-Message-State: AOJu0YwEYFnYgufPUxuXs2YsjtcBke1rz9ATDpUXfYuDQwNfmstotfzJ RvVJX7KRqkt7TBV+j5ljgl2FGZvUF0eXkhjpSnS5fgY7O78ReqH5 X-Gm-Gg: ASbGncuKryJV9B7Q/L9hgBIO+LNPLqDCTlz5q8cnKj5ZGjiPyiis13UWNhmgaqShwH3 TD9a/Mo0k37VhlWJFITc24d6m/w9zzuSim9q5xaNKIyQQA5U95l3RSJKD92yyR+fXzvZc4ylVus 6eHoGf0wiUdlngT44jKxHaHivyV06KB/UPo5uDBOKaLYpBcVi3ut+RgnV7VhionQN/JtFNwpAWD jGD9fqTzcedQBNXTgoogxb4oMghLJbfOLATP4ox/SZzT3hxHGBkWe38ZmYvUhwjEHU94uu7jXk9 +0o48084HMmbLyP6TDAHyoR0q2lpGUnet4nUk9gRY1hf7OY2K2vGcMSUnJeVp+WH1g== X-Google-Smtp-Source: AGHT+IFfP7cTUMnPpYgjQu2bMOs0pwAu3i0RShQxMtn26rAbOxuaY9IcTNcuG/6qxzFBY1XXj/Ws7A== X-Received: by 2002:a17:907:c22:b0:aa6:375d:b96a with SMTP id a640c23a62f3a-aabf493267bmr244950866b.53.1734530602289; Wed, 18 Dec 2024 06:03:22 -0800 (PST) Original-Received: from pro2 (p200300e0b7267000f86be09dcd4cd505.dip0.t-ipconnect.de. [2003:e0:b726:7000:f86b:e09d:cd4c:d505]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab9638ec3dsm562715866b.150.2024.12.18.06.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 06:03:21 -0800 (PST) In-Reply-To: (Andrea Corallo's message of "Wed, 18 Dec 2024 07:55:17 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326653 Archived-At: Andrea Corallo writes: > Gerd M=C3=B6llmann writes: > >> Eli Zaretskii writes: >> >>>> From: Gerd M=C3=B6llmann >>>> Cc: emacs-devel@gnu.org, Pip Cet , Stefan Mon= nier >>>> >>>> Date: Tue, 17 Dec 2024 18:56:05 +0100 >>>>=20 >>>> Gerd M=C3=B6llmann writes: >>>>=20 >>>> > Gerd M=C3=B6llmann writes: >>>> > >>>> >> I think check_comp_unit_relocs should be removed in the branch. Wha= t's >>>> >> left of it the branch, checks in master if everything has been >>>> >> put in purespace which should be there. IIUC correctly, of course. >>>> > >>>> > Patch attached. >>>>=20 >>>> Pushed. Complaints to me please. >>> >>> I'd like at least Andrea to take a look and confirm. >> >> It's 81fc23b5d6a60ca4f3d269ab2c88eb9a850bac4c > > Hi Gerd, > > looking at the commit now, why do you think 'check_comp_unit_relocs' > should be removed?=20=20 > > Even if now the situation is simpler 'check_comp_unit_relocs' is still > performing some sanity checks like if lambdas are all been fixed-up and > present in 'comp_u->lambda_gc_guard_h'. > > Andrea Hi Andrea. The check you mention checks something that I don't see how it could happen. (With the usual disclaimers, because it's been some time since I was in that code for igc.) When we comp--register-lambda the code putting the result of make_subr into the hash table and putting it in data_relocs (in the branch) is just a handful of lines apart. I thereforeo thought we could do without.