Re: [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error

Re: [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error

[Stefan Monnier]

> branch: externals/dape
> commit bd1c30d52e44563b407d887f25fdfc6912b97df5
> Author: Daniel Pettersson <daniel@dpettersson.net>
> Commit: Daniel Pettersson <daniel@dpettersson.net>
>
>     Fix out of hexl region error

Reminds me: have you tried to offer a way to use `nhexl-mode` instead of
`hexl-mode`?  It might require changes to `nhexl-mode.el`, in order to
be able to adjust the base address, and maybe others, but I'd be
happy to adjust `nhexl-mode.el` to provide the necessary hooks to make
it work well.


        Stefan

Re: [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error

[Daniel Pettersson]

Hey Stefan!

I just installed nhexl-mode and it seams great.  Dapes integration with
hexl is a bit awkward as it doesn't support base address offset.

I am not sure if it makes sense to drop hexl support (if not nhexl is
moved into core) but I am all for adding some custom's for swapping out
hexl-mode for nhexl-mode if that is what the user wants.

Currently the dape-read-memory installs:
- variable for address offset
- revert-function to convert base64 string into hexl buffer
- write-contents-functions function for converting back into base64 and
sending to debug adapter

It would be preferable if nhexl-mode had some built in way of setting
the offset.

/Daniel Pettersson

Re: [elpa] externals/dape bd1c30d52e 1/5: Fix out of hexl region error

[Stefan Monnier]

> I am not sure if it makes sense to drop hexl support (if not nhexl is
> moved into core) but I am all for adding some custom's for swapping out
> hexl-mode for nhexl-mode if that is what the user wants.

[ I'll let you decide how that should work.  ]

> Currently the dape-read-memory installs:
> - variable for address offset
> - revert-function to convert base64 string into hexl buffer
> - write-contents-functions function for converting back into base64 and
> sending to debug adapter

Sounds like these would also be needed for nhexl, tho probably
with the details being different.

> It would be preferable if nhexl-mode had some built in way of setting
> the offset.

Yes, I'd be happy to change nhexl mode to better support Dape.
Should I expect a patch from you?


        Stefan