From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sascha Wilde Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Patch: Show signature state in encrypted messages using pgg Date: Sun, 12 Nov 2006 12:05:19 +0100 Message-ID: References: <59350f81-0e9a-4619-b46c-6e8bd1562c6d@well-done.deisui.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1163329548 32741 80.91.229.2 (12 Nov 2006 11:05:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 12 Nov 2006 11:05:48 +0000 (UTC) Cc: ding , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 12 12:05:46 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GjD9i-00061q-Il for ged-emacs-devel@m.gmane.org; Sun, 12 Nov 2006 12:05:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GjD9i-0000fZ-3h for ged-emacs-devel@m.gmane.org; Sun, 12 Nov 2006 06:05:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GjD9V-0000fU-Eb for emacs-devel@gnu.org; Sun, 12 Nov 2006 06:05:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GjD9T-0000fF-Re for emacs-devel@gnu.org; Sun, 12 Nov 2006 06:05:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GjD9T-0000fC-Mp for emacs-devel@gnu.org; Sun, 12 Nov 2006 06:05:27 -0500 Original-Received: from [62.141.58.119] (helo=km1136.keymachine.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GjD9T-00010l-4s for emacs-devel@gnu.org; Sun, 12 Nov 2006 06:05:27 -0500 Original-Received: from kenny.sha-bang.de (xdslcy055.osnanet.de [89.166.152.55]) (authenticated bits=0) by km1136.keymachine.de (8.12.11.20060308/8.12.10) with ESMTP id kACB5K4b011916; Sun, 12 Nov 2006 12:05:21 +0100 Original-Received: from wilde by kenny.sha-bang.de with local (Kenny MUA v.0409034.42) ID 1GjD9L-0002MT-SY; Sun, 12 Nov 2006 12:05:19 +0100 Original-To: Daiki Ueno In-Reply-To: <59350f81-0e9a-4619-b46c-6e8bd1562c6d@well-done.deisui.org> (Daiki Ueno's message of "Sun\, 12 Nov 2006 09\:28\:23 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.90 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62104 gmane.emacs.gnus.general:63966 Archived-At: Daiki Ueno wrote: >>>>>> In >>>>>> Sascha Wilde wrote: >> Daiki Ueno wrote: >> > Is there still any chance for such a feature enhancement to get into the >> > release? Anyway, > >> No, I don't think so, but I think that: >> 1. There is a chance to get it into gnus CVS > > If so, you should make a patch to the Gnus trunk, I think. This might me right. I tend to make my changes in the sources of CVS Emacs as that's what I'm using as my productive working environment. I'll port my changes to CVS gnus if that helps. > You are appearantly missing that Gnus set > application/x-gnus-pgp-encrypted for traditional inline PGP messages. I > agree these messages are "quite non standard". Yes, I missed that indeed. Thanks for pointing it out to me, now I know how to test it and indeed with my proposed change to mm-uu-pgp-encrypted-extract-1 it works well. >> Anyway how about something along the lines of > >> ;;; untested: >> (progn >> (mml2015-clean-buffer) >> (funcall (mml2015-clear-decrypt-function)) >> (eq t >> (compare-strings "OK" nil nil >> (mm-handle-multipart-ctl-parameter mm-security-handle >> 'gnus-info) >> nil 2))) > >> this should fix it. > > At least XEmacs 21.4 does not have compare-strings. Sure? (version) "GNU Emacs 21.4.1 (i386-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2005-03-17 on trouble, modified by Debian" (compare-strings "OK" nil nil "OK, Signer" nil 2) t On the other hand: is backwards compatibility still an issue for gnus development anyway, with Emacs 22 being released soon? > BTW, why do you tend to spread your kludge here and there? Why not > use some other parameters such as 'gnus-details instead? 'gnus-details contains the important information already, but 1. The information on the signature (if any) is buried between many lines of verbose information. 2. The information in 'gnus-details is not visible by default, the user has to show it by pressing the [[PGP Encrypted Part:OK]] button. The reason for my patch is, that I think, that the Information if and by whom an encrypted message is signed is _very_ important, and should be always visible. Btw: mml2015-mailcrypt-decrypt does return the same as mml2015-pgg-decrypt does with my patch (and I used it as an example for the exact format of the returned string). cheers sascha -- Sascha Wilde "Gimme about 10 seconds to think for a minute..."