From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Moore Newsgroups: gmane.emacs.pretest.bugs,gmane.emacs.devel Subject: Re: Directory name completion blocks when it shouldn't Date: Tue, 19 Dec 2006 21:16:39 +0100 Message-ID: References: <871wng3yyw.fsf@leeloo.anubex.internal> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1166559469 30527 80.91.229.10 (19 Dec 2006 20:17:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2006 20:17:49 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, ihs_4664@yahoo.com, emacs-devel@gnu.org Original-X-From: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Tue Dec 19 21:17:46 2006 Return-path: Envelope-to: gebp-emacs-pretest-bug@gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GwlPA-00066Y-6v for gebp-emacs-pretest-bug@gmane.org; Tue, 19 Dec 2006 21:17:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GwlP9-00022B-ET for gebp-emacs-pretest-bug@gmane.org; Tue, 19 Dec 2006 15:17:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GwlOK-0001Eb-W0 for emacs-pretest-bug@gnu.org; Tue, 19 Dec 2006 15:16:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GwlOK-0001D6-4C for emacs-pretest-bug@gnu.org; Tue, 19 Dec 2006 15:16:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GwlOJ-0001Cm-R8 for emacs-pretest-bug@gnu.org; Tue, 19 Dec 2006 15:16:47 -0500 Original-Received: from [66.249.92.173] (helo=ug-out-1314.google.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GwlOI-0006oc-Mf for emacs-pretest-bug@gnu.org; Tue, 19 Dec 2006 15:16:47 -0500 Original-Received: by ug-out-1314.google.com with SMTP id j3so2280740ugf for ; Tue, 19 Dec 2006 12:16:45 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:to:cc:subject:references:from:date:in-reply-to:message-id:user-agent:mime-version:content-type:sender; b=UH5Pt4J9h1PWioDVms4mL+l79tLrkVlBxNRRga14GrQ0hrcND932jE9pRq6lwJw1N4GedA7OSbgVl70TX9NkW0otnBFcqKuNQr2tNLEDsTv6WNjZ9cjTD95oWHUb2X232TU9X+GFh6g+Bas0kJ5hhApcRhtttL1KGK5jQiWC0Hs= Original-Received: by 10.67.26.7 with SMTP id d7mr7714205ugj.1166559404960; Tue, 19 Dec 2006 12:16:44 -0800 (PST) Original-Received: from chrislap.local ( [89.176.28.156]) by mx.google.com with ESMTP id 29sm9672662uga.2006.12.19.12.16.42; Tue, 19 Dec 2006 12:16:42 -0800 (PST) Original-Received: from localhost.localdomain ([127.0.0.1] helo=chrislap.local) by chrislap.local with esmtp (Exim 4.63) (envelope-from ) id 1GwlOC-0008O5-7S; Tue, 19 Dec 2006 21:16:40 +0100 Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sun\, 17 Dec 2006 20\:12\:25 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-BeenThere: emacs-pretest-bug@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for CVS Emacs." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Errors-To: emacs-pretest-bug-bounces+gebp-emacs-pretest-bug=gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.pretest.bugs:15926 gmane.emacs.devel:63960 Archived-At: Richard Stallman writes: > Is it feasible to fix read-file-name to obey the predicate > in the completion case? It could be that the reason it doesn't > do so was the difficulty of implementing that case efficiently. > > Since no one else seemed interested in this, I did it. I think you've introduced a new bug - lisp/net/ange-ftp.el.gz line 3980: (defun ange-ftp-file-name-completion (file dir) is being called like: (ange-ftp-file-name-completion "" "/a:/" 'file-exists-p) and lisp/net/tramp.el.gz line 2859: (defun tramp-handle-file-name-completion (filename directory) is being called like: (tramp-handle-file-name-completion "" "/a:/" 'file-exists-p) in both cases the functions expect 2 arguments, and they're being passed 3. I reported this earlier today: Message-Id: To: emacs-pretest-bug@gnu.org Subject: TRAMP: error when completing filename without realising that this was related to the recent "Directory name completion blocks when it shouldn't" fix.