Re: Pathnames with two (or more) slashes in Makefile.c

[Sascha Wilde <wilde@sha-bang.de>]

[-- Attachment #1: Type: text/plain, Size: 879 bytes --]

Jan Djärv <jan.h.d@swipnet.se> wrote:

> Sascha Wilde skrev:
>> Jan Djärv <jan.h.d@swipnet.se> wrote:
[...]
>> So the problem is, that the double slash is written unquoted to
>> Makefile.c where it gets interpreted as a comment.
>>
>> This is IMO a bug.
>>
>> When generating Makefile.c consecutive slashes hould either be reduced
>> to one or appropriately quoted.
>
> Actually it was a bug in my patch, I should not use #define if a
> double slash may be present.  I briefly checked the other #define:s in
> Makefile.in and mostly the valuse comes from s/*.h or m/*.h, so we
> have control over these.
>
> I've checked in a fix, please try it.

Sorry, maybe I'm seriously missing something here, but I can't see
such a change by you, neither in CVS nor in the ChangeLog.

And, build still fails...  :-(

FWIW: my workaround for now looks like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: emacs-configure-hotfix.patch --]
[-- Type: text/x-patch, Size: 658 bytes --]

--- a/configure.in
+++ b/configure.in
@@ -3256,6 +3256,7 @@
       < Makefile.c > junk1.c
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+      -e 's,\(#.*\)//\+,\1/,g' \
       < Makefile.c > junk.c
   $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c
@@ -3272,6 +3273,7 @@
       < Makefile.c > junk1.c
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+      -e 's,\(#.*\)//\+,\1/,g' \
       < Makefile.c > junk.c
   $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]


cheers
sascha
-- 
Sascha Wilde   -.-. ..- .-. .. --- ... .. - -.-- 
               -.- .. .-.. .-.. . -.. 
               - .... .
               -.-. .- -

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel