From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: A cleaning-up patch for parse-time.el Date: Sat, 19 Mar 2016 00:41:28 -0700 Message-ID: References: <87a8lveya2.fsf@mbork.pl> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458373345 24270 80.91.229.3 (19 Mar 2016 07:42:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Mar 2016 07:42:25 +0000 (UTC) Cc: Emacs Developers To: Marcin Borkowski Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 19 08:42:18 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahBWb-0002vt-SB for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2016 08:42:18 +0100 Original-Received: from localhost ([::1]:47808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahBWX-0005Di-Vv for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2016 03:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahBWJ-0005DJ-Nk for emacs-devel@gnu.org; Sat, 19 Mar 2016 03:42:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahBWG-0008Qm-Hm for emacs-devel@gnu.org; Sat, 19 Mar 2016 03:41:59 -0400 Original-Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:34963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahBWG-0008Qc-AR for emacs-devel@gnu.org; Sat, 19 Mar 2016 03:41:56 -0400 Original-Received: by mail-pf0-x22a.google.com with SMTP id n5so197871052pfn.2 for ; Sat, 19 Mar 2016 00:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mail-followup-to:mime-version; bh=40n7OkCqJBNVSsfhPoOaV0pWsuL/1XvZ2T13WLmRa9k=; b=gReRaKL1RZCDA4OHhj9HbT2kCY8D/2yT0MPDVs4xC0080r6nJGpyt5FMhXx+8mG+n8 zWN4rVeRRrLn/PInVuNrvoy7d8tqX29F/YsggnF8dZ9y10wk2xdXrWKwktH1+mS59FcD wV+ldL3uJ65HyUQ7CbGiudsGtt5buIWlm00u5OJhOiUzlnsW+nz+HhhgILCrQLNE3riy lAMYwx3XUk2WkGc07mOxGEpeOUG7KP66KZ/trQBUKskvidUh1KWMbrtdbx35TJ2xGw0k w7AIwXw2io80w2BlC96iutoTSyDLKkFZMEoaylrddvf+eXsfme3Roj6twqt3q+c+U7Bt 6ccw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mail-followup-to:mime-version; bh=40n7OkCqJBNVSsfhPoOaV0pWsuL/1XvZ2T13WLmRa9k=; b=PkJY2G9k7654EtzD/gJAv164oZ+nctUe5z5Y2gWJdbBH8daNGnfY7sYSRMpMAFHqGY uyyxUOGssIXF1c5VNY4f0udzRG6xnxftN2uw1IOaBlaeY8BOgdNfGP1ZR2OPo+nvX3YO dfBd1KdriigYdQhFfvcLoVKIAFHWdci7aHiFjoRywMdUeZxjvO8JiF4K7YFjE5jZUUVo XhCcCHcdnNFdqH3njbFYBe+1sC2EK69vbzY2IdReMbbjzY6ZAyOMz92KO5Dk1IFLZoDP ZrnXklz1w7aGKHHPRfFYuFvp8LAqasBwEg9zYqOzzVXK9YZY8t6fqNGGJC/lfe6pQ/kA Nmrg== X-Gm-Message-State: AD7BkJIQN6HDpwajPUXqQvlex6VmHsNgHcY1i2IUBeOITpdypAE6NzCxs/lGadKLQWRaqg== X-Received: by 10.98.8.14 with SMTP id c14mr29411590pfd.42.1458373315075; Sat, 19 Mar 2016 00:41:55 -0700 (PDT) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id y7sm19789045pfa.82.2016.03.19.00.41.54 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 19 Mar 2016 00:41:54 -0700 (PDT) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id ADA9A138AA65F; Sat, 19 Mar 2016 00:41:53 -0700 (PDT) In-Reply-To: <87a8lveya2.fsf@mbork.pl> (Marcin Borkowski's message of "Sat, 19 Mar 2016 08:12:53 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.92 (darwin) Mail-Followup-To: Marcin Borkowski , Emacs Developers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201853 Archived-At: >>>>> Marcin Borkowski writes: > in my attempt to enhance Org-mode's date/time parsing, I found out that > I'll probably need to submit some modifications to `parse-time-string'. > While studying parse-time.el, I encountered some code whose purpose was > not obvious at the first glance, so I corrected it. I attach a patch. > Is submitting such a patch a good idea? (It does not introduce any new > features or bugfixes, just cleaning up: adding/expanding docstrings, > making one argument name better, adding a newline, and changing `not' > into `null'.) How do I write a commit message for that? (I went for > simplicity/terseness, since the diff speaks for itself.) Hi Marcin, If you also include tests that show that the behavior is unchanged or merely corrected from what we had before, then this sounds like something that would be good for emacs-25. Otherwise, I'd suggest it be a patch against master, pending review by others. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2