From: Keith David Bershatsky <esq@lawlist.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Problems with move_it_in_display_line_to X when tabs exist.
Date: Wed, 06 Dec 2017 08:24:17 -0800 [thread overview]
Message-ID: <m2o9nbomdq.wl%esq@lawlist.com> (raw)
I wanted to give you an update on my efforts. I was unable to isolate different results due to the platform upon which Emacs was built/run. I did, however, track down a few areas in Emacs 26 where it->pixel_width is being set incorrectly when I am running my custom code. When the continuation_lines_width is incorrect, the code in the vicinity of line 28212 sets an erroneous it.pixel_width. Inasmuch as I am moving along the length of the current line by it.pixel_width, the X and/or HPOS coordinates get skewed. I tried manually setting continuation_lines_width to 0 at both locations mentioned below, and it.pixel_width gets reported correctly. However, this solution is not ideal because the STRETCH does not shrink and expand as it would normally do as things change in the buffer; e.g.,
adding/removing the right vertical scroll-bar affects whether the STRETCH would normally be either 1 or 2 columns wide. I feel as though I am zeroing-in on the underlying issue, but more work is ne
eded in the coming days/weeks as time permits:
xdisp.c:9563
it->continuation_lines_width += it->current_x;
xdisp.c:21671
it->continuation_lines_width += x;
xdisp.c:28212
it->pixel_width = next_tab_x - x0;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
DATE: [12-04-2017 08:26:04] <04 Dec 2017 18:26:04 +0200>
FROM: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Sun, 03 Dec 2017 19:01:47 -0800
> > From: Keith David Bershatsky <esq@lawlist.com>
> > Cc: emacs-devel@gnu.org
> >
> > I built Emacs 26 for Windows (using my modification patch) and ran the same series of tests along with taking a screen-shot at the link below. it.pixel_width is correct on Emacs 26 for Windows, whereas it.pixel_width is wrong on Emacs 26 for OSX 10.6.8.
>
> I'm surprised you see a difference. This code is supposed to be
> platform independent. So I guess you need to examine all the places
> in xdisp.c which are "#ifded NS" or "#ifndef NS".
>
> * * *
next reply other threads:[~2017-12-06 16:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 16:24 Keith David Bershatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-23 7:38 Problems with move_it_in_display_line_to X when tabs exist Keith David Bershatsky
2018-01-21 20:32 Keith David Bershatsky
2018-01-16 17:53 Keith David Bershatsky
2018-01-16 4:41 Keith David Bershatsky
2018-01-16 17:00 ` Eli Zaretskii
2018-01-15 5:48 Keith David Bershatsky
2018-01-15 12:06 ` Eli Zaretskii
2017-12-04 8:03 Keith David Bershatsky
2017-12-04 3:01 Keith David Bershatsky
2017-12-04 16:26 ` Eli Zaretskii
2017-12-03 20:56 Keith David Bershatsky
2017-12-04 15:48 ` Eli Zaretskii
2017-12-03 3:38 Keith David Bershatsky
2017-12-03 14:29 ` Eli Zaretskii
2017-12-02 22:28 Keith David Bershatsky
2017-12-03 3:32 ` Eli Zaretskii
2017-12-02 19:52 Keith David Bershatsky
2017-12-02 21:14 ` Eli Zaretskii
2017-11-30 4:29 Keith David Bershatsky
2017-11-29 6:12 Keith David Bershatsky
2017-11-29 18:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o9nbomdq.wl%esq@lawlist.com \
--to=esq@lawlist.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).