From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Re: master build broken [macOS] Date: Mon, 03 Dec 2018 17:14:01 +0300 Message-ID: References: <83k1kqaiyd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1543846480 31556 195.159.176.226 (3 Dec 2018 14:14:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2018 14:14:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 03 15:14:36 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTozW-00080X-LQ for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2018 15:14:31 +0100 Original-Received: from localhost ([::1]:49640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTp1c-0002nx-Ve for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2018 09:16:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTozP-00028p-JY for emacs-devel@gnu.org; Mon, 03 Dec 2018 09:14:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTozL-0004po-V7 for emacs-devel@gnu.org; Mon, 03 Dec 2018 09:14:23 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45483) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gToz8-0004fv-5U; Mon, 03 Dec 2018 09:14:08 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6FF3422252; Mon, 3 Dec 2018 09:14:04 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 03 Dec 2018 09:14:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=rMhuyIyoTavrE3uFDWjfN+HXoP Fr2Ya+sLXw3pqlKko=; b=eVe7dBPU0MC0qp4FrTdgBVJY736/+76eP+dbxz0Z8n StSi1Ds5YhPEhCQfCIaN9BDWuDs0TksjY6Q9nGZqcDFJaDLz5pxIHK+bR6y717QG ilw/z4DEEpvnzKnw1naFSFPFspsPR3O7DsVpCMH8LpIi2Hbmnvequ62cqjw95HVZ O+ngp/EEM+uqWUoHLYgshMbRNpSzJJsm7szGWJ2iNakXCZQGmoJ06sLdj7S5z69E xzYboFWxnc6Oh7jnp1nhdr2Ai0xmufmMShl8paXW1Z+tbkWIWywvAvcTYp9iim8O yIBWRDCL4xYh2xNhGU5BWNUeFiSLJB52qTTSz+LnJw4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=rMhuyI yoTavrE3uFDWjfN+HXoPFr2Ya+sLXw3pqlKko=; b=WS7QebXeyUzz0tZJM1Nohv O1o7ddD+uftKRnQPlg6I+lVotVxQ9noLrv5zJTnhAOQd9IiGKL8Qt+W99N2sryP4 LXgOYXzra/hNQzEfBUFuZZevRbPa2PdihgE+NvdPu6MWPhGfLb4VyD8DlcA2u1p/ NjV5hicbA68ZHJ096tYOctqmyEe8ztH+AIaSg/wdAlxHN3VRLONy8TgdzSbmzOvY MWt4MIgMt5pzAtx+BQbuxc3xIQdPA7biSxAvMAMrKNyVjhTrpBGo+qoF0p/UirYd JQ+CtMc9G9iSX4QcsDOXTQNx0kxaH+PKpgzDfVN6wScZPp/XJb5jz3Xv9jVbuFdw == X-ME-Sender: X-ME-Proxy: Original-Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 6B615E462B; Mon, 3 Dec 2018 09:14:03 -0500 (EST) In-Reply-To: <83k1kqaiyd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Dec 2018 14:33:14 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231603 Archived-At: On 03/12/2018 14:33 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Date: Mon, 03 Dec 2018 14:47:31 +0300 >> >> CCLD emacsclient >> emacsclient.c:1426:58: error: use of undeclared identifier 'SOCK_CLOEXEC' >> HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0); >> ^ >> 1 error generated. > > Does the below fix the problem? > > diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c > index c430217..7de3665 100644 > --- a/lib-src/emacsclient.c > +++ b/lib-src/emacsclient.c > @@ -1423,7 +1423,7 @@ set_local_socket (char const *server_name) > > if (sock_status == 0) > { > - HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0); > + HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM, 0); > if (s < 0) > { > message (true, "%s: socket: %s\n", progname, strerror (errno)); Yes, it does, thanks.