From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master build broken [macOS]
Date: Mon, 03 Dec 2018 17:14:01 +0300 [thread overview]
Message-ID: <m2o9a2k89i.fsf@fgunbin.playteam.ru> (raw)
In-Reply-To: <83k1kqaiyd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Dec 2018 14:33:14 +0200")
On 03/12/2018 14:33 +0200, Eli Zaretskii wrote:
>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Mon, 03 Dec 2018 14:47:31 +0300
>>
>> CCLD emacsclient
>> emacsclient.c:1426:58: error: use of undeclared identifier 'SOCK_CLOEXEC'
>> HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
>> ^
>> 1 error generated.
>
> Does the below fix the problem?
>
> diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
> index c430217..7de3665 100644
> --- a/lib-src/emacsclient.c
> +++ b/lib-src/emacsclient.c
> @@ -1423,7 +1423,7 @@ set_local_socket (char const *server_name)
>
> if (sock_status == 0)
> {
> - HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
> + HSOCKET s = cloexec_socket (AF_UNIX, SOCK_STREAM, 0);
> if (s < 0)
> {
> message (true, "%s: socket: %s\n", progname, strerror (errno));
Yes, it does, thanks.
next prev parent reply other threads:[~2018-12-03 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 11:47 master build broken [macOS] Filipp Gunbin
2018-12-03 12:33 ` Eli Zaretskii
2018-12-03 14:14 ` Filipp Gunbin [this message]
2018-12-03 16:27 ` Paul Eggert
2018-12-03 17:57 ` Eli Zaretskii
2018-12-03 18:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o9a2k89i.fsf@fgunbin.playteam.ru \
--to=fgunbin@fastmail.fm \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).