From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition Date: Wed, 12 Aug 2020 18:19:51 +0200 Message-ID: References: <837dvurtnn.fsf@gnu.org> <83v9hpngaz.fsf@gnu.org> <83imdondsl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8393"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mikeh@muppetlabs.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 12 18:20:33 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5tUO-00025B-H6 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 18:20:32 +0200 Original-Received: from localhost ([::1]:52550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5tUN-0002lQ-Jm for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Aug 2020 12:20:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5tTq-0002Gu-58 for emacs-devel@gnu.org; Wed, 12 Aug 2020 12:19:58 -0400 Original-Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:51880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5tTn-00011N-UW; Wed, 12 Aug 2020 12:19:57 -0400 Original-Received: by mail-wm1-x334.google.com with SMTP id p14so2299944wmg.1; Wed, 12 Aug 2020 09:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=2SV+arymDYCPDmEmtt5KCLkn5uDNAnmbj7Jtu6jndDY=; b=OOtYQk5FqpNBejNW8NEejoVyyLOU5FDI5h7OhbYiFdo23e+4/VgkOYHLbRRW6wSY/3 GakLcrs6SYhGImzaPvJHehlgFtA/ztHoX493q9zJ8mDQouCmXj3GeKjEysRPyBuxW/f4 XVG1VAhvjQzA3h1KEvAYBT43VmsPVRULakY8BxCVRzwZTLdDY+WQwd75n+RV6prKlNjP eNdb5Pd2mssH+PabjYYN+hpiRwnhn1u33nFa+077wVpBu+8U8nxQcIzqZ2zzIpQP+mEP 9vcW1YnOUeWlUKQrFw14tc5FboU8vUVZItdzwoIBuywvdWcF3T+6POOn9s6NzFFtPxab rtAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=2SV+arymDYCPDmEmtt5KCLkn5uDNAnmbj7Jtu6jndDY=; b=Y/H3v+M9HnFWG+V0zNj92Bi2Izgqhi1FwdA56bIRBDiroftaI8kheRad6KbYArtR9Y qELUlyFM1sZq/6HOtVWU03MFakIjiefVvlihnzt5va03J7PYRKviY01Jitf7WGjOqVGk 2KYb2WJTh06ZnALwxIu8iKj1qr9U2leJd1Hh3jOleViBPuYRJuOQL2ZVBtBnaWdjfnqR 2Jysh5/J+x92DEwf+4RyJuvK7aFbpU5HXmfMADH1W5GXuG7QBt5isBuoip0c2E2GeQ63 B+mQ1nNCtpTCQpTt4uFVWyvLghUKDd8+s4KiSNAE7caaouqmIExChBSBwkqnT/xnfTS1 5hAA== X-Gm-Message-State: AOAM530D5QX6bKNMVCBcb+bubHv3X+WUAsjs+k8h9E1Lf5MrwfskF7q7 bZ6crwrLMA8pjqposptyJ/PtPCH4 X-Google-Smtp-Source: ABdhPJyU7m559cKXH16FDbgkSLoooXBZr/Se9owa+uAPVq59G3HFqYfxMHvmA8TVEwfnipicLTPwew== X-Received: by 2002:a1c:38b:: with SMTP id 133mr402464wmd.153.1597249193294; Wed, 12 Aug 2020 09:19:53 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:54e2:ceb7:cd47:c47b]) by smtp.gmail.com with ESMTPSA id j5sm4836289wmb.15.2020.08.12.09.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 09:19:52 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <83imdondsl.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Aug 2020 17:23:38 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=rpluim@gmail.com; helo=mail-wm1-x334.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253697 Archived-At: >>>>> On Wed, 12 Aug 2020 17:23:38 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Mike Hamrick , emacs-devel@gnu.org >> Date: Wed, 12 Aug 2020 11:36:29 +0200 >>=20 >> >>>>> On Tue, 11 Aug 2020 22:17:08 +0300, Eli Zaretskii said: >>=20 Eli> Please use our style of indentation in C source files (basically, = make Eli> sure indent-tabs-mode is non-nil). >>=20 >> That is not reflected in our .dir-locals.el for C files (for elisp it >> sets indent-tabs-mode to nil) Eli> Because it's the default, I believe. Also because we couldn't agr= ee Eli> on a mandatory setting at the time this setting in .dir-locals.el = was Eli> discussed. The same is true for tab-width, sentence-end-double-space and fill-column, yet we set those. >> I thought it was 'you can use tabs or spaces, but try match the usage >> of existing code when making changes' (which since I=CA=BCm pro-spac= e means >> that when making additions or when the lines I=CA=BCm changing have = a mix, >> I use spaces). Eli> That would also indicate that the change in question should have u= sed Eli> mixed TABs and SPACEs. I was unclear: I meant if there was a mix of lines with TAB + SPACEs and lines with SPACEs only, I tend to normalize towards SPACEs. It=CA=BCs a constant battle between "try to match the surrounding style" and "my indentation prejudices are *right*, dammit" :-) Anyway, I have no wish to reignite a TABs vs SPACEs discussion. Perhaps I=CA=BCll just stick to elisp, where SPACEs rule. Robert