From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: "modern" colors Re: Changes for emacs 28 Date: Tue, 15 Sep 2020 09:40:11 +0200 Message-ID: References: <20200910102000.2t6tsju745xutg7u@Ergus> <20200911134225.zhnlq7cdhmu2iraj@Ergus> <20200911221435.go7b5kz2zcvxp2ft@Ergus> <20200912153723.ymnq3i5pugqf7lsy@Ergus> <871rj628mq.fsf@elephly.net> <20200912195358.3zjct7gsogjtlh3n@Ergus> <87y2lezrbp.fsf@elephly.net> <83pn6pbtni.fsf@gnu.org> <87mu1tzlxo.fsf@elephly.net> <83mu1tbp7a.fsf@gnu.org> <87h7s1zccb.fsf@elephly.net> <878sddz72o.fsf@elephly.net> <837dswbept.fsf@gnu.org> <87r1r4xq74.fsf@elephly.net> <83imcg9shm.fsf@gnu.org> <87a6xsxhry.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39013"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, spacibba@aol.com, emacs-devel@gnu.org, Ricardo Wurmus , ams@gnu.org, ghe@sdf.org, Eli Zaretskii , tecosaur@gmail.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 15 09:43:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kI5cd-0009zf-9T for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 09:43:27 +0200 Original-Received: from localhost ([::1]:48326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kI5cc-0002bN-Bg for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 03:43:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kI5Za-0000Zl-G1 for emacs-devel@gnu.org; Tue, 15 Sep 2020 03:40:18 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:32789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kI5ZY-0005t4-Kq; Tue, 15 Sep 2020 03:40:18 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id e11so10463820wme.0; Tue, 15 Sep 2020 00:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=JOd4ntbJmY4va5lKV8I/4Wc/ugA4gyWEjNfndSHLAH8=; b=TMfhFI3e8SoMjXwlPD8vQ1hjDRTAMyVjVMIx0fSxkuINWbj13nx+3ljARqP9uCREdm p0/fTYiRPZiw71eUsjhHpstWx5zsZZX9LW2lGRmBa/EJCGhPe2yVPp3niDlwyTNzUMoT XSjm+DMFdBdYG1TAlgK6FFSJ8Cx6xT8PXsM+aCADp8OZ2qWVtr0xQQCoLnhKvedQAclg c+uePKpB4sXPPSjEOOZeXV2XF8uKsouwD2cn+4CJaIgdqH/WYNVF4bBMJ33rEZj+3ef8 Wrbhcw8ifRR9Cgn2JLehI79SliGjyFXe5H5Y5txhRXWLTdPA/IbcZs23fTPn5Uuqh7Pu COCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=JOd4ntbJmY4va5lKV8I/4Wc/ugA4gyWEjNfndSHLAH8=; b=scohFiT423s6btA2DvQ8ljh3EuCpQsn1EqJ8Wg6OW4EpVXB8HELSt2toN0EEA0CDT0 zwr1m+MPKa53525aXDLxmBtCu2XHEJdJC9apgCjy3wbEr0fA4NtOcPQLdn9tM2q8NL2E fhKda/M3uKHJKRsL0y720mzcCHFzziygXQ/0gry7UgryqtkbTClRFA84pSPZYtgWPDWW iuni4bRboU84EuIElLZCnYUZsiIr49/BmUNFY1V2mOmpNIl5AnhrU1Iu+xWjOcjXiEUg 3BMRJlaqPrs+kuulUGIgexBORsXLCcY0ey+C8+TZ54s34eq3WnoUMOxZhAGXX8Xj/Qpp HJRw== X-Gm-Message-State: AOAM531odM4da2dklioh889DKqJOlE2yPGzKk0ziy8kS3RkTQg4fC7NN WaHmPHctYcVtVJORcIUVaSo= X-Google-Smtp-Source: ABdhPJyJYKpwvs18QZiGN7yiSouuzHzUvM1BvYcEgpZcEchXIa3FiInWKiZsh9cSEErpierVm9VfQA== X-Received: by 2002:a7b:c44b:: with SMTP id l11mr3187366wmi.52.1600155613973; Tue, 15 Sep 2020 00:40:13 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:1cb9:65e9:2391:c618]) by smtp.gmail.com with ESMTPSA id x10sm23663767wmi.37.2020.09.15.00.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 00:40:12 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: (Stefan Monnier's message of "Mon, 14 Sep 2020 16:20:19 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=rpluim@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255718 Archived-At: >>>>> On Mon, 14 Sep 2020 16:20:19 -0400, Stefan Monnier said: >> I don=E2=80=99t understand. There is a clear problem here in that t= he >> font-lock-comment-face is dark red and the region colour is whatever= the >> GTK theme says it should be. So unless font-lock-comment-face is al= so >> set according to the GTK theme=E2=80=99s colours there is no way to = avoid this >> unfortunate combination of colours (dark red on dark background) wit= hout >> customization. Stefan> Does Gtk offer some setting for the color of "comments"? Stefan> What do other applications do? >> FWIW neither the dark red colour nor the region background colour >> changes when I change frame-background-mode. Stefan> Maybe there's a bug here. The color of `font-lock-comment-face` Stefan> *should* change. If you can reproduce this, please provide a r= ecipe to Stefan> `report-emacs-bug`. The code says: Stefan> (defface font-lock-comment-face Stefan> '((((class grayscale) (background light)) Stefan> :foreground "DimGray" :weight bold :slant italic) Stefan> (((class grayscale) (background dark)) Stefan> :foreground "LightGray" :weight bold :slant italic) Stefan> (((class color) (min-colors 88) (background light)) Stefan> :foreground "Firebrick") Stefan> (((class color) (min-colors 88) (background dark)) Stefan> :foreground "chocolate1") Stefan> (((class color) (min-colors 16) (background light)) Stefan> :foreground "red") Stefan> (((class color) (min-colors 16) (background dark)) Stefan> :foreground "red1") Stefan> (((class color) (min-colors 8) (background light)) Stefan> :foreground "red") Stefan> (((class color) (min-colors 8) (background dark)) Stefan> :foreground "yellow") Stefan> (t :weight bold :slant italic)) Stefan> "Font Lock mode face used to highlight comments." Stefan> :group 'font-lock-faces) Stefan> So when in "dark background" mode, `font-lock-comment-face` sho= uld be Stefan> using `chocolate1` rather than `Firebrick`. The GTK theme may be in 'dark' mode, but (as discussed elsewhere in this thread), the default face does not respect the GTK theme background. Robert