From: Arash Esbati <arash@gnu.org>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name`
Date: Sat, 30 Mar 2024 12:19:23 +0100 [thread overview]
Message-ID: <m2o7aw3r2c.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <20240322014425.180EEC12C52@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Thu, 21 Mar 2024 21:44:24 -0400 (EDT)")
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> branch: master
> commit 60c9702972f3cef9e6dbbce5eaad8cc90ea7f8e8
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/help.el (help--analyze-key): Use `help-fns-function-name`
> ---
> lisp/help.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/help.el b/lisp/help.el
> index 4171d0c57c7..bafe6032942 100644
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -926,7 +926,9 @@ in the selected window."
> (let ((key-desc (help-key-description key untranslated)))
> (if (help--binding-undefined-p defn)
> (format "%s%s is undefined" key-desc mouse-msg)
> - (format "%s%s runs the command %S" key-desc mouse-msg defn)))
> + (format "%s%s runs the command %s" key-desc mouse-msg
> + (if (symbolp defn) (prin1-to-string defn)
> + (help-fns-function-name defn)))))
> defn event mouse-msg)))
>
> (defun help--filter-info-list (info-list i)
I think this change now produces:
In end of data:
help.el:931:21: Warning: the function ‘help-fns-function-name’ is not
known to be defined.
This is with Emacs 30 (87be53846b) on macOS.
Best, Arash
next parent reply other threads:[~2024-03-30 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171107186434.18812.2389706590800223024@vcs2.savannah.gnu.org>
[not found] ` <20240322014425.180EEC12C52@vcs2.savannah.gnu.org>
2024-03-30 11:19 ` Arash Esbati [this message]
2024-03-30 13:05 ` master 60c9702972f: * lisp/help.el (help--analyze-key): Use `help-fns-function-name` Eli Zaretskii
2024-03-30 15:45 ` Arash Esbati
2024-03-30 16:40 ` Eli Zaretskii
2024-03-31 2:55 ` Stefan Monnier
2024-03-31 14:28 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o7aw3r2c.fsf@macmutant.fritz.box \
--to=arash@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).