From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Tue, 02 Jul 2024 09:15:01 +0200 Message-ID: References: <2syUQ04IbTWqDJjMfKSrtzWMWmFGq1GIOwSxv_r6BEyNDtk7ADADKjZk-90g9tSS9SKWppkiq6_zihUtsoE1spiopaOI6-v9inQrGxwMyCs=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32624"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Helmut Eller , Emacs Devel To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 09:16:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOXk9-0008H9-V5 for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 09:16:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOXjM-0001NP-OS; Tue, 02 Jul 2024 03:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOXjK-0001N4-Na for emacs-devel@gnu.org; Tue, 02 Jul 2024 03:15:10 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sOXjI-0002F2-Mx; Tue, 02 Jul 2024 03:15:10 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-57cd26347d3so1484888a12.1; Tue, 02 Jul 2024 00:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719904503; x=1720509303; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qPDEug4UAcsb17ThqrgQvygk462FwUSNcKv/oOXa+7U=; b=fYqiy0FTvmXveYkyRafm5uPX0cCaPSiiQxztNuzMBTQ5XJg92L6Ee01WqIKdLZhYmj q28u8l+DmF80mDQekHtj7av0EnhF3Tc5ilbBCyJzm8gWtKkfvHBm/60QkVCr2GAPXg7w 0/wTc89jDDZzD/rjZEkY/iN/LHP6nGXyChZFCBWpQ/T3vItjhbmGo6pEzE6QKY3PwlGX BCkw8hrSLGdVqGJH5CqDxRNy0vk/E8AJWgbbf4ApdgqlYCLBkp6QHsxKYREoy406VJlW 1QfKmmWDV8AMQm44K6PlteeFbMBQj8dB6Hyhvy8rZw55TR5z2fu4y0cnhLgwUKGe3NT2 PswQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719904503; x=1720509303; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qPDEug4UAcsb17ThqrgQvygk462FwUSNcKv/oOXa+7U=; b=hIOumZRp82PRT1ppcv2aQegO1a/PC8JtWDqaC3pV89p8Pdtwp3skUp0iFL6Z5GikdE m2hjXYtwj78DG7d6Qb7LQNGKphyQFBot6l9oXN4IhbZLBIg/TznbABbXAJwD00uV/KaU oEgixgF/GmS/GXyC69sQr/eeFbZXc4ApzMGcq9jRn0cSlU/wvk/TRNpxyxViEKVegYsv 0MhkRXEtE5j5u7EgGxoceChMgXlEhQaYqhQbkurycdps5ji/8hwqonv0R8fGJfrjjzIc fB/T0oiQRdr4Ti4fwfucdsJJvTHkyR2y1mu9kaqTG3ciXdCmL76UZ7t7NXzn+UCyOEA2 KXUg== X-Forwarded-Encrypted: i=1; AJvYcCXFZb5zhkHA/yP7QpqwnjKKbHJOciQBNIc47tdHdTIOpPYfkqWYHnQu4qI+jx4fvgbMkSMi008ZZ1u+fR6HCiI7eNBy X-Gm-Message-State: AOJu0YzYKuhPV/zz6smV7DL1Vzjc/ZHP0xW9tMSy9TQ7GsQAMeuIGAmh j7GeI/9Rtn70HMEkjH3iCwVqNScRRiav/dDr8OxOwGQc0aD7nAyyiOraEg== X-Google-Smtp-Source: AGHT+IEVGKqWO5SVwUsRGBtSkdtWcWmZr1MPB+bIj0pX5LVwWrt0gLXigip6W6fSS0TbdghbHS6CLg== X-Received: by 2002:a17:907:1c15:b0:a72:5110:33ae with SMTP id a640c23a62f3a-a75144f5dd6mr645673866b.58.1719904502183; Tue, 02 Jul 2024 00:15:02 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36129.dip0.t-ipconnect.de. [217.227.97.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0651c0sm392316366b.123.2024.07.02.00.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 00:15:01 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Tue, 02 Jul 2024 08:57:07 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321105 Archived-At: Gerd M=C3=B6llmann writes: > Pip Cet writes: > >> Is it correct that all IGC objects need to be scannable when they're >> still zeroed-out from allocation? >> >> (I'm currently trying to simply delay setting the weak->strong and >> strong->weak pointers until the parts are initialized, and to turn the >> scan into a nop if they aren't. I'm not convinced that's sufficient to >> prevent the compiler from reordering the initialization so an invalid >> state becomes visible to the scan function, though...) > > I have here fixes for that (I think) that I'll transfer to GNU in a few > minutes. I think with that we're good. Please have a look. You made a change meanwhile that I think also works, so I added only 2 asserts for what I thought was missing.