unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* globals.h
@ 2011-01-26 19:02 Stefan Monnier
  2011-01-26 22:00 ` globals.h Tom Tromey
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2011-01-26 19:02 UTC (permalink / raw)
  To: emacs-devel

The new globals.h is inconvenient as it is: adding o removing a global
variable is kind of a pain.  Could someone change it so that globals.h
is auto-generated, based on macro calls in the C files like:

GLOBAL_VAR(Lisp_Object, Vfoo);

which would get expanded to nothing, but would tell the scripot about
the new Vfoo global var.


        Stefan



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: globals.h
  2011-01-26 19:02 globals.h Stefan Monnier
@ 2011-01-26 22:00 ` Tom Tromey
  2011-01-26 22:14   ` globals.h Andreas Schwab
  2011-01-27  3:53   ` globals.h Stefan Monnier
  0 siblings, 2 replies; 4+ messages in thread
From: Tom Tromey @ 2011-01-26 22:00 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

Stefan> The new globals.h is inconvenient as it is: adding o removing a global
Stefan> variable is kind of a pain.  Could someone change it so that globals.h
Stefan> is auto-generated, based on macro calls in the C files like:
Stefan> GLOBAL_VAR(Lisp_Object, Vfoo);
Stefan> which would get expanded to nothing, but would tell the scripot about
Stefan> the new Vfoo global var.

You don't even need a new macro, the script could just look for the
DEFVAR_{LISP,INT,BOOL} invocations.

Tom



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: globals.h
  2011-01-26 22:00 ` globals.h Tom Tromey
@ 2011-01-26 22:14   ` Andreas Schwab
  2011-01-27  3:53   ` globals.h Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2011-01-26 22:14 UTC (permalink / raw)
  To: Tom Tromey; +Cc: Stefan Monnier, emacs-devel

> You don't even need a new macro, the script could just look for the
> DEFVAR_{LISP,INT,BOOL} invocations.

We already have a tool that looks at them, it's called make-docfile.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: globals.h
  2011-01-26 22:00 ` globals.h Tom Tromey
  2011-01-26 22:14   ` globals.h Andreas Schwab
@ 2011-01-27  3:53   ` Stefan Monnier
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2011-01-27  3:53 UTC (permalink / raw)
  To: Tom Tromey; +Cc: emacs-devel

Stefan> The new globals.h is inconvenient as it is: adding o removing a global
Stefan> variable is kind of a pain.  Could someone change it so that globals.h
Stefan> is auto-generated, based on macro calls in the C files like:
Stefan> GLOBAL_VAR(Lisp_Object, Vfoo);
Stefan> which would get expanded to nothing, but would tell the scripot about
Stefan> the new Vfoo global var.

> You don't even need a new macro, the script could just look for the
> DEFVAR_{LISP,INT,BOOL} invocations.

Even better.  I just want to remove globals.h from the Bzr repository
and have it be auto-generated instead.


        Stefan


PS: At some point we may also try and improve the dependencies so that
adding/removing/changing one of the vars in globals.h doesn't cause all
files to be rebuilt.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-01-27  3:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-26 19:02 globals.h Stefan Monnier
2011-01-26 22:00 ` globals.h Tom Tromey
2011-01-26 22:14   ` globals.h Andreas Schwab
2011-01-27  3:53   ` globals.h Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).