From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Date: Sun, 25 Mar 2018 12:03:35 +0200 Message-ID: References: <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> <83woyiscns.fsf@gnu.org> <87po44jb7w.fsf@red-bean.com> <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> <83woyiscns.fsf@gnu.org> <87a7v2zb27.fsf@red-bean.com> <838tallwpg.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521971368 4196 195.159.176.226 (25 Mar 2018 09:49:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2018 09:49:28 +0000 (UTC) Cc: kfogel@red-bean.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 25 11:49:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f02HE-0000xE-2v for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2018 11:49:24 +0200 Original-Received: from localhost ([::1]:50578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f02JF-0005K5-Kh for ged-emacs-devel@m.gmane.org; Sun, 25 Mar 2018 05:51:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f02Ie-0005JW-5B for emacs-devel@gnu.org; Sun, 25 Mar 2018 05:50:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f02IZ-000760-6h for emacs-devel@gnu.org; Sun, 25 Mar 2018 05:50:52 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:40880) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f02IY-00075W-U1 for emacs-devel@gnu.org; Sun, 25 Mar 2018 05:50:47 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id D3133226E9 for ; Sun, 25 Mar 2018 09:51:39 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1521971498; x=1522835499; bh=AizHz9cR/hrLl GJCklJVOwBxQfC3o0rJoSTYU9nPYIA=; b=jEDWo4OLm2tRr3s8j+vY/jtXUVqO1 tk6yBesANCLncMOpakh7EDgYWbhncv1K8PdHeCoowtAf3IzO3w+fxM7jokXIOOW6 LmRIYMHDKtbSKgRSD/faXYShxwSYzYbfUsVzBJRsKWPHoYGlnQqWC+ExifaMkwfG QLGp8suU9nb414= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id I-6wMKRMDUfB for ; Sun, 25 Mar 2018 09:51:38 +0000 (UTC) Original-Received: from gray (202.100.1.85.dynamic.wline.res.cust.swisscom.ch [85.1.100.202]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 155A6226CD; Sun, 25 Mar 2018 09:51:37 +0000 (UTC) In-reply-to: <838tallwpg.fsf@gnu.org> (message from Eli Zaretskii on Wed, 21 Mar 2018 09:22:19 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 37.35.109.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223992 Archived-At: > Date: Wed, 21 Mar 2018 09:22:19 +0200 > From: Eli Zaretskii > > Here are some reasons why not to make the change: > > . there's nothing wrong with that code > . having it in C doesn't make hacking harder because one can always > override functions in Emacs, Good point. Is this written in the Elisp manual anywhere? I searched for "override functions" and "override primitives" in the index, but did not find a result. We could add a note saying that functions defined from C can be overridden from Lisp (possibly in (elisp) What Is a Function). > and moving the interactive spec to > Lisp will still leave the code preloaded anyway Instead of defining transpose-regions (and its interactive spec) in Lisp (as the reverted patch did), we could take the current interactive spec of transpose-regions and use that to make a preloaded function named "read-two-regions" in simple.el. That would allow its reuse by other commands, too.