From: charles@aurox.ch (Charles A. Roelli)
To: Eli Zaretskii <eliz@gnu.org>
Cc: kfogel@red-bean.com, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343)
Date: Sun, 25 Mar 2018 12:03:35 +0200 [thread overview]
Message-ID: <m2muywh3pk.fsf@aurox.ch> (raw)
In-Reply-To: <838tallwpg.fsf@gnu.org> (message from Eli Zaretskii on Wed, 21 Mar 2018 09:22:19 +0200)
> Date: Wed, 21 Mar 2018 09:22:19 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> Here are some reasons why not to make the change:
>
> . there's nothing wrong with that code
> . having it in C doesn't make hacking harder because one can always
> override functions in Emacs,
Good point. Is this written in the Elisp manual anywhere? I searched
for "override functions" and "override primitives" in the index, but
did not find a result. We could add a note saying that functions
defined from C can be overridden from Lisp (possibly in (elisp) What
Is a Function).
> and moving the interactive spec to
> Lisp will still leave the code preloaded anyway
Instead of defining transpose-regions (and its interactive spec) in
Lisp (as the reverted patch did), we could take the current
interactive spec of transpose-regions and use that to make a preloaded
function named "read-two-regions" in simple.el. That would allow its
reuse by other commands, too.
next prev parent reply other threads:[~2018-03-25 10:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180311105533.30002.78782@vcs0.savannah.gnu.org>
[not found] ` <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org>
2018-03-11 16:05 ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-11 17:23 ` Charles A. Roelli
2018-03-12 9:56 ` Leo Liu
2018-03-11 18:13 ` Eli Zaretskii
2018-03-15 20:20 ` Richard Copley
2018-03-16 15:23 ` Karl Fogel
2018-03-20 21:33 ` Karl Fogel
2018-03-20 21:46 ` Richard Copley
2018-03-21 7:22 ` Eli Zaretskii
2018-03-22 5:30 ` Karl Fogel
2018-03-22 7:12 ` Eli Zaretskii
2018-03-22 7:15 ` Unnecessarily moving stiff between files considered harmful (Was: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive) (Bug#30343) Eli Zaretskii
2018-03-23 18:03 ` Unnecessarily moving stiff between files considered harmful Karl Fogel
2018-03-22 13:39 ` [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Stefan Monnier
2018-03-23 18:05 ` Karl Fogel
2018-03-25 10:03 ` Charles A. Roelli [this message]
2018-03-25 15:41 ` Eli Zaretskii
2018-03-25 20:29 ` Charles A. Roelli
2018-03-26 15:59 ` Eli Zaretskii
2018-03-28 20:19 ` Juri Linkov
2018-03-29 4:53 ` Karl Fogel
2018-03-29 11:38 ` Eli Zaretskii
2018-03-29 12:17 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2muywh3pk.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).