From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" Newsgroups: gmane.emacs.devel Subject: Re: Adding olivetti to GNU ELPA Date: Tue, 21 May 2019 19:05:09 +1000 Message-ID: References: <83tvemzcn2.fsf@gnu.org> <9bb5fc63-61ae-44dc-a8d5-b67803eab1e5@www.fastmail.com> <83h8amz24g.fsf@gnu.org> <24cca761-36ea-4c16-bce1-e3651aad52c8@www.fastmail.com> <83ftq6yx5o.fsf@gnu.org> <83ftppii16.fsf@gnu.org> <875d1b0c-7f44-ba5d-4660-84637533b8f3@gmx.at> <90355909-e254-a616-a3a0-6d09d550a67d@gmx.at> <7c36ce3b-36fb-f9ab-9e8e-b198ab25d246@gmx.at> <4bbdf708-e7d0-4fbc-880d-308e1263b216@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214091"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 26.2 Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 21 11:06:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hT0j8-000tWl-Fl for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 11:06:31 +0200 Original-Received: from localhost ([127.0.0.1]:49831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT0j7-0001mJ-Cq for ged-emacs-devel@m.gmane.org; Tue, 21 May 2019 05:06:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT0iJ-0001lV-TY for emacs-devel@gnu.org; Tue, 21 May 2019 05:05:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT0iC-00020V-Ef for emacs-devel@gnu.org; Tue, 21 May 2019 05:05:38 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:32887) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hT0i3-0001kc-I8; Tue, 21 May 2019 05:05:23 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 362E256E; Tue, 21 May 2019 05:05:18 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 21 May 2019 05:05:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; s=fm3; bh=DKsLAwVHph8VinteiGI2uucLxT ZQZHNNMy5noi4cB8s=; b=BnHwjZjsoE2HfaxhAq+yObNIwpKubEn4eHfhW31u3d SchcYOvkL9mq8bVmpc4oPr0JrEAmT0+OCv0YmGi56EZ2qtEii1544EVOIP1I05z3 9ubHEgkrRFzsKhVkxBatySAf2xMP+Hwsl9hagmLL7TjoDRA2ifqQKfIVaQCzxU1U lNtIat9uVtXjm/iXvbnQr166cebs/rZqZ6nGw6uLzCHeauw/CGBpGYMyz63hR/20 eQ97+pFvlDlSApLTe9cUbn3UR5vkUAmO0xoW+qmMFY+xhK1gEBo7nODBm3fIp89I 9PT4/Bt4ejFyRn5pS3IQjtw/HMAldOKsYWXY4tRtcP+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DKsLAw VHph8VinteiGI2uucLxTZQZHNNMy5noi4cB8s=; b=XLW9fjG1HdzF5LGZ8nsQf/ PRh/k1jSZb5Zg/PiwOvileCa8Pq5OmF0h9VXKy1MdWQdKm6b0ybCYEgFOfqJ6EkV 2dthKfayIVeAtjZKqc9OE7IEnJL9tuR3TVrFcPCFmeKMmlLJHy+1mCbNAZB222rf eFU2l1sYkSl7Z8LRvLAUER4/zakNTd9SMBW3XtEnaNlTZA6ySZRHkKm1aPM5vr+6 bCA75Fw6sngrX1xfo06dwXnO/hg7KE0ca7jqv/1cu/NVOVD+tTyWkjaczYgmmIcx aAsIEhc1RsKRp++yUsM+71Wc1xKjW6M3hnFpoWpFycrLj0fLNWPJLnizk4wbczlg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddutddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufgjfffkgggtsehttdertddtredtnecuhfhrohhmpedfrfgruhhl ucghrdcutfgrnhhkihhnfdcuoehhvghllhhosehprghulhifrhgrnhhkihhnrdgtohhmqe enucffohhmrghinhepvghlrdhithenucfkphepuddvtddrvddvrddujeejrdduudenucfr rghrrghmpehmrghilhhfrhhomhephhgvlhhlohesphgruhhlfihrrghnkhhinhdrtghomh enucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Original-Received: from localhost (unknown [120.22.177.11]) by mail.messagingengine.com (Postfix) with ESMTPA id CB01E8005A; Tue, 21 May 2019 05:05:15 -0400 (EDT) In-reply-to: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236846 Archived-At: On Tue, May 21 2019, martin rudalics wrote: > I'm still too dense. Line 191 of what? It's line 191 of olivetti.el. It's in GNU ELPA on branch externals/olivetti. That's just the line with the function to reset the margins of a window if window-parameter split-window is olivetti-split-window. I think the main thing is how and when the window margin setting and resetting occurs. This is how olivetti now adds its hooks: (cond ((<= emacs-major-version 24) (add-hook 'window-configuration-change-hook #'olivetti-set-all-margins t t)) ((<= emacs-major-version 26) (add-hook 'window-configuration-change-hook #'olivetti-set-all-margins t t) (add-hook 'window-size-change-functions #'olivetti-set-margins t t)) ((<= 27 emacs-major-version) (add-hook 'window-size-change-functions #'olivetti-set-margins t t))) Which seems okay to me, but I'm a far cry from an authoritive voice.