From: "Paul W. Rankin" <hello@paulwrankin.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: Adding olivetti to GNU ELPA
Date: Tue, 21 May 2019 19:05:09 +1000 [thread overview]
Message-ID: <m2mujgmb3u.fsf@paulwrankin.com> (raw)
In-Reply-To: <a9f11510-c05f-73e6-45b9-053a26c0ee17@gmx.at>
On Tue, May 21 2019, martin rudalics wrote:
> I'm still too dense. Line 191 of what?
It's line 191 of olivetti.el. It's in GNU ELPA on branch
externals/olivetti.
That's just the line with the function to reset the margins of a
window if window-parameter split-window is olivetti-split-window.
I think the main thing is how and when the window margin setting
and resetting occurs. This is how olivetti now adds its hooks:
(cond ((<= emacs-major-version 24)
(add-hook 'window-configuration-change-hook
#'olivetti-set-all-margins t t))
((<= emacs-major-version 26)
(add-hook 'window-configuration-change-hook
#'olivetti-set-all-margins t t)
(add-hook 'window-size-change-functions
#'olivetti-set-margins t t))
((<= 27 emacs-major-version)
(add-hook 'window-size-change-functions
#'olivetti-set-margins t t)))
Which seems okay to me, but I'm a far cry from an authoritive
voice.
next prev parent reply other threads:[~2019-05-21 9:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 8:32 Adding olivetti to GNU ELPA Paul W. Rankin
2019-04-25 8:56 ` Eli Zaretskii
2019-04-25 12:32 ` Paul W. Rankin
2019-04-25 12:43 ` Eli Zaretskii
2019-04-25 13:01 ` Paul W. Rankin
2019-04-25 14:30 ` Eli Zaretskii
2019-05-08 4:07 ` Paul W. Rankin
2019-05-08 6:20 ` Eli Zaretskii
2019-05-09 6:54 ` Paul W. Rankin
2019-05-09 7:53 ` Eli Zaretskii
2019-05-09 8:14 ` martin rudalics
2019-05-09 13:30 ` Stefan Monnier
2019-05-10 8:00 ` martin rudalics
2019-05-14 5:16 ` Paul W. Rankin
2019-05-14 7:04 ` Paul W. Rankin
2019-05-14 12:22 ` Stefan Monnier
2019-05-15 8:26 ` Paul W. Rankin
2019-05-14 16:05 ` Joost Kremers
2019-05-14 16:50 ` Stefan Monnier
2019-05-14 21:56 ` Joost Kremers
2019-05-15 1:29 ` Stefan Monnier
2019-05-20 8:24 ` martin rudalics
2019-05-20 13:14 ` Paul W. Rankin
2019-05-21 7:32 ` martin rudalics
2019-05-21 7:38 ` Paul W. Rankin
2019-05-21 7:45 ` martin rudalics
2019-05-21 9:05 ` Paul W. Rankin [this message]
2019-05-21 10:04 ` martin rudalics
2019-05-22 1:47 ` Paul W. Rankin
2019-05-22 8:32 ` martin rudalics
2019-05-22 9:14 ` Paul W. Rankin
2019-05-08 14:07 ` Stefan Monnier
2019-05-08 15:45 ` Stephen Leake
2019-05-08 17:50 ` Eli Zaretskii
2019-04-26 1:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mujgmb3u.fsf@paulwrankin.com \
--to=hello@paulwrankin.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).