From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Thu, 12 Sep 2019 16:26:44 +0200 Message-ID: References: <83ftl85tbn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="217305"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Stefan Kangas , emacs-devel@gnu.org To: Jesse Medeiros Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 12 16:37:13 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8QDh-000uQC-5e for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2019 16:37:13 +0200 Original-Received: from localhost ([::1]:35294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8QDf-0007g3-S9 for ged-emacs-devel@m.gmane.org; Thu, 12 Sep 2019 10:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46784) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8Q3f-0006Eo-QU for emacs-devel@gnu.org; Thu, 12 Sep 2019 10:26:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8Q3e-0000xA-Rk for emacs-devel@gnu.org; Thu, 12 Sep 2019 10:26:51 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:37470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8Q3d-0000va-JG; Thu, 12 Sep 2019 10:26:50 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id r195so291078wme.2; Thu, 12 Sep 2019 07:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=Zn7tlV+GwhIoWXDF8uZ1AMtIaD97HpoIzhvfY6GimS8=; b=eEYQZRZnYZKAr5eKTnevfQ++XsszLOYnSoTYBxUQI9rrFG9fgB9EbWRFDMJgfD+TVL QkHqiXcDlhfWypNEQHK/SAkq5DBXitnil4Q/B+UWtCRRpXrs3HJnS+9QBGR9MkaLvxJK BUVCKQIAhkudP3F2cgrolNLCNomNqgFkmoSBIR1p4neHSE5PbyIpJ8IFVbtW+sG+S9mf QK5m//UsPKygH5+BrFZV7izFREu50PNszj8JaKufbPyGXiAVT2BiXsKS+vCmnOC3qqjq VgdB16kKU6nV14winxjLdy4hVZvtiKKL3nT8zYoob3MspnjNUDUXakj1PcitUkRTxE9g Parg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=Zn7tlV+GwhIoWXDF8uZ1AMtIaD97HpoIzhvfY6GimS8=; b=ScUxYZr5QA6yIB15VDby/S8uG+O4hIqCbTio8cnA2wkymTTzcgNcHvMAd1zRSK6Pig 989Ca3JE65WDctdKAclOSiMyqG7JLL6YIN97SHtUVHXNlEiyXGxMElBwSnkUdmkpM2ok nr+2nTsy4Em3xf2CxIPykDaoAwXly5D6Jm0DRwCtv1ql5OjqrcaFSmFbfLopBS3ALPnF MHPsA2dwd/Kddy2Zzidik2/PW8G+jO+J/8dPpA6HkSo4lVOcF057YbQhtHjZQq1cbWOo tpEQrBLFIE3CENe3B+AsYr9YM8AfpN6iqPFNsq9A8iYlIclG5koGXqxDH7yrYtpizL+A Vmsw== X-Gm-Message-State: APjAAAXRIK3N+Sua7roei5fDzgXikIo9LYz6acjcunpc0ZyRfsHDAU8D NUfL6W9uCrH3Fyk5rXQtX1TaULhe X-Google-Smtp-Source: APXvYqx7NXl21zWQYeDx2IXXYxhui8oQqXcL339XAcvncLp222HNHbD9fwmS5j7TcaZLjzHyj8EKPg== X-Received: by 2002:a1c:49d4:: with SMTP id w203mr239718wma.132.1568298406280; Thu, 12 Sep 2019 07:26:46 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id q14sm51118284wrc.77.2019.09.12.07.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 07:26:45 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Jesse Medeiros's message of "Thu, 12 Sep 2019 09:08:38 -0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239996 Archived-At: >>>>> On Thu, 12 Sep 2019 09:08:38 -0300, Jesse Medeiros said: >> Hmm, should this be customizable, like 'line-spacing' is? In any cas= e, >> I think the doc string of 'line-spacing' should refer to this new >> variable as well. Jesse> Yes, it's supposed to be customizable like line-spacing. Persona= lly I Jesse> think center vertically should be the default behaviour, but I c= reated Jesse> this new variable so it won't change with default to nil the set= up of Jesse> other people. In that case you need to add the appropriate code to the list of c-defined lisp variables in cus-start.el. I don=CA=BCt think you can change the default behaviour. >> Also: could this not work as a new type of value for 'line-spacing' >> instead? Something like >>=20 >> '(both . 5) >>=20 >> to mean 5 pixels above and below? Jesse> I guess it could, but does that make sense? I think one would ex= pect Jesse> the line to be centered by default. That's how it works on other Jesse> editors. Perhaps, but backwards compatibility wins out here, I think. Anyway, what you have now works. Jesse> PS: Sorry for the late reply, it's been a busy week. We=CA=BCre all just volunteers here. Robert