Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

(I dropped the bug and added emacs-devel)

>>>>> On Wed, 20 Nov 2019 14:00:04 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    >> Now the next time you run debbugs-gnu as above that bug will appear as
    >> well.

    Michael> Sure (and I use it every single day). But I understood the request as
    Michael> "Pls give me one gnus summary buffer containing all messages of bugs I
    Michael> have tagged locally". This doesn't exist yet.

Ah, I misunderstood. How's this?

(defun debbugs-gnus-ephemeral-from-tagged ()
  (interactive)
  (when (file-exists-p debbugs-gnu-persistency-file)
    (with-temp-buffer
      (insert-file-contents debbugs-gnu-persistency-file)
      (eval (read (current-buffer)) t))
    (when debbugs-gnu-local-tags
      (gnus-read-ephemeral-bug-group
       debbugs-gnu-local-tags
       (alist-get 'emacs gnus-bug-group-download-format-alist)))))

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Michael> Sure (and I use it every single day). But I understood
>     Michael> the request as "Pls give me one gnus summary buffer
>     Michael> containing all messages of bugs I have tagged
>     Michael> locally". This doesn't exist yet.
>
> Ah, I misunderstood. How's this?
>
> (defun debbugs-gnus-ephemeral-from-tagged ()
>   (interactive)
>   (when (file-exists-p debbugs-gnu-persistency-file)
>     (with-temp-buffer
>       (insert-file-contents debbugs-gnu-persistency-file)
>       (eval (read (current-buffer)) t))
>     (when debbugs-gnu-local-tags
>       (gnus-read-ephemeral-bug-group
>        debbugs-gnu-local-tags
>        (alist-get 'emacs gnus-bug-group-download-format-alist)))))

Works for me. However, the "Status:" messages shall be kicked off. And
it shall be checked, whether `debbugs-gnu-mail-backend' is bound to `gnus'.

If Lars doesn't object, you might commit it, plus docstring, and plus
documentation in debbugs-ug.texi.

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 14:43:46 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Works for me. However, the "Status:" messages shall be kicked off. And
    Michael> it shall be checked, whether `debbugs-gnu-mail-backend' is bound to `gnus'.

The clue is in the name of the function, but OK.

No more feature requests :-)

    Michael> If Lars doesn't object, you might commit it, plus docstring, and plus
    Michael> documentation in debbugs-ug.texi.

I donʼt think Iʼm set up to push to elpa.

(defun debbugs-gnus-ephemeral-from-tagged ()
  "Create an ephemeral Gnus group of locally tagged emacs bugs."
  (interactive)
  (unless (eq debbugs-gnu-mail-backend 'gnus)
    (error "This function only works with Gnus."))
  (when (file-exists-p debbugs-gnu-persistency-file)
    (with-temp-buffer
      (insert-file-contents debbugs-gnu-persistency-file)
      (eval (read (current-buffer)) t))
    (when debbugs-gnu-local-tags
      (let ((mbox-url (replace-regexp-in-string
                       ";mboxstat=yes" ""
                       (alist-get 'emacs gnus-bug-group-download-format-alist)
                       nil t)))
      (gnus-read-ephemeral-bug-group
       debbugs-gnu-local-tags
       mbox-url)))))

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

> I donʼt think Iʼm set up to push to elpa.

I believe everybody with write access to emacs can also do so for
elpa, but I'm not sure.

Let's wait what Lars says, and then I could commit it in your name.

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 15:30:06 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    >> I donʼt think Iʼm set up to push to elpa.

    Michael> I believe everybody with write access to emacs can also do so for
    Michael> elpa, but I'm not sure.

I meant "I donʼt have an elpa checkout lying around, and Iʼm too lazy
to read up on what it would take to set things up so I can commit" :-)

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

> I meant "I donʼt have an elpa checkout lying around, and Iʼm too lazy
> to read up on what it would take to set things up so I can commit" :-)

That's a pretty good reason. Will commit in your name, when it's time for.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Eric Abrahamsen]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 20 Nov 2019 14:43:46 +0100, Michael Albinus <michael.albinus@gmx.de> said:
>
>     Michael> Works for me. However, the "Status:" messages shall be kicked off. And
>     Michael> it shall be checked, whether `debbugs-gnu-mail-backend' is bound to `gnus'.
>
> The clue is in the name of the function, but OK.
>
> No more feature requests :-)
>
>     Michael> If Lars doesn't object, you might commit it, plus docstring, and plus
>     Michael> documentation in debbugs-ug.texi.
>
> I donʼt think Iʼm set up to push to elpa.
>
> (defun debbugs-gnus-ephemeral-from-tagged ()
>   "Create an ephemeral Gnus group of locally tagged emacs bugs."
>   (interactive)
>   (unless (eq debbugs-gnu-mail-backend 'gnus)
>     (error "This function only works with Gnus."))
>   (when (file-exists-p debbugs-gnu-persistency-file)
>     (with-temp-buffer
>       (insert-file-contents debbugs-gnu-persistency-file)
>       (eval (read (current-buffer)) t))
>     (when debbugs-gnu-local-tags
>       (let ((mbox-url (replace-regexp-in-string
>                        ";mboxstat=yes" ""
>                        (alist-get 'emacs gnus-bug-group-download-format-alist)
>                        nil t)))
>       (gnus-read-ephemeral-bug-group
>        debbugs-gnu-local-tags
>        mbox-url)))))

How nice to wake up and find that someone's implemented my (fairly
off-handed) feature request! In fact I wasn't necessarily demanding that
all the bugs be displayed in one summary buffer -- that actually skips
the overview buffer where you can issue the control messages, which is
the main benefit. Though I'm sure I'd use this ephemeral group approach,
the tagging approach is perfectly good. I was a little confused when
searching for tags prompted me to enter a particular user tag, but
it turns out just hitting <RET> at the prompt showed me the tagged
reports.

Thanks for both of these approaches!

Eric

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 08:42:47 -0800, Eric Abrahamsen <eric@ericabrahamsen.net> said:
    Eric> How nice to wake up and find that someone's implemented my (fairly
    Eric> off-handed) feature request! In fact I wasn't necessarily demanding that
    Eric> all the bugs be displayed in one summary buffer -- that actually skips
    Eric> the overview buffer where you can issue the control messages, which is
    Eric> the main benefit. Though I'm sure I'd use this ephemeral group approach,
    Eric> the tagging approach is perfectly good. I was a little confused when
    Eric> searching for tags prompted me to enter a particular user tag, but
    Eric> it turns out just hitting <RET> at the prompt showed me the tagged
    Eric> reports.

If you stick

      (debbugs-gnu-summary-mode 1)

at the end of my function, you'll get 'E' 'C' and 'M-m' bindings,
which do the same things as in 'debbugs-gnu'.

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Eric> I was a little confused when searching for tags prompted me
>     Eric> to enter a particular user tag, but it turns out just
>     Eric> hitting <RET> at the prompt showed me the tagged reports.
>
> If you stick
>
>       (debbugs-gnu-summary-mode 1)
>
> at the end of my function, you'll get 'E' 'C' and 'M-m' bindings,
> which do the same things as in 'debbugs-gnu'.

Do they find already the proper bug-id? Cool, this saves me work :-)

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 18:01:42 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    Eric> I was a little confused when searching for tags prompted me
    Eric> to enter a particular user tag, but it turns out just
    Eric> hitting <RET> at the prompt showed me the tagged reports.
    >> 
    >> If you stick
    >> 
    >> (debbugs-gnu-summary-mode 1)
    >> 
    >> at the end of my function, you'll get 'E' 'C' and 'M-m' bindings,
    >> which do the same things as in 'debbugs-gnu'.

    Michael> Do they find already the proper bug-id? Cool, this saves me work :-)

Kind of, they search for #\\([0-9]+\\) on the current line, and then
from point-min, which will do the wrong thing if youʼre not on the
first line of the bug thread. They also look for an appropriate text
property, but thatʼs not set by 'gnus-read-ephemeral-bug-group'. I can
look at adding that, but if you have a debbugs-gnu list of tagged
bugs, you can visit each of them as a gnus group individually, so Iʼm
not sure itʼs worth the effort.

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     >> If you stick
>     >>
>     >> (debbugs-gnu-summary-mode 1)
>     >>
>     >> at the end of my function, you'll get 'E' 'C' and 'M-m' bindings,
>     >> which do the same things as in 'debbugs-gnu'.
>
>     Michael> Do they find already the proper bug-id? Cool, this saves
>     Michael> me work :-)
>
> Kind of, they search for #\\([0-9]+\\) on the current line, and then
> from point-min, which will do the wrong thing if youʼre not on the
> first line of the bug thread. They also look for an appropriate text
> property, but thatʼs not set by 'gnus-read-ephemeral-bug-group'. I can
> look at adding that, but if you have a debbugs-gnu list of tagged
> bugs, you can visit each of them as a gnus group individually, so Iʼm
> not sure itʼs worth the effort.

As you want. It's just convenience to send a control message immediately
while you're reading a given message in the accumulated summary buffer.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 18:34:11 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    >> >> If you stick
    >> >>
    >> >> (debbugs-gnu-summary-mode 1)
    >> >>
    >> >> at the end of my function, you'll get 'E' 'C' and 'M-m' bindings,
    >> >> which do the same things as in 'debbugs-gnu'.
    >> 
    Michael> Do they find already the proper bug-id? Cool, this saves
    Michael> me work :-)
    >> 
    >> Kind of, they search for #\\([0-9]+\\) on the current line, and then
    >> from point-min, which will do the wrong thing if youʼre not on the
    >> first line of the bug thread. They also look for an appropriate text
    >> property, but thatʼs not set by 'gnus-read-ephemeral-bug-group'. I can
    >> look at adding that, but if you have a debbugs-gnu list of tagged
    >> bugs, you can visit each of them as a gnus group individually, so Iʼm
    >> not sure itʼs worth the effort.

    Michael> As you want. It's just convenience to send a control message immediately
    Michael> while you're reading a given message in the accumulated summary buffer.

Well, with debbug-gnu-summary-mode enabled you'll be able to do that,
you'll just have to be slightly more careful with those
commands.

Hmm, how about if I changed the detection code to do

- search current line
- search backwards
- search from (point-min)

That would change nothing for single-bug ephemeral groups.

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

> Well, with debbug-gnu-summary-mode enabled you'll be able to do that,
> you'll just have to be slightly more careful with those
> commands.
>
> Hmm, how about if I changed the detection code to do
>
> - search current line
> - search backwards
> - search from (point-min)
>
> That would change nothing for single-bug ephemeral groups.

Pls do. As always, I'm happy if I can avoid work :-)

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 18:51:29 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    >> Well, with debbug-gnu-summary-mode enabled you'll be able to do that,
    >> you'll just have to be slightly more careful with those
    >> commands.
    >> 
    >> Hmm, how about if I changed the detection code to do
    >> 
    >> - search current line
    >> - search backwards
    >> - search from (point-min)
    >> 
    >> That would change nothing for single-bug ephemeral groups.

    Michael> Pls do. As always, I'm happy if I can avoid work :-)

Iʼm going to have to go and read "How to commit to Elpa for dummies"
now, aren't I? :-)

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

> Iʼm going to have to go and read "How to commit to Elpa for dummies"
> now, aren't I? :-)

It's simple. The repository is at git.sv.gnu.org:/srv/git/emacs/elpa.git

After pulling, you call "make -k", because some of the packages don't
compile successfully.

If you want also to see the external packages, you need "make externals"
between "git pull" and "make -k". That's all.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Eric Abrahamsen]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Wed, 20 Nov 2019 18:51:29 +0100, Michael Albinus <michael.albinus@gmx.de> said:
>
>     Michael> Robert Pluim <rpluim@gmail.com> writes:
>     >> Well, with debbug-gnu-summary-mode enabled you'll be able to do that,
>     >> you'll just have to be slightly more careful with those
>     >> commands.
>     >> 
>     >> Hmm, how about if I changed the detection code to do
>     >> 
>     >> - search current line
>     >> - search backwards
>     >> - search from (point-min)
>     >> 
>     >> That would change nothing for single-bug ephemeral groups.
>
>     Michael> Pls do. As always, I'm happy if I can avoid work :-)
>
> Iʼm going to have to go and read "How to commit to Elpa for dummies"
> now, aren't I? :-)

I don't think it's that hard! Clone from
<user>@git.sv.gnu.org:/srv/git/emacs/elpa.git, and everything else
should happen automatically.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 10:43:19 -0800, Eric Abrahamsen <eric@ericabrahamsen.net> said:

    Eric> I don't think it's that hard! Clone from
    Eric> <user>@git.sv.gnu.org:/srv/git/emacs/elpa.git, and everything else
    Eric> should happen automatically.

Yes, itʼs not difficult. Iʼm all set now, I can commit, or push to a
scratch branch, or post patches here, whatever people want.

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

Hi Eric,

>> (defun debbugs-gnus-ephemeral-from-tagged ()

Btw, this will be `debbugs-gnu-ephemeral-from-tagged'.

> How nice to wake up and find that someone's implemented my (fairly
> off-handed) feature request! In fact I wasn't necessarily demanding that
> all the bugs be displayed in one summary buffer -- that actually skips
> the overview buffer where you can issue the control messages, which is
> the main benefit. Though I'm sure I'd use this ephemeral group approach,
> the tagging approach is perfectly good.

You can already issue control messages from existing ephemeral groups in
debbugs, Lars did implement it. I will see whether I could bring it also
to this accumulated group; shall be possible, because the bug number is
always in the subject.

But first I'll wait for a comment from Lars.

> I was a little confused when searching for tags prompted me to enter a
> particular user tag, but it turns out just hitting <RET> at the prompt
> showed me the tagged reports.

Yes, it is a little bit unfortune that we have both local tags (used
here) and user tags (propagated to the server). Should have been made it
more clear in the UI.

By the way, I have customized debbugs-gnu-default-severities to
'("tagged") - always starting with the local tagged bugs.

> Thanks for both of these approaches!
>
> Eric

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 17:59:18 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
    Michael> Hi Eric,

    >>> (defun debbugs-gnus-ephemeral-from-tagged ()

    Michael> Btw, this will be `debbugs-gnu-ephemeral-from-tagged'.

'debbugs-gnu-gnus-ephemeral-from-tagged'? In theory you could
implement something similar for rmail. I hereby delegate the heavy
responsibility of naming this correctly to Somebody Else :-)

    >> How nice to wake up and find that someone's implemented my (fairly
    >> off-handed) feature request! In fact I wasn't necessarily demanding that
    >> all the bugs be displayed in one summary buffer -- that actually skips
    >> the overview buffer where you can issue the control messages, which is
    >> the main benefit. Though I'm sure I'd use this ephemeral group approach,
    >> the tagging approach is perfectly good.

    Michael> You can already issue control messages from existing ephemeral groups in
    Michael> debbugs, Lars did implement it. I will see whether I could bring it also
    Michael> to this accumulated group; shall be possible, because the bug number is
    Michael> always in the subject.

(debbugs-gnu-summary-mode 1)

(but see my caveats in my other message to Eric).

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Michael> Btw, this will be `debbugs-gnu-ephemeral-from-tagged'.
>
> 'debbugs-gnu-gnus-ephemeral-from-tagged'? In theory you could
> implement something similar for rmail. I hereby delegate the heavy
> responsibility of naming this correctly to Somebody Else :-)

We have no `debbugs-gnus-*' functions. The two accidents left I've just
fixed in the repository.

Maybe we shall even avoid `ephemeral' in the name (its gnus-ish), and we
call it `debbugs-read-tagged-bugs-with-gnus'. With the upper command
`debbugs-read-tagged-bugs'.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Wed, 20 Nov 2019 18:43:42 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Robert Pluim <rpluim@gmail.com> writes:
    Michael> Btw, this will be `debbugs-gnu-ephemeral-from-tagged'.
    >> 
    >> 'debbugs-gnu-gnus-ephemeral-from-tagged'? In theory you could
    >> implement something similar for rmail. I hereby delegate the heavy
    >> responsibility of naming this correctly to Somebody Else :-)

    Michael> We have no `debbugs-gnus-*' functions. The two accidents left I've just
    Michael> fixed in the repository.

    Michael> Maybe we shall even avoid `ephemeral' in the name (its gnus-ish), and we
    Michael> call it `debbugs-read-tagged-bugs-with-gnus'. With the upper command
    Michael> `debbugs-read-tagged-bugs'.

Hmm, is this not only for the GNU bugtracker, hence debbugs-gnu? Or
are you generalizing it to all types of debbugs instances?

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Michael> We have no `debbugs-gnus-*' functions. The two accidents
>     Michael> left I've just fixed in the repository.
>
>     Michael> Maybe we shall even avoid `ephemeral' in the name (its
>     Michael> gnus-ish), and we call it
>     Michael> `debbugs-read-tagged-bugs-with-gnus'. With the upper
>     Michael> command `debbugs-read-tagged-bugs'.
>
> Hmm, is this not only for the GNU bugtracker, hence debbugs-gnu? Or
> are you generalizing it to all types of debbugs instances?

You are right, of course. But Lars(?) did break this rule already with
`debbugs-read-emacs-bug-with-gnus'.

Well, since this and ´debbugs-read-emacs-bug-with-rmail' are the only
exceptions (and no commands to preserve), we shall rename them to
debbugs-gnu-*. And your new functions shall start then also with
debbugs-gnu-.

I shall stop to write for today. Too much confusion.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Lars Ingebrigtsen]

Robert Pluim <rpluim@gmail.com> writes:

> I donʼt think Iʼm set up to push to elpa.
>
> (defun debbugs-gnus-ephemeral-from-tagged ()
>   "Create an ephemeral Gnus group of locally tagged emacs bugs."
>   (interactive)
>   (unless (eq debbugs-gnu-mail-backend 'gnus)
>     (error "This function only works with Gnus."))

I think that's a good command, but it now what I thought was requested:
I thought the user just wanted the list from M-x debbugs-gnu, but only
with the tagged bug reports.  Because fetching and updating that list is
a million percentage faster than fetching the data for all the bug
reports.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Robert Pluim <rpluim@gmail.com> writes:
>
>> (defun debbugs-gnus-ephemeral-from-tagged ()
>>   "Create an ephemeral Gnus group of locally tagged emacs bugs."
>>   (interactive)
>>   (unless (eq debbugs-gnu-mail-backend 'gnus)
>>     (error "This function only works with Gnus."))
>
> I think that's a good command, but it now what I thought was requested:
> I thought the user just wanted the list from M-x debbugs-gnu, but only
> with the tagged bug reports.  Because fetching and updating that list is
> a million percentage faster than fetching the data for all the bug
> reports.

That's (debbugs-gnu '("tagged"))

Don't know whether it is worth to provide it as extra command. Maybe
just documenting in the debbugs user guide?

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

> That's (debbugs-gnu '("tagged"))

Ah, right.

> Don't know whether it is worth to provide it as extra command. Maybe
> just documenting in the debbugs user guide?

I think it's make a useful command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> That's (debbugs-gnu '("tagged"))
>
> Ah, right.
>
>> Don't know whether it is worth to provide it as extra command. Maybe
>> just documenting in the debbugs user guide?
>
> I think it's make a useful command.

I've pushed a change to elpa, adding commands debbugs-gnu-tagged and
debbugs-org-tagged.

Robert, your command in preparation might change slightly the
scope. Instead of showing all messages for the tagged bugs, it might
show all messages for the bugs in the current Debbugs buffer. This is
more general.

Since the current buffer might contain many bugs, there should be a
limit. Let's say, show messages of max 50 bugs (the most highest ones
per number).

Once we have settled this command, I'll make a debbugs release for elpa.

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Thu, 21 Nov 2019 15:54:00 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> I've pushed a change to elpa, adding commands debbugs-gnu-tagged and
    Michael> debbugs-org-tagged.

    Michael> Robert, your command in preparation might change slightly the
    Michael> scope. Instead of showing all messages for the tagged bugs, it might
    Michael> show all messages for the bugs in the current Debbugs buffer. This is
    Michael> more general.

Hey, when did I sign up for this? :-)

    Michael> Since the current buffer might contain many bugs, there should be a
    Michael> limit. Let's say, show messages of max 50 bugs (the most highest ones
    Michael> per number).

Iʼm not sure what you mean with that parenthetical statement. This
does it for the first 10 bugs in the current debbugs list. I could add
an &optional all, but since in my testing Iʼve already accidentally
requested 1000 bugs from the server, that might not be a good idea.

diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
index bf3ed2cd1..3e16a78a8 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -1399,6 +1399,29 @@ (defun debbugs-read-emacs-bug-with-rmail (id status merged)
     (define-key rmail-mode-map "E" 'debbugs-gnu-make-control-message)
     (rmail-show-message 1)))
 
+(defvar debbugs-gnu-read-bugs-limit 10)
+
+(defun debbugs-gnu-read-current-bugs-with-gnus ()
+  "Create a Gnus group of the messages from the currently shown bugs."
+  (interactive)
+  (unless (eq debbugs-gnu-mail-backend 'gnus)
+    (error "This function only works with Gnus."))
+  (save-excursion
+    (let ((mbox-url (replace-regexp-in-string
+                     ";mboxstat=yes" ""
+                     (alist-get 'emacs gnus-bug-group-download-format-alist)
+                     nil t))
+          ids)
+      (goto-char (point-min))
+      (dotimes (i debbugs-gnu-read-bugs-limit)
+        (push (cdr (assq 'id (tabulated-list-get-id))) ids)
+        (forward-line 1))
+      (setq ids (delete nil (nreverse ids)))
+      (gnus-read-ephemeral-bug-group
+       ids
+       mbox-url)
+      (debbugs-gnu-summary-mode 1))))
+
 (defun debbugs-read-tagged-bugs-with-gnus ()
   "Create an ephemeral Gnus group of locally tagged Emacs bugs."
   (interactive)

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Michael> Robert, your command in preparation might change slightly
>     Michael> the scope. Instead of showing all messages for the tagged
>     Michael> bugs, it might show all messages for the bugs in the
>     Michael> current Debbugs buffer. This is more general.
>
> Hey, when did I sign up for this? :-)

I could read your mind, you know? :-)

> +(defvar debbugs-gnu-read-bugs-limit 10)

I would make it a defcustom. Maybe we need also another defconst, which
is the upper limit this user option can be. Something like 50, or 100.

> +(defun debbugs-gnu-read-current-bugs-with-gnus ()
> +  "Create a Gnus group of the messages from the currently shown bugs."
> +  (interactive)
> +  (unless (eq debbugs-gnu-mail-backend 'gnus)
> +    (error "This function only works with Gnus."))
> +  (save-excursion
> +    (let ((mbox-url (replace-regexp-in-string
> +                     ";mboxstat=yes" ""
> +                     (alist-get 'emacs gnus-bug-group-download-format-alist)
> +                     nil t))
> +          ids)
> +      (goto-char (point-min))
> +      (dotimes (i debbugs-gnu-read-bugs-limit)
> +        (push (cdr (assq 'id (tabulated-list-get-id))) ids)
> +        (forward-line 1))
> +      (setq ids (delete nil (nreverse ids)))
> +      (gnus-read-ephemeral-bug-group
> +       ids
> +       mbox-url)
> +      (debbugs-gnu-summary-mode 1))))

That works so far for me, thanks. What I'm missing is handling of merged
bugs. That is, if a bug in a line shows also merged bug numbers.

Create a bug list via (debbugs-gnu-bugs 34322) . And then compare the
Gnus buffers, created by either (debbugs-gnu-select-report) or by
(debbugs-gnu-read-current-bugs-with-gnus) .

We would need also a command debbugs-gnu-read-current-bugs and key
bindings for this. Just to be prepared for a possible
debbugs-gnu-read-current-bugs-with-rmail.

If this is too much for your limited time, commit what you have, and I
will adapt the final bits then.

>  (defun debbugs-read-tagged-bugs-with-gnus ()
>    "Create an ephemeral Gnus group of locally tagged Emacs bugs."

I believe, this one is not needed anymore. A list with locally tagged
bugs is created now easily via debbugs-gnu-tagged. And there you call
debbugs-gnu-read-current-bugs.

Thanks, and best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

>>>>> On Fri, 22 Nov 2019 09:30:49 +0100, Michael Albinus <michael.albinus@gmx.de> said:

>> +(defvar debbugs-gnu-read-bugs-limit 10)

    Michael> I would make it a defcustom. Maybe we need also another defconst, which
    Michael> is the upper limit this user option can be. Something like 50, or 100.

If we make it a defcustom we can encode checking the max in the
defcustom form.

    Michael> That works so far for me, thanks. What I'm missing is handling of merged
    Michael> bugs. That is, if a bug in a line shows also merged bug numbers.

Yes, done.

    Michael> We would need also a command debbugs-gnu-read-current-bugs and key
    Michael> bindings for this. Just to be prepared for a possible
    Michael> debbugs-gnu-read-current-bugs-with-rmail.

I chose 'A' for 'A'll, and did some renaming. Suggestions welcome.

    Michael> If this is too much for your limited time, commit what you have, and I
    Michael> will adapt the final bits then.

"You get what anybody gets: you get a lifetime" :-)

    >> (defun debbugs-read-tagged-bugs-with-gnus ()
    >> "Create an ephemeral Gnus group of locally tagged Emacs bugs."

    Michael> I believe, this one is not needed anymore. A list with locally tagged
    Michael> bugs is created now easily via debbugs-gnu-tagged. And there you call
    Michael> debbugs-gnu-read-current-bugs.

Yes, it was left over, Iʼve removed it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-command-to-show-mailboxes-for-all-currently-show.patch --]
[-- Type: text/x-patch, Size: 4950 bytes --]

From 2378e7a1529fa372c1bc9aee0373b380df6602a2 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Fri, 22 Nov 2019 11:49:27 +0100
Subject: [PATCH] Add command to show mailboxes for all currently shown reports

* debbugs-gnu.el (debbugs-gnu-mode-map): Add binding for debbugs-gnu-select-current-bugs.
(debbugs-gnu-select-bugs-limit-max): New defconst.  Max for debbugs-gnu-select-bugs-limit.
(debbugs-gnu-select-bugs-limit): New defcustom.  Limits how many bugs
debbugs-gnu-select-current-bugs will retrieve.
(debbugs-gnu-select-current-bugs): New function. Shows mailboxes
for all currently shown bugs.
(debbugs-gnu-select-current-bugs-with-gnus): Implementation of mailbox
retrieval using Gnus.

* debbugs-ug.texi (Tabulated Lists): Add description of debbugs-gnu-select-current-bugs.
---
 packages/debbugs/debbugs-gnu.el  | 48 +++++++++++++++++++++++++++++++-
 packages/debbugs/debbugs-ug.texi |  8 ++++++
 2 files changed, 55 insertions(+), 1 deletion(-)

diff --git a/packages/debbugs/debbugs-gnu.el b/packages/debbugs/debbugs-gnu.el
index 303b62557..a4755694d 100644
--- a/packages/debbugs/debbugs-gnu.el
+++ b/packages/debbugs/debbugs-gnu.el
@@ -971,6 +971,7 @@ (defvar debbugs-gnu-mode-map
     (set-keymap-parent map tabulated-list-mode-map)
     (define-key map "\r" 'debbugs-gnu-select-report)
     (define-key map [mouse-2] 'debbugs-gnu-select-report)
+    (define-key map "A" 'debbugs-gnu-select-current-bugs)
     (define-key map "g" 'debbugs-gnu-rescan)
     (define-key map "R" 'debbugs-gnu-show-all-blocking-reports)
     (define-key map "C" 'debbugs-gnu-send-control-message)
@@ -990,10 +991,14 @@ (defvar debbugs-gnu-mode-map
     (define-key menu-map [debbugs-gnu-select-report]
       '(menu-item "Show Reports" debbugs-gnu-select-report
 		  :help "Show all reports belonging to this bug"))
+    (define-key-after menu-map [debbugs-gnu-select-current]
+      '(menu-item "Show Reports For All" debbugs-gnu-select-current-bugs
+		  :help "Show reports for all currently shown bugs")
+      'debbugs-gnu-select-report)
     (define-key-after menu-map [debbugs-gnu-rescan]
       '(menu-item "Refresh Bugs" debbugs-gnu-rescan
 		  :help "Refresh bug list")
-      'debbugs-gnu-select-report)
+      'debbugs-gnu-select-current)
     (define-key-after menu-map [debbugs-gnu-show-all-blocking-reports]
       '(menu-item "Show Release Blocking Bugs"
 		  debbugs-gnu-show-all-blocking-reports
@@ -1399,6 +1404,47 @@ (defun debbugs-read-emacs-bug-with-rmail (id status merged)
     (define-key rmail-mode-map "E" 'debbugs-gnu-make-control-message)
     (rmail-show-message 1)))
 
+(defconst debbugs-gnu-select-bugs-limit-max 50)
+(defcustom debbugs-gnu-select-bugs-limit 10
+  "Maximum number of bugs to retrieve for Gnus group.
+This applies for `debbugs-gnu-select-current-bugs.
+Maximum allowed value is 50 to avoid overloading the server."
+  :type '(integer
+          :validate
+          (lambda (widget)
+            (unless (<= 1
+                        (widget-value widget)
+                        debbugs-gnu-select-bugs-limit-max)
+              (widget-put widget :error
+                          "Invalid value: range is 1..50"))))
+  :version "27.1")
+
+(defun debbugs-gnu-select-current-bugs ()
+  "Retrieve the mailboxes for all currently shown bugs.
+Limited by `debbugs-gnu-select-bugs-limit'."
+  (interactive)
+  (unless (eq debbugs-gnu-mail-backend 'gnus)
+    (error "This function only works with Gnus."))
+  (debbugs-gnu-select-current-bugs-with-gnus))
+
+(defun debbugs-gnu-select-current-bugs-with-gnus ()
+  "Create a Gnus group of the messages from the currently shown bugs."
+  (save-excursion
+    (let ((mbox-url
+           (replace-regexp-in-string
+            ";mboxstat=yes" ""
+            (alist-get 'emacs gnus-bug-group-download-format-alist)
+            nil t))
+          ids)
+      (goto-char (point-min))
+      (dotimes (i debbugs-gnu-select-bugs-limit)
+        (push (debbugs-gnu-current-id t) ids)
+        (push (cdr (assq 'mergedwith (debbugs-gnu-current-status))) ids)
+        (forward-line 1))
+      (setq ids (delete nil (nreverse ids)))
+      (gnus-read-ephemeral-bug-group ids mbox-url)
+      (debbugs-gnu-summary-mode 1))))
+
 (defcustom debbugs-gnu-lars-workflow nil
   "If non-nil, set some Gnus vars as preferred by Lars."
   :type 'boolean
diff --git a/packages/debbugs/debbugs-ug.texi b/packages/debbugs/debbugs-ug.texi
index 8121f7bf8..6e86194e5 100644
--- a/packages/debbugs/debbugs-ug.texi
+++ b/packages/debbugs/debbugs-ug.texi
@@ -373,6 +373,14 @@
 Show the email messages that discuss the bug.
 
 @* @item
+@kindex @kbd{A}
+@kbd{A} @tab
+@code{debbugs-gnu-select-current-bugs} @*
+Show the email messages for all currently displayed messages
+(including merged reports).  Limited by user option
+@code{debbugs-gnu-select-bugs-limit}.
+
+@item
 @kindex @kbd{d}
 @kbd{d} @tab
 @code{debbugs-gnu-display-status} @*
-- 
2.24.0.155.gd9f6f3b619

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

> Subject: [PATCH] Add command to show mailboxes for all currently shown reports

Everything looks pretty good. Just some very minor nits:

> +(defconst debbugs-gnu-select-bugs-limit-max 50)

Pls add a docstring.

> +              (widget-put widget :error
> +                          "Invalid value: range is 1..50"))))

I would do (format "Invalid value: range is 1..%d" debbugs-gnu-select-bugs-limit-max)

Please commit to elpa, and thanks again!

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Robert Pluim]

>>>>> On Fri, 22 Nov 2019 12:41:56 +0100, Michael Albinus <michael.albinus@gmx.de> said:

    Michael> Please commit to elpa, and thanks again!

Done as 3dc62c20c

Iʼm unvolunteering myself for the rmail version: I haven't used rmail
in decades.

Robert

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Robert Pluim <rpluim@gmail.com> writes:

>     Michael> Please commit to elpa, and thanks again!
>
> Done as 3dc62c20c

Thanks! I've committed another code cleanup in debbugs, which was sleeping
for a while locally (I didn't want to disturb you while preparing your patch).

> Iʼm unvolunteering myself for the rmail version: I haven't used rmail
> in decades.

Maybe I give it a try.

> Robert

Best regards, Michael.

Re: bug#38136: [PATCH] Make gnus-group-get-new-news a non blocking thread

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

>> Iʼm unvolunteering myself for the rmail version: I haven't used rmail
>> in decades.
>
> Maybe I give it a try.

Implemented, and pushed. I'm not an Rmail user, so I hope this is useful.

>> Robert

Best regards, Michael.