unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: William Xu <william.xwl@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Xref completion
Date: Wed, 18 Nov 2020 08:35:58 +0100	[thread overview]
Message-ID: <m2mtzf9kwx.fsf@gmail.com> (raw)
In-Reply-To: 7593e751-cff0-7c1a-7d4c-f927a16c07c9@yandex.ru

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 17.11.2020 23:16, William Xu wrote:
>> (defun my-xref--show-defs-minibuffer (fetcher alist)
>>    (let* ((xrefs (funcall fetcher))
>>           (xref-alist (xref--analyze xrefs))
>>           (xref (if (not (cdr xrefs))
>>                     (car xrefs)
>>                   (cadr (assoc (completing-read "Jump to definition: " xref-alist)
>>                                xref-alist)))))
>>      (xref-pop-to-location xref (assoc-default 'display-action alist))))
>
> A solid try, but note you might have a problem when there are several
> matches in the same file: you won't be able to navigate to any but the 
> first one.
>
> Of course, depending on your current programming language, this might
> be not important.

In that case, we can just prepend the line and summary in front of the filename? 

(defun my-xref--show-defs-minibuffer (fetcher alist)
  (let* ((xrefs (funcall fetcher))
         (xref-alist (xref--analyze xrefs))
         xref-alist-with-line-info
         xref)

    (cl-loop for ((group . xrefs) . more1) on xref-alist
             do
             (cl-loop for (xref . more2) on xrefs do
                      (with-slots (summary location) xref
                        (let ((line (xref-location-line location)))
                          (push (cons (format "%d: %s %s" line summary group) xref)
                                xref-alist-with-line-info)))))

    (setq xref (if (not (cdr xrefs))
                   (car xrefs)
                 (cdr (assoc (completing-read "Jump to definition: " xref-alist-with-line-info)
                             xref-alist-with-line-info))))

    (xref-pop-to-location xref (assoc-default 'display-action alist))))

-- 
William




  reply	other threads:[~2020-11-18  7:35 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 18:13 Xref completion Pierre Neidhardt
2020-11-17 18:22 ` [SPAM UNSURE] " Stephen Leake
2020-11-17 18:32   ` Pierre Neidhardt
2020-11-17 18:46   ` Basil L. Contovounesios
2020-11-17 18:38 ` Eli Zaretskii
2020-11-17 19:11   ` Pierre Neidhardt
2020-11-17 19:27 ` Juri Linkov
2020-11-17 20:00   ` Dmitry Gutov
2020-11-17 21:16   ` William Xu
2020-11-17 21:38     ` Dmitry Gutov
2020-11-18  7:35       ` William Xu [this message]
2020-11-18 13:46         ` Dmitry Gutov
2020-11-18 18:53           ` William Xu
2020-11-18 19:22             ` Dmitry Gutov
2020-11-18 20:39               ` Juri Linkov
2020-11-19  1:34                 ` Dmitry Gutov
2020-11-18 18:47         ` João Távora
2020-11-19  1:43           ` Dmitry Gutov
2020-11-19  8:19             ` William Xu
2020-11-19 13:30               ` Dmitry Gutov
2020-12-02 21:44               ` Juri Linkov
2020-12-03  0:25                 ` Dmitry Gutov
2020-12-03 21:09                   ` Juri Linkov
2020-12-05  1:12                     ` Dmitry Gutov
2020-12-05 12:21                       ` William Xu
2020-12-05 21:02                         ` Dmitry Gutov
2020-12-06  8:30                           ` William Xu
2020-12-06 11:00                             ` Dmitry Gutov
2020-12-06 14:00                               ` William Xu
2020-12-06 21:01                                 ` Dmitry Gutov
2020-12-05 19:52                       ` Juri Linkov
2020-12-05 21:44                         ` Dmitry Gutov
2020-12-06 20:46                           ` Juri Linkov
2020-12-06 21:20                             ` Dmitry Gutov
2020-12-06 21:34                               ` Juri Linkov
2020-12-06 21:40                                 ` Dmitry Gutov
2020-12-07  9:27                       ` Daniel Martín
2020-12-07 15:12                         ` jixiuf
2020-12-07 21:57                           ` Dmitry Gutov
2020-12-07 21:53                         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2mtzf9kwx.fsf@gmail.com \
    --to=william.xwl@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).