From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Re: RFR cc-langs.el: change syntax for @ in Java Date: Thu, 08 Apr 2021 14:31:55 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 08 13:33:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUSuI-0004B0-Ct for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 13:33:06 +0200 Original-Received: from localhost ([::1]:37198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUSuH-0005Ss-Ef for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Apr 2021 07:33:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUStG-00051Q-Sn for emacs-devel@gnu.org; Thu, 08 Apr 2021 07:32:03 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUStD-0004ou-MI for emacs-devel@gnu.org; Thu, 08 Apr 2021 07:32:02 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1391E5C00FE; Thu, 8 Apr 2021 07:31:59 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Apr 2021 07:31:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=ZqMHJBUdVX3GEsphH21VCLf8FC 0Iwu2C6VZUIfWN+4c=; b=MnuhMqhCsBZgDACzylaan87qaKwd9/CBNkkrud6rim B33CJG2dnVYve6xSPB9xyeLPPIayuU7V1Na50x9DsepUQG7HMkocvxLyzvv/vU0z Y7fK17q+PRMv9E75rgTvTYLQoV9NuB6VYGijLJac/iu5tSBbU63HysX+3mnz/Km6 v84ztkLJrXIyHto6m7OQVMnh0qf8yT78NxTbb48Zcg+AtlhsgtkV1u35y/5XnOis 0cFgO0QbPEzursIr2AlgGEhgGRsMCiZCdCrLi8748ZWKiXDXaRR3qghFxxPOkmnX zSkE8Sixg3iCSWkV2YGJNSWYsOS+6CBTlUPdrcEo1/KQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZqMHJB UdVX3GEsphH21VCLf8FC0Iwu2C6VZUIfWN+4c=; b=QEHbj+zynrtzAk0LLYlIFy jF9NrMD50GJAz/5oq7li3yX8ay6AvEke+BtWMw9cFoM14AmqK38+Y36idQBBYgn7 LaqBw14xNAOBgekLoDlpkUx3umf2Xj31aCIEC3HX22OF2YKmbKLtHob2/9zVhbuV XQNHiQtD+Fg3/ntcGPaZF02hWD8YMZ9z5d1M5169G4LiyN911NktcRBXeaaE7eFB JRydaiXZzM45mpVtNR8HZDyAZB0P+qNux9MMCpRFb1XnYVdfU4NG5mNejWA1Rprp 2R8QwKtXw+D4Rr1SZLXvb3WvCjaOIEnlw/qmY90G/AvkOowLWee6JWqTb6LcGf/w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejledggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesthdtre dttdertdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehf rghsthhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpedvveekffdvueevhfdutdejhe ekvdeufeevtedttdevuddugfeiffeiveeivefhtdenucfkphepleehrddvledrgeehrddu jedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfh hguhhnsghinhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: from fgunbin.local (95-29-45-171.broadband.corbina.ru [95.29.45.171]) by mail.messagingengine.com (Postfix) with ESMTPA id B0061240069; Thu, 8 Apr 2021 07:31:57 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Thu, 8 Apr 2021 10:15:31 +0000") Mail-Followup-To: Alan Mackenzie , emacs-devel@gnu.org Received-SPF: pass client-ip=66.111.4.26; envelope-from=fgunbin@fastmail.fm; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267606 Archived-At: On 08/04/2021 10:15 +0000, Alan Mackenzie wrote: > I've just run the CC Mode test suite with this amendment, and it > produces the following successes on annotations-1.java: > > annotations-1.java:4: Expected analysis ((inclass 1) (topmost-intro 21)), got ((inclass 21) (topmost-intro 21)) > annotations-1.java:4: Expected indentation 0, got 32 > annotations-1.java:5: Expected analysis ((class-close 1)), got ((class-close 21)) > > .. So, there are things to sort out before we can apply the change. Ok, I'll look into them. > Again, what's the reason for this change? There must be a test case > where the current CC Mode handles some Java source code badly. I use symbol-at-point in java buffers from another mode (javaimp), and @ is just not part of the symbol, but rather, a prefix. Of course I could always cut it out, but I think that it should be fixed in cc-mode (as it may benefit other usages), thus my suggestion. Filipp