From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sat, 06 Jul 2024 13:40:28 +0200 Message-ID: References: <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> <_mNcR6ailVKpYHLxgfo_tJlYGeR0AQIzQWluspYYp5_g5pIIKkHLNfFkklQQgOKNiVW8jn8NS3i2dJ7_B2Qyx9v-Dq3MQ9mP8HNL30UWsqY=@protonmail.com> <878qyf4sgm.fsf@gmail.com> <878qye3l81.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pip Cet , Eli Zaretskii , Emacs Devel To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 13:41:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ3nI-0006GD-F5 for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 13:41:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ3ma-0000pM-MT; Sat, 06 Jul 2024 07:40:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ3mU-0000lv-JR for emacs-devel@gnu.org; Sat, 06 Jul 2024 07:40:43 -0400 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQ3mK-0000yD-Th; Sat, 06 Jul 2024 07:40:39 -0400 Original-Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a77e5929033so30114566b.0; Sat, 06 Jul 2024 04:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720266030; x=1720870830; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PiNPWho8oBB7h4BtnfCZXem3Bi9Q5f8NOY74GdiVkHE=; b=D5eTPiZQkAkM/o4Ed97xIxL3xlnmkDQms/2umuKRHoBhHFP+OROeka4d6QZiDERBW2 kvxelF3kvRt1hcoXxX2NrOu2NsgugwQz/cL6WdsJVoXK4sEaoLXu81Yszt8B1tzVGVnM lEumvP0xOde4eW/Xu6DcrYkdvnR6w/7KJ84hDmzOeBe9dQhyUeJaOvOs3aRRAKARSy7C CsqwL9mUMahl1dWX2AUeSJi3oyyIRBsPECTL8O2hxXZY3XcHsP4A4vF2pl3Cn8dGgSUH 7lmTpEmKuWSXw0KJMJi4P5PVydvhxWuvuU1K9r5SVK0NaTM8dYIku+WVmwEmr4FmSd/v RJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720266030; x=1720870830; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PiNPWho8oBB7h4BtnfCZXem3Bi9Q5f8NOY74GdiVkHE=; b=op+OlLUdoz7iX7f9nB5wT4md6QxeK2lz3aB/BfP518G6g3hfXyeRdXOdiXehZg7G7L 7bH7mwgAx/TyrPkmW553M7NG0EDGs/FsdrGRYkfLQ8vfm0FuejqtUmk3hIE032TzbNNG NbxLTDVHI904rYIBMMyT89ycfSa3qdYC2kNFUBFLHlrFh3Lrtum/be5clcVUt5oIjwNC wOd7KsK8deKTcgUIUW+dX6oQG9p5/Rz4RRMFpYhw5oss/qFMQCWHCytf9aWv7eesPhgh 297atp2wBInhJqgVmKM8k5M6D2jRm8L/ry1rrIA3L3kmNvUtCqQKH0rzPopXmAzi+N4P JxhQ== X-Forwarded-Encrypted: i=1; AJvYcCWBnCWsHRXozyDrfjLy9UqkC08RjSZMk9EPbzf+7FwiyR9B+RfgdMMUyxi6PRW+lAZbssF6Hz8ZYaJJpamJ3UbAoPuPWCZL0WdCvW6/wWTHb0w= X-Gm-Message-State: AOJu0YwuMRC1vuaq7L7XjrPxD3/R88wjVGCFeAzKDZKGXme5cWC+Rjlf Aq4G6gOVMjejNHZC8h6I2PabB5112xOFqWrHLWZnXsXsg0iGtbdQA0XMRQ== X-Google-Smtp-Source: AGHT+IHunpJhrkxDc3RObabWTL+6zHcUMfHyN2dduIXlwRUygkWJErOHbCX/rb99HODiao6Nm7b+iw== X-Received: by 2002:a17:906:35ce:b0:a77:eaf7:a63 with SMTP id a640c23a62f3a-a77eaf70becmr16517366b.10.1720266030120; Sat, 06 Jul 2024 04:40:30 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3a82e.dip0.t-ipconnect.de. [79.227.168.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77c0117b15sm196744266b.43.2024.07.06.04.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jul 2024 04:40:29 -0700 (PDT) In-Reply-To: <878qye3l81.fsf@gmail.com> (Helmut Eller's message of "Sat, 06 Jul 2024 11:47:58 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321424 Archived-At: Helmut Eller writes: > When I add > > MPS_ARGS_ADD (args, MPS_KEY_COMMIT_LIMIT, 1 << 30); > > to make_arena then > > make lisp/emacs-lisp/ert-tests > > aborts with > > trace.c:1088: Emacs fatal error: assertion failed: band != RankWEAK || rank == band > > This looks like a bug. I see that too. With the following backtrace * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 4.1 frame #0: 0x000000010039d184 emacs`mps_lib_assert_fail(file="/Users/gerd/emacs/github/mps/code/trace.c", line=1088, condition="band != RankWEAK || rank == band") at mpsliban.c:87:3 * frame #1: 0x00000001003f8538 emacs`traceFindGrey(segReturn=0x000000016fdf9408, rankReturn=0x000000016fdf9404, arena=0x0000000100cd4000, ti=0) at trace.c:1088:11 frame #2: 0x00000001003d9bf4 emacs`TraceAdvance(trace=0x0000000100cd4b50) at trace.c:1726:9 frame #3: 0x00000001003d8d44 emacs`TracePoll(workReturn=0x000000016fdf9500, collectWorldReturn=0x000000016fdf9514, globals=0x0000000100cd4008, collectWorldAllowed=1) at trace.c:1849:5 frame #4: 0x00000001003a5cb0 emacs`ArenaPoll(globals=0x0000000100cd4008) at global.c:745:16 frame #5: 0x00000001003a89e4 emacs`mps_ap_fill(p_o=0x000000016fdf96b0, mps_ap=0x00000001080018d8, size=24) at mpsi.c:1097:5 frame #6: 0x00000001002ec0b0 emacs`alloc_impl(size=24, type=IGC_OBJ_CONS, ap=0x00000001080018d8) at igc.c:3578:20 frame #7: 0x00000001002e68d4 emacs`alloc(size=16, type=IGC_OBJ_CONS) at igc.c:3606:10 frame #8: 0x00000001002e6864 emacs`igc_make_cons(car=(struct Lisp_Symbol *) $0 = 0x0000000107db2060, cdr=(struct Lisp_Symbol *) $1 = 0x0000000100ab3090) at igc.c:3633:28 frame #9: 0x00000001001f5e34 emacs`Fcons(car=(struct Lisp_Symbol *) $2 = 0x0000000107db2060, cdr=(struct Lisp_Symbol *) $3 = 0x0000000100ab3090) at alloc.c:2951:10 !gud 2951:10:/Users/gerd/emacs/github/tinker/src/alloc.c frame #10: 0x00000001002d1a40 emacs`add_properties(plist=(struct Lisp_Cons *) $4 = 0x000000015509a630, i=0x0000000153947a88, object=(struct Lisp_String *) $5 = 0x0000000107db2098, set_type=TEXT_PROPERTY_REPLACE, destructive=true) at textprop.c:450:40 frame #11: 0x00000001002cc674 emacs`add_text_properties_1(start=(EMACS_INT) $6 = 0, end=(EMACS_INT) $7 = 3948495, properties=(struct Lisp_Cons *) $8 = 0x000000015509a630, object=(struct Lisp_String *) $9 = 0x0000000107db2098, set_type=TEXT_PROPERTY_REPLACE, destructive=true) at textprop.c:1289:19 frame #12: 0x00000001002cbe98 emacs`Fadd_text_properties(start=(EMACS_INT) $10 = 0, end=(EMACS_INT) $11 = 3948495, properties=(struct Lisp_Cons *) $12 = 0x000000015509a630, object=(struct Lisp_String *) $13 = 0x0000000107db2098) at textprop.c:1308:10 frame #13: 0x000000010021f7cc emacs`Fpropertize(nargs=3, args=(struct Lisp_Symbol *) $14 = 0x0000000248b93a90) at editfns.c:3277:3 frame #14: 0x0000000100231ff4 emacs`funcall_subr(subr=0x0000000100a540e0, numargs=3, args=(struct Lisp_Symbol *) $15 = 0x0000000248b93a90) at eval.c:3258:9 frame #15: 0x0000000100293450 emacs`exec_byte_code(fun=(struct Lisp_Vector *) $16 = 0x000000010b275460, args_template=256, nargs=0, args=(struct Lisp_Symbol *) $17 = 0x0000000248b93aa8) at bytecode.c:827: And I have not the slightest idea what that means or how the commit limit comes into play.