From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: "Final" version of tty child frames Date: Tue, 22 Oct 2024 15:43:29 +0200 Message-ID: References: <86ttd4ftvs.fsf@gnu.org> <86plnsfp7j.fsf@gnu.org> <86ldygfeg8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 22 15:44:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3FBl-000AE4-N2 for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Oct 2024 15:44:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3FAm-0000QN-CL; Tue, 22 Oct 2024 09:43:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3FAe-0000Fw-Ut for emacs-devel@gnu.org; Tue, 22 Oct 2024 09:43:38 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t3FAb-00019c-TI; Tue, 22 Oct 2024 09:43:35 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4315839a7c9so62205735e9.3; Tue, 22 Oct 2024 06:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729604611; x=1730209411; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PwzPkl8ErE5Bjy+/D25DnzzA5l9+afsnQN3QYsMGJlE=; b=TJ6VZbmj432aKlxudKWyD3SW6kEO/zaRqdynVy5xidQU6DkF0BDczkUXUY2aNNGcPD T7X2cdWOK1OFTtLuBGknPi7mGPGpeKOY2q8v8sxjCY8RRDT8w3ikMEh+24mHWWyDmOOG TFx9xCXnxsHQSgJ+Ced9oKVR8+gEPZNKcFxX44O9x8F91ziA+HP+YrlT2f2xJ8v+IkFT bdjc8XRAQzosUGwRFTpjYbIB9b5YztvCQfdfqQznHko8+zCUebkIzUGMcOgCDApNdMgN 5O/+GiJb6uvoGMsz8ci6Jj6xQW0ikUmH5n+fku5VOJLj5NbbJt4Oo+SdMLjuOqfyaBAq ydwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729604611; x=1730209411; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PwzPkl8ErE5Bjy+/D25DnzzA5l9+afsnQN3QYsMGJlE=; b=OUHnVGLdYIAN0gd6erTlTFtA9ZTeFlzhIkVwsRQeISzKj03GGx/3H0LpXSqyU2N65v vKE3shhUtsiYi/4gsiSPLuL0TQXT6g7GIVlj3gRXXviFAYixl2wvfkbULDjG9Xlb0Jkt aUOzRZPJQFmoB9IxfBzfna8VRckpzwqASLmBZ4bs8apBoyxvY/lu0byY+Ch2B9jXPVKu shzEbBVLZ8RRWHGgVAHwOFabOvrSoS30IQtDC2NUn0+ZcC0/LAMh9qmdUpYasS/eJUTO fB3a9/6Z+Ugt54DHGe2xqz7ePD7jh6MQ8kOyPUTaKEEmbOrGQQsUTDuBuSCmcvtbdI2D 2swQ== X-Gm-Message-State: AOJu0YyfCj7HV66J/rEZmMO1yXT/MjhA3lFktcZF4xU+6NJnwfsg6Lgp WE8/w47PDmFRYDzwl7I97U4/6q/DTJ+vc+rqxVMPCIFxDOtXGL7GSTxKAF2D X-Google-Smtp-Source: AGHT+IGwUtAaQh+QC8bzkIspl9c/03Eyr65xn8PejKCuNYaVv3sfYawvO9l6o8GTsF6cwUFyCcqufw== X-Received: by 2002:a05:600c:1c0b:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-4316165a097mr129692005e9.14.1729604611114; Tue, 22 Oct 2024 06:43:31 -0700 (PDT) Original-Received: from pro2 (p4fe3ac5a.dip0.t-ipconnect.de. [79.227.172.90]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b9baa7sm6640947f8f.96.2024.10.22.06.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 06:43:30 -0700 (PDT) In-Reply-To: <86ldygfeg8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Oct 2024 16:35:19 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324733 Archived-At: Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: emacs-devel@gnu.org >> Date: Tue, 22 Oct 2024 12:23:04 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Gerd M=C3=B6llmann >> >> Cc: emacs-devel@gnu.org >> >> Date: Tue, 22 Oct 2024 10:21:43 +0200 >> >>=20 >> >> Thanks for taking a look. >> > >> > Can you explain this comment and the code change: >> > >> > + /* Struct frame can move with igc, and so on. But we need >> > + something that takes different frames into account. Use= the >> > + face_cache pointer for that which is malloc'd. */ >> > + if (glyph->frame && glyph->frame !=3D f) >> > + face_id +=3D (ptrdiff_t) glyph->frame->face_cache; >> > >> > Why do we need to take the frame into account here? Is this relevant >> > to the current GC used on master? >>=20 >> I can try. >>=20 >> A combined frame matrix's glyph contents may come from different frames, >> either the root frame one of its descendants (children, grandchildren >> and so on). See copy_child_glyphs. glyph->frame is th eframe from where >> the glyph stems. It is filled out when producing glyphs. >>=20 >> Face ids are valid only in frame's face cache. A Face with a given id in >> one frame may be different from the same id another frame. So that's why >> I'm taking the face cache into account here. Otherwise it could happen >> that row hashes are the same although the contents are different. Not a >> big deal, but one can avoid it, so I did. > > Why not simply include the frame pointer in the hash?=20=20 With igc, frames move in memory, face caches are malloc'd. > Adding a pointer to a number looks kludgey, and might even make the > hash weaker. If you have something better, please tell.=20