From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Andrew Choi Newsgroups: gmane.emacs.devel Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows] Date: Wed, 23 Oct 2002 10:19:19 -0600 Sender: emacs-devel-admin@gnu.org Message-ID: References: <20021023134918.2AAE.LEKTU@terra.es> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT X-Trace: main.gmane.org 1035390080 13984 80.91.224.249 (23 Oct 2002 16:21:20 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 23 Oct 2002 16:21:20 +0000 (UTC) Cc: rms@gnu.org, andrewi@gnu.org, eliz@is.elta.co.il, jay_finger@hotmail.com, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 184OFx-0003d1-00 for ; Wed, 23 Oct 2002 18:21:17 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 184OHj-0002ui-00 for ; Wed, 23 Oct 2002 18:23:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 184OF1-00031x-00; Wed, 23 Oct 2002 12:20:19 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 184OEQ-0002PU-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 12:19:42 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 184OEL-0002Cb-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 12:19:39 -0400 Original-Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10] helo=pd3mo2so.prod.shaw.ca) by monty-python.gnu.org with esmtp (Exim 4.10) id 184OEI-00025v-00; Wed, 23 Oct 2002 12:19:34 -0400 Original-Received: from pd3mr3so.prod.shaw.ca (pd3mr3so-ser.prod.shaw.ca [10.0.141.179]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H4G002OV00BS7@l-daemon>; Wed, 23 Oct 2002 10:19:23 -0600 (MDT) Original-Received: from pn2ml9so.prod.shaw.ca (pn2ml9so-qfe0.prod.shaw.ca [10.0.121.7]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H4G005NO00BJI@l-daemon>; Wed, 23 Oct 2002 10:19:23 -0600 (MDT) Original-Received: from owlbear.local.shawmail (h68-144-207-94.cg.shawcable.net [68.144.207.94]) by l-daemon (iPlanet Messaging Server 5.1 HotFix 0.8 (built May 12 2002)) with ESMTP id <0H4G00LKU00AJ4@l-daemon>; Wed, 23 Oct 2002 10:19:23 -0600 (MDT) In-reply-to: <20021023134918.2AAE.LEKTU@terra.es> Original-To: Juanma Barranquero User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 28 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8694 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8694 Juanma Barranquero writes: > [...] the following patch would do, I think. > > Basically it makes sense to extract the definition of XColor from the > three or four places it happens now and define it specifically in the > *gui.h files of the platforms that need it (w32gui.h and macgui.h at > this moment). The same bug is also present in EMACS_21_1_RC, BTW. If the > patch is approved it should be applied to the pretest too. > > It works on my system. I've not commited the patch because I don't want > to change Mac files without Andrew Choi's approval, specially as I > can not test the changes on that platform. > > I've maintained the #ifndef HAVE_X_WINDOWS guards. On Window systems > probably that's unnecesary, but on Macs I bet they're needed if you > happen to build on Mac OS X. > > Comments? > > /L/e/k/t/u > [...] Thank you for taking macgui.h into consideration. I've just checked that the change works fine on Mac OS X. I believe the `#ifndef HAVE_X_WINDOWS' is needed when compiling for X Window on Mac OS X. Please keep it around. Thanks.