From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: CHENG Gao Newsgroups: gmane.emacs.devel Subject: Re: Info about color-values need be revised Date: Mon, 17 Aug 2009 01:32:33 +0800 Organization: cyberhut.org Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1250444929 16796 80.91.229.12 (16 Aug 2009 17:48:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Aug 2009 17:48:49 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 16 19:48:42 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by lo.gmane.org with esmtp (Exim 4.50) id 1McjqU-00006Y-Bv for ged-emacs-devel@m.gmane.org; Sun, 16 Aug 2009 19:48:42 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1McjqR-0000fD-BJ for ged-emacs-devel@m.gmane.org; Sun, 16 Aug 2009 17:48:39 +0000 Original-Received: from localhost ([127.0.0.1]:40321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McjqR-0000Bj-EZ for ged-emacs-devel@m.gmane.org; Sun, 16 Aug 2009 13:48:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1McjqL-0000AG-Ho for emacs-devel@gnu.org; Sun, 16 Aug 2009 13:48:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1McjqG-00005Y-6P for emacs-devel@gnu.org; Sun, 16 Aug 2009 13:48:32 -0400 Original-Received: from [199.232.76.173] (port=53276 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1McjqF-00005L-Uv for emacs-devel@gnu.org; Sun, 16 Aug 2009 13:48:27 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:36665 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1McjqF-0006Rs-97 for emacs-devel@gnu.org; Sun, 16 Aug 2009 13:48:27 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Mcjq7-0000e5-WE for emacs-devel@gnu.org; Sun, 16 Aug 2009 17:48:20 +0000 Original-Received: from 122.192.41.48 ([122.192.41.48]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Aug 2009 17:48:19 +0000 Original-Received: from chenggao by 122.192.41.48 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Aug 2009 17:48:19 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 122.192.41.48 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) Cancel-Lock: sha1:qQaGCbtzXcMMC6UuN8lTTxWGr0o= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114322 Archived-At: *On Sun, 16 Aug 2009 08:30:53 -0700 * Also sprach "Drew Adams" : >> In ELISP manual, info about color-values is not true any more with NS >> port merged. It says return value is (R G B). >> >> In NS port, color-values uses function xw-color-values: >> The return value is (R G B Alpha). > > Ouch! Why is that? Why does a platform-specific function change the meaning of a > generic function that way? And why should the generic function's signature be > changed accordingly (breaking existing code)? > > Code that uses `color-values' depends on its return value being a 3-element > list. That includes any NS code that uses `color-values' (as opposed to > `xw-color-values'). Seems like any NS code that needs the Alpha info should call > `xw-color-values' directly (or some other NS-specific function) - and > `color-values' should be left alone. I dont have strong opinion or even weak opinion about what's right or wrong. I just report my findings. As for what to do, it's up to Emacs developers. -- Ubi bene, ibi patria