From: Sascha Wilde <wilde@sha-bang.de>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Wrong extra argument to make-obsolete-overload in semantic/tag-file.el
Date: Wed, 28 Oct 2009 14:22:39 +0100 [thread overview]
Message-ID: <m2ljiv1wm8.fsf@sha-bang.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 147 bytes --]
Hi *,
on Sun Oct 25 Stefan added a big bunch of `when' args to various
function calls in the semantic code. This included the following
change:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 642 bytes --]
diff -r 580466ce1a98 -r 2cc681b53a29 lisp/cedet/semantic/tag-file.el
--- a/lisp/cedet/semantic/tag-file.el Sun Oct 25 02:07:45 2009 +0000
+++ b/lisp/cedet/semantic/tag-file.el Sun Oct 25 02:55:27 2009 +0000
@@ -103,7 +103,7 @@
)
(make-obsolete-overload 'semantic-find-nonterminal
- 'semantic-go-to-tag)
+ 'semantic-go-to-tag "23.2")
;;; Dependencies
;;
@@ -177,7 +177,7 @@
)))
(make-obsolete-overload 'semantic-find-dependency
- 'semantic-dependency-tag-file)
+ 'semantic-dependency-tag-file "23.2")
;;; PROTOTYPE FILE
;;
[-- Attachment #3: Type: text/plain, Size: 349 bytes --]
which is wrong as the function make-obsolete-overload does only take two
arguments and no third `when' arg.
Simply reverting this change fixed semantic for me.
cheers
sascha
--
Sascha Wilde
"Computers are good at following instructions,
but not at reading your mind."
D. E. Knuth, The TeXbook, Addison-Wesley 1984, 1986, 1996, p. 9
next reply other threads:[~2009-10-28 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 13:22 Sascha Wilde [this message]
2009-10-28 14:02 ` Wrong extra argument to make-obsolete-overload in semantic/tag-file.el Stefan Monnier
2009-10-28 18:39 ` Sascha Wilde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ljiv1wm8.fsf@sha-bang.de \
--to=wilde@sha-bang.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).