From: David Engster <deng@randomsample.de>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: no gnus registry new dependency on ert?
Date: Wed, 06 Apr 2011 15:28:07 +0200 [thread overview]
Message-ID: <m2liznzezc.fsf@randomsample.de> (raw)
In-Reply-To: <87vcyrr0ec.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 06 Apr 2011 08:10:19 -0500")
Ted Zlatanov writes:
> On Wed, 06 Apr 2011 05:54:46 -0500 Ted Zlatanov <tzz@lifelogs.com> wrote:
>
> TZ> On Wed, 06 Apr 2011 12:10:26 +0200 David Engster <deng@randomsample.de> wrote:
> DE> Either that, or just do
>
> DE> (eval-when-compile
> DE> (when (null (require 'ert nil t))
> DE> (defmacro* ert-deftest (name () &body docstring-keys-and-body))))
>
> DE> to silence the byte-compiler. Your solution is less hacky, but then you
> DE> have to always remember to wrap ert-deftest in those featurep clauses.
>
> TZ> Oh, I like your solution better since I don't have to reindent ;)
>
> TZ> I made the change in *registry.el, thanks.
>
> Interesting. When I byte-compile in Gnus (just "make" in the Lisp
> directory), I get the attached backtrace. Sorry for the nasty backtrace
> but I can't load the code AND exhibit the problem.
>
> If I load gnus-registry.el and do `M-x eval-buffer' then it works
> properly. So something is off with the byte-compilation, at least the
> compilation that Gnus does.
It seems like putting (require 'ert) into an eval-when-compile is not
sufficient. You have to require it unconditionally.
So maybe your first idea was The Right Thing To Do, meaning to use
(require 'ert nil t)
and then test for feature 'ert. Alternatively, you could use the current
hack and put this require in there, too. But this is getting
increasingly ugly...
-David
next prev parent reply other threads:[~2011-04-06 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8762qs3swu.fsf@ericabrahamsen.net>
2011-04-06 10:03 ` no gnus registry new dependency on ert? Ted Zlatanov
[not found] ` <m24o6b667h.fsf@randomsample.de>
2011-04-06 10:54 ` Ted Zlatanov
2011-04-06 13:10 ` Ted Zlatanov
2011-04-06 13:28 ` David Engster [this message]
2011-04-06 14:26 ` Ted Zlatanov
2011-04-06 14:57 ` David Engster
2011-04-06 15:00 ` Ted Zlatanov
2011-04-06 15:03 ` David Engster
2011-04-06 15:51 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2liznzezc.fsf@randomsample.de \
--to=deng@randomsample.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).