Re: Identifying the face between STRETCH and right fringe.

[Robert Pluim <rpluim@gmail.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Wed, 28 Nov 2018 11:42:40 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: emacs-devel@gnu.org
>> 
>> > From: Robert Pluim <rpluim@gmail.com>
>> > Cc: emacs-devel@gnu.org
>> > Date: Wed, 28 Nov 2018 10:00:53 +0100
>> > 
>> > In this particular case extend_face_to_end_of_line has already done:
>> > 
>> >   default_face =
>> >     FACE_FROM_ID_OR_NULL (f, lookup_basic_face (it->w, f, DEFAULT_FACE_ID));
>> > 
>> > so there'd be no additional cost
>> 
>> Yes, but this part could (and probably should) be moved to after the
>> 'return', because default_face is not used before that.
>
> And btw, when the default face is remapped, its background color no
> longer has to be the same as the frame's background, right?  Which I
> guess is another reason why we use FRAME_BACKGROUND_PIXEL there.

OK, we can stick with that if no other proposals come up.

Moving the default_face lookup down in the function I can test for a
while. Iʼll even remove the _OR_NULL, since we donʼt check for NULL
anywhere anyway.

Robert