From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Compiling pdumper.c fails with gcc 4.7.2 Date: Thu, 24 Jan 2019 10:28:50 +0100 Message-ID: References: <5C482F7E.1050805@gmx.at> <5C497FE6.4010601@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4783"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 10:30:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmbKp-00014X-Sg for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 10:30:08 +0100 Original-Received: from localhost ([127.0.0.1]:50106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmbKo-00055z-M9 for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 04:30:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmbJf-00051H-Iy for emacs-devel@gnu.org; Thu, 24 Jan 2019 04:28:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmbJe-0005cd-Qg for emacs-devel@gnu.org; Thu, 24 Jan 2019 04:28:55 -0500 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:37086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmbJe-0005bV-HW for emacs-devel@gnu.org; Thu, 24 Jan 2019 04:28:54 -0500 Original-Received: by mail-wm1-x32f.google.com with SMTP id g67so2208901wmd.2 for ; Thu, 24 Jan 2019 01:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=lx60hPBIGWpn6Mn0ntCOl9X1em5gEdg4+S3hvBEIAAQ=; b=M4TG23ydCYwDEh4rc+/9JRxTrSYAs+gPWmKRAORHqX9GodtyF+u3l7K2daO7FIPpHt Nj6LYxpV9HxWi7xbMwXwQ5rWJQ3YHchJhEy3Xk1/kwo5VM6Zz7NywkOXPeRs4oTgux2a 2kV3LnB69h8z6a+82DWARl9wUKjAlIcAlv7iu2GU7cX+VjtNpKGGfdHyEIw8Na+nIQpx JJoLULugOgk94g0plfmfVAVSCVOW9Q/K88Yh1gTjHPfB1mKdNG0Bk/V1aL1vBBI8Qn1h lxai88a1JfXNrBPJz1/JM7X0KyHiHl7JuqUJ91vGXpJXY1WQ4WiZXdHdUzzBKpd7CTHq 456Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=lx60hPBIGWpn6Mn0ntCOl9X1em5gEdg4+S3hvBEIAAQ=; b=PXchuZfkErwpDn/jMROv8uxl5i8XK5U0NT6d5tDZ1QV8ZMQtrFdB0amG4YEAcnS74H XQRf9tbjOjEipG4DkYnvobkjn/+7T2m0QOC8Lf45qkhy9+Gk/ybrLBQ+W33nuP12Xyi9 gn/rir0bx89WAKWR73RcgvhmfAwVpWHHZofuo6jePj6UbcaNfC6qf2VTybNyCANwfCDD 9Dtg28arfo/a9v/O5QqEw+gWhlCQafUSRW1vTo8LYAqp5hsClOTOzY28fPbYmqt1jPtd p4jz0iCn24OuiVo97VY2s+mNZD0oJiLUrMzx4StcvLZNTGNwymmJlxifnGb16/iJVK/s 7kMQ== X-Gm-Message-State: AJcUukdFN+OOk81HXuzNWopV0hzmjDO69EwdQ4YO4Iv4g3wYh0fUBaA0 pKovVX11wW1VKvclnmpsMB7oqEm6 X-Google-Smtp-Source: ALg8bN5pkQOqr1/5vx8j6wgztW3vadXRKpMY9rIDRzT03oVOH5MzM9FtcXI69W8wSO+5bWBD06Q37Q== X-Received: by 2002:a1c:8148:: with SMTP id c69mr1782405wmd.126.1548322132701; Thu, 24 Jan 2019 01:28:52 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:6c01:fb6e:a9bd:beeb]) by smtp.gmail.com with ESMTPSA id s132sm41028609wmf.28.2019.01.24.01.28.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 24 Jan 2019 01:28:51 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <5C497FE6.4010601@gmx.at> (martin rudalics's message of "Thu, 24 Jan 2019 10:05:42 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232669 Archived-At: martin rudalics writes: >>> With gcc 4.7.2 compiling pdumper.c fails thusly: >>> >>> CC pdumper.o >>> ../../src/pdumper.c: In function =E2=80=98emacs_offset=E2=80=99: >>> ../../src/pdumper.c:718:27: error: declaration of =E2=80=98emacs_ptr=E2= =80=99 shadows a global declaration [-Werror=3Dshadow] >>> ../../src/pdumper.c:710:1: error: shadowed declaration is here [-Werror= =3Dshadow] >>> >>> Is there any practicable way to fix this? >> >> Sure, the emacs_ptr function is static, so it can change name easily >> enough. Something like the following works for me: > > Thank you very much. I verified that it would have worked here hadn't > Eli installed a different fix. Eli chose a better, shorter name than I did :-) Robert