From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 08 Feb 2019 09:01:22 +0100 Message-ID: References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> <831s6kgrtj.fsf@gnu.org> <83pnu4f45d.fsf@gnu.org> <837eg8dpd6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193767"; mail-complaints-to="usenet@blaine.gmane.org" Cc: ari.roponen@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 08 09:02:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gs16y-000oA3-Na for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 09:02:12 +0100 Original-Received: from localhost ([127.0.0.1]:52772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs16x-0007kj-Oc for ged-emacs-devel@m.gmane.org; Fri, 08 Feb 2019 03:02:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs16I-0007kT-W9 for emacs-devel@gnu.org; Fri, 08 Feb 2019 03:01:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs16H-0000q9-04 for emacs-devel@gnu.org; Fri, 08 Feb 2019 03:01:30 -0500 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:39925) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gs16G-0000oJ-8X; Fri, 08 Feb 2019 03:01:28 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id t27so2515093wra.6; Fri, 08 Feb 2019 00:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version; bh=X5V5GOS583VHl5vIMPiY9NMjr0e9ONefQDnCMqFKsKw=; b=GrXM3YFZn6BpuliP1EI2vGMe/IuaXs11mp9QozMCwUyoh7pIdo5NQY2uVCtpXKptSR sX5+w25SFmZ8WunGPo9pk0buGPLIXXP/qrtgjkLQ175XklZ5xkMPrxoQJAYHQbPGx99e Xb+9nvCu42qYme53A5+XwvbKbCMAH9TTGx7F++1jfXjf1XUkjA7IQOjnjJ3FgvBLsVcD XZ2f44mln7Nrvx/4vwEvrhHXvfm+yg44WPaLqkll+EpA7oQ+gQowgTbgyEvJcGDQNWXB bYmdPR9BLht7XgyO8WJkQnHiZTZ0YDWXbagnKiQpGMjVeLkwG3hAGYaoPlq9Xs3k01P7 xsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:message-id:mime-version; bh=X5V5GOS583VHl5vIMPiY9NMjr0e9ONefQDnCMqFKsKw=; b=Oo8aSOMqCu6J/6+qUDhOMNhtrQbweAv4lFH1OBXoVD0fA9ILXYzdtPSFazJu758iM5 M7QCfl81pOiUIjjpUxE0MnE0dgCNxhiZ1lZ14ImcqsDoHgCX9DITaCWpwZBHhwUsCm3k u4zECz526grQZrcZv0NfAHervt8nsl87LzGDGP/Ar8tY7+lTOY9HVnvXdbn1TlJsfTEh a9OPH4nhKKGTvMBBYTwRasdQPV3lSffT6kzPBpOHRhefb636IDsYgw30DiX23zFh9IyC /HONIvV4G831q6kAlF/TeKr1aVtWZLur2B2xcgxkcLOuR4qTB+QCnnbFrk7yzZo5o044 vI9g== X-Gm-Message-State: AHQUAuaBFU+fZHqa/jrzWI1CXhZedHZs8+HIWGo640IJwy24jO/2f5MW PJ8aZ4/w6hmdR9FOF1bAe+XN1wgH9d0= X-Google-Smtp-Source: AHgI3IbX1SXm8yB7T0bzXTKHm3wGRmoJ18m/oGx27eAFciD9aGKaDqdtYJkxOXA6KIKnZlkx97RTYg== X-Received: by 2002:a5d:5285:: with SMTP id c5mr14540034wrv.167.1549612885246; Fri, 08 Feb 2019 00:01:25 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:508e:f5c1:5162:8e85]) by smtp.gmail.com with ESMTPSA id m21sm1816341wmi.43.2019.02.08.00.01.23 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 08 Feb 2019 00:01:24 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233110 Archived-At: Eli Zaretskii writes: > > Thanks, this LGTM, and is a significant improvement, IMO. If no one > objects in a few days, please push. I built this on GNU/Linux with the following configs: ./configure # This builds xfont.o ftfont.o xftfont.o ftxfont.o ./configure --with-cairo # This builds ftfont.o ftcrfont.o ./configure --without-xft # This builds xfont.o only Pushed to emacs-26 as Just kidding. Pushed to master as I can cherry-pick this to the harfbuzz branch if you want. Robert