From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: marker-vector Date: Tue, 06 Aug 2024 08:51:53 +0200 Message-ID: References: <87le2hp6ug.fsf@localhost> <87v81455iw.fsf@gmail.com> <87jzh8djdt.fsf@gmail.com> <87a5hqsq2l.fsf_-_@gmail.com> <87bk26vfj1.fsf@protonmail.com> <87v80e2mia.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pip Cet , Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Monnier , Ihor Radchenko , emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 06 08:52:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbE3z-0000I4-Rm for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Aug 2024 08:52:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbE3D-00023P-L3; Tue, 06 Aug 2024 02:52:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbE3B-00022V-BB for emacs-devel@gnu.org; Tue, 06 Aug 2024 02:52:05 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbE39-0007dg-MK; Tue, 06 Aug 2024 02:52:04 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a6135dso494434a12.1; Mon, 05 Aug 2024 23:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722927115; x=1723531915; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PH5L+IkHHUU/cE+0bxtVcaFoBU4fUF0kJUZG7peE6dU=; b=l2FfF7QwUsGsdBNXJignF7CdYNE0AJOkKUIgqmx2kqq6q8BbfYsW/qKoDSB/D/Lv9b Cut+Fspo/k4PqDBxQgICKCzbDCbapRxVgz0SGN4eBs4Ws8hlrDbAmvabeUEs/+xoR6QP 1lnHp1elCQpyoME89x11F/uM+mwOl/CfLEjUFVQOW6gxXQw7ttflRjwcXWcqC2GRfgzt ZzfxSUeXaTXaWW2PEACCG33pbZNQKGnEb7XxRJ2EdW2HyL5uSwrYfcc5Jvub0L1D+p9k 18kvEn1Ma5ccqKMe8wG5nWzTOcdM/463lM7u7zXQYZxCWrs7e8jp8qxMKl7AhQ+dZv2D vnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722927115; x=1723531915; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PH5L+IkHHUU/cE+0bxtVcaFoBU4fUF0kJUZG7peE6dU=; b=EajtNrsmdFnuOJFqOMbqNA6FGTYdMZoTIeaI/VU7aZ7qjfoUv+x502TUASoDbLDFks am4nbn5nD1KFR8S7PkTNLvEBXnqUaoRGdyBy1c6aMn2nK0c8XhCpQNRMwaIHYqSi7AUv rfObbcNq5cg4wWrXBfdysbYqIXVUcPr4Inrmctlzs2oFCW/UAIEiCov3W2LEqQ9O6f2R rOlHp73qU4wHeRXFarHgn9qvIO5nZTD3+xE9E9EdtFl6FnbJ34Dzwj55Tz595VghMBAg yFqXGAAh0QcXmQW569ZJ6QCHgZgoTISVzSdr75EpuGAyXGtILs8YQAcnW4zjWofccxMo hLSw== X-Forwarded-Encrypted: i=1; AJvYcCUAT9cWwtEiBO/hGBWRdEOfZA1iZz0i0DmKbzlJhe8qkkIe5eFIH4EW+935fT1wRUGPCLIIrezy6KcX97qMUPJQOYIXUXndRTbgB6Gpg/oOZlI= X-Gm-Message-State: AOJu0YytRkOTE6rXqUITQp69+dVyIQIVG7iXz55s0UKwL0ynBbH6zo2B usRxSBvatQ4JfnMnamz9YiNp3Srw5XNzjr+5qLvP10wteneNn70jzfJdpQ== X-Google-Smtp-Source: AGHT+IFrFL2ppvmp4WDZsXClWYQAGjg4JVdo075GK58wD/MXqWK1IxqEipW1edsF5Ol2dJ+39bL6qQ== X-Received: by 2002:a17:907:3e8c:b0:a77:bfca:da57 with SMTP id a640c23a62f3a-a7dc509fbd2mr1022388166b.44.1722927115031; Mon, 05 Aug 2024 23:51:55 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36fc1.dip0.t-ipconnect.de. [217.227.111.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9ec4875sm517171366b.191.2024.08.05.23.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 23:51:54 -0700 (PDT) In-Reply-To: <87v80e2mia.fsf@gmail.com> (Helmut Eller's message of "Tue, 06 Aug 2024 08:28:29 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322425 Archived-At: Helmut Eller writes: >> - I'd prefer the marker index to be signed; if it is unsigned, we >> don't need to assert it's >= 0, and assigning -1 to it confused me... > > You'd have to talk to the person who designed the struct Lisp_Marker. I didn't design Lisp_Marker, but I added the index member for MPS. I made it signed just for the asserts, so that I could easily check if something went wrong.