From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: on-screen Date: Wed, 21 Oct 2015 11:20:53 -0700 Organization: New Artisans LLC Message-ID: References: <87k2qgcfm7.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445493442 23041 80.91.229.3 (22 Oct 2015 05:57:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Oct 2015 05:57:22 +0000 (UTC) Cc: emacs-devel To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 22 07:57:22 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zp8sH-0005BB-93 for ged-emacs-devel@m.gmane.org; Thu, 22 Oct 2015 07:57:17 +0200 Original-Received: from localhost ([::1]:56536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zp8sG-0004Np-Rx for ged-emacs-devel@m.gmane.org; Thu, 22 Oct 2015 01:57:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zoy0T-0007Sk-Ng for emacs-devel@gnu.org; Wed, 21 Oct 2015 14:21:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zoy0Q-000695-On for emacs-devel@gnu.org; Wed, 21 Oct 2015 14:21:01 -0400 Original-Received: from mail-pa0-x231.google.com ([2607:f8b0:400e:c03::231]:34175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zoy0Q-00068k-JH for emacs-devel@gnu.org; Wed, 21 Oct 2015 14:20:58 -0400 Original-Received: by padhk11 with SMTP id hk11so61578188pad.1 for ; Wed, 21 Oct 2015 11:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:date:organization:message-id :references:user-agent:mail-followup-to:mime-version:content-type; bh=degfgZaqWIv7HaFxx654rD/Bkk8OZ9Kai/B6NY2VjOE=; b=1G47NedNPsLuCe3ro3bu39spxpmBifTuuvcYAC0NkJayaKZAgvindv+LRHDVOsYPBW ft+x1OIMyBbODsrnEG9H2hf6Xd99CZlpXR/Au3xMIv8fDOd1A9Xh89Bn9o4A08UAzYyu vQ3R0nNJJQ7YjZD7JM7kTAIsj96NqH/5akiVhJON7blHAhotmfiSmxVJAz+F8FaYoCau MioSYB4F8E4xdTtJxjhyuJE2QIPImYrAH2WHuhSHCizAVVzvtgjnB1JAyDKI2kFIiUrI S5p+rc55RXku3skzCz8yJv/baue4f3wDFUu/6h2ZvaFQm4hHJN07mB6NVHXm3/4U7mIW 85gQ== X-Received: by 10.67.3.2 with SMTP id bs2mr12218583pad.118.1445451657935; Wed, 21 Oct 2015 11:20:57 -0700 (PDT) Original-Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id im9sm10348881pbc.1.2015.10.21.11.20.56 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 21 Oct 2015 11:20:56 -0700 (PDT) Original-Received: by Vulcan.local (Postfix, from userid 501) id 4A77EF5B36C7; Wed, 21 Oct 2015 11:20:56 -0700 (PDT) In-Reply-To: <87k2qgcfm7.fsf@web.de> (Michael Heerdegen's message of "Wed, 21 Oct 2015 19:10:08 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) Mail-Followup-To: Michael Heerdegen , emacs-devel X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192350 Archived-At: >>>>> Michael Heerdegen writes: > It implements a minor mode that highlights (in a customizable way) the last > visible buffer area after scrolling, for better orientation when reading > texts or code. Neat. Just two comments: (let ((method `(,on-screen-highlight-method . ,on-screen-inverse-flag))) Is the same as: (let ((method (const on-screen-highlight-method on-screen-inverse-flag))) The other one is a matter of affecting the global environment. In `on-screen-initialize', you should pass `t' as a 3rd argument to add-hook, so the hooks are only affected in buffers where on-screen mode is active. John