unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "John Wiegley" <johnw@newartisans.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: on-screen
Date: Wed, 21 Oct 2015 11:20:53 -0700	[thread overview]
Message-ID: <m2k2qg13sq.fsf@newartisans.com> (raw)
In-Reply-To: <87k2qgcfm7.fsf@web.de> (Michael Heerdegen's message of "Wed, 21 Oct 2015 19:10:08 +0200")

>>>>> Michael Heerdegen <michael_heerdegen@web.de> writes:

> It implements a minor mode that highlights (in a customizable way) the last
> visible buffer area after scrolling, for better orientation when reading
> texts or code.

Neat.  Just two comments:

  (let ((method `(,on-screen-highlight-method . ,on-screen-inverse-flag)))

Is the same as:

  (let ((method (const on-screen-highlight-method on-screen-inverse-flag)))


The other one is a matter of affecting the global environment. In
`on-screen-initialize', you should pass `t' as a 3rd argument to add-hook, so
the hooks are only affected in buffers where on-screen mode is active.

John



  reply	other threads:[~2015-10-21 18:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 17:02 [ELPA] New package: beacon Artur Malabarba
2015-10-15 17:24 ` Kaushal Modi
2015-10-15 17:26   ` Kaushal Modi
2015-10-15 17:33     ` Kaushal Modi
2015-10-15 21:27       ` Artur Malabarba
2015-10-15 21:37         ` Kaushal Modi
2015-10-15 21:44           ` Kaushal Modi
2015-10-15 22:13             ` Artur Malabarba
2015-10-15 22:27               ` Kaushal Modi
2015-10-15 22:40                 ` Kaushal Modi
2015-10-16  8:06                   ` Tassilo Horn
2015-10-15 22:47                 ` Artur Malabarba
2015-10-15 21:21   ` Artur Malabarba
2015-10-16 13:11     ` Phillip Lord
2015-10-16 13:54       ` Artur Malabarba
2015-10-15 21:42   ` Rasmus
2015-10-15 17:36 ` Marcin Borkowski
2015-10-15 17:55   ` Kaushal Modi
2015-10-15 18:17   ` Artur Malabarba
2015-10-15 18:31 ` Howard Melman
2015-10-15 21:36   ` Artur Malabarba
2015-10-21 17:10 ` [ELPA] New package: on-screen (was: [ELPA] New package: beacon) Michael Heerdegen
2015-10-21 18:20   ` John Wiegley [this message]
2015-10-21 18:54     ` [ELPA] New package: on-screen John Wiegley
2015-10-21 19:04     ` Michael Heerdegen
2015-10-21 19:28       ` John Wiegley
2015-10-22  7:26     ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2k2qg13sq.fsf@newartisans.com \
    --to=johnw@newartisans.com \
    --cc=emacs-devel@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).