From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Incorporate package macrostep into Emacs core Date: Tue, 19 Mar 2024 08:30:02 +0100 Message-ID: References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87y1b46vhg.fsf@jeremybryant.net> <878r336lvb.fsf@jeremybryant.net> <86y1b1p1ni.fsf@gnu.org> <87y1b0mi4b.fsf@jeremybryant.net> <8734sobkdj.fsf@jeremybryant.net> <87il1jdhzd.fsf@posteo.net> <87le6f9m8b.fsf@jeremybryant.net> <87o7basp70.fsf@posteo.net> <87jzlysmvp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7604"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jeremy Bryant , Jeremy Bryant via "Emacs development discussions." , Eli Zaretskii , monnier@iro.umontreal.ca, j.j.oddie@gmail.com, stefankangas@gmail.com, jonas@bernoul.li To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 08:30:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmTvb-0001k9-0b for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 08:30:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmTvG-0002eP-AB; Tue, 19 Mar 2024 03:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmTvD-0002eC-9Q for emacs-devel@gnu.org; Tue, 19 Mar 2024 03:30:07 -0400 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmTvB-0008Ad-JM; Tue, 19 Mar 2024 03:30:06 -0400 Original-Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a4682272ff6so430175366b.2; Tue, 19 Mar 2024 00:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710833403; x=1711438203; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbnotQhsAp4L9JIO6/ksIFrcAa1pmFlCFojLysUE6Kw=; b=d0dXAZG0kX/PVH8bgKIXqEcBVUrW+I+CHSRBmCfFfWh32nxm5c9tYDhq51u9x4Z8lT nF+ayo8I0NnjETSU/Sg2RBamhcvAjyoLZ9WkKTAoFT+cJILqmoqHc4TjYO2GD10/WQH6 hqg3qKiF6OkXHT1chkcXBJlkQCA8ypu2SpEzXMXwfUvlAuwnafowvwJvZJcAuB2DyV2m EljHi2zIzWkKkqxV6xOZnvfk+SDCtmceq6V9iWfw2cQvpgAeoM8wWlzWBeqkBVhrGz0L AaDiwkB339e9jlz1vc3lU+GZMzti1jPttjvCNe/0Fbxvaga92XNhDDVo7aGkY/YJmVEV NcDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710833403; x=1711438203; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zbnotQhsAp4L9JIO6/ksIFrcAa1pmFlCFojLysUE6Kw=; b=fh6opWzYmh7LuiiIkG4BTvdPzIu32BYFaqJyJURknclmH6NbZwp4TtD60oiyUXLT35 vUD8OHWkqqBe2aTRC4h6HflWLpa3kx84hQg/BC7XG7qrnPr4alJnTOnw7nvb8WKKcj1y VlhTQpW1zRWQx0qn2y9cUtP0JXF1sVx1Bbo/v3/3a7783dM5NNiptt1u5WcWZGnCNTBr 9Dzny7U+BpgTLZmatgxuDDtdvi2wPjJLWyD981Mx4woMsmzU+TBmjGdeAUKsE+WxJ3Dn RRANpiPTYVuID3eeCLHcG06mvmfQIpCJyhTZsNiK952xkUn9f+eq45z+xdqJpGpOqRPM 7crQ== X-Forwarded-Encrypted: i=1; AJvYcCXKQI3ujm8FgrHPRkES4iAq306vdlwW6iGSf+l5P4juH6lvATIh8CSymsAtQO/u2NymlekzpTl50tA+pFnmNIcUPxhgXc9IqOEv7sd47w5Sc3c= X-Gm-Message-State: AOJu0Yz8on0/xCTWDP+VbMU4fkiKNJuIftBivpNaSzaQmWtNMDbSOQUZ 0dtBfPCMp3+h+UgMorpq4YSr94f8LGdh9ySvSMnjti02gYleTqpp X-Google-Smtp-Source: AGHT+IFoDdOtGS9gwbKYOwGUtpbjsU7+MAXSCf2GYFyTLWZo25l/+TaxKDfthZ4jBDOvA2qcIQHI7A== X-Received: by 2002:a17:907:bb9a:b0:a46:d623:af0a with SMTP id xo26-20020a170907bb9a00b00a46d623af0amr1261736ejc.27.1710833403461; Tue, 19 Mar 2024 00:30:03 -0700 (PDT) Original-Received: from Pro.fritz.box (p4fe3a1bc.dip0.t-ipconnect.de. [79.227.161.188]) by smtp.gmail.com with ESMTPSA id x19-20020a170906135300b00a46e0a81a66sm370211ejb.149.2024.03.19.00.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 00:30:03 -0700 (PDT) In-Reply-To: <87jzlysmvp.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 19 Mar 2024 07:26:34 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317183 Archived-At: Philip Kaludercic writes: > Gerd M=C3=B6llmann writes: > >> Philip Kaludercic writes: >> >>>> (add-hook 'c-mode-hook #'macrostep-c-mode-hook) >>> >>> This part is suspicious. First of all, it looks like one is adding a >>> hook to a hook, but this would unconditionally modify >>> c-mode-hook, which I don't think is reliable. Can we find some other >>> way to update the variables, depending on the major mode? E.g. in >>> macrostep.el one could try to intern (format "macrostep-%s-init" >>> major-mode) and check if the symbol is fboundp? >> >> Also, it would be nice to support C++ and Objc, which we have in Emacs >> (c-mode-common-hook). > > From what I understand, this feature is based on cmacexp, which in turn > just uses cpp.=20=20 What's the problem using cpp?